AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Disable concurrent marking for cctests that rely on manual GC.

Browse Source 
BUG=chromium:694255

Review-Url: https://codereview.chromium.org/2910933002
Cr-Commit-Position: refs/heads/master@{#45570}
This commit is contained in:
ulan 2017-05-29 07:43:05 -07:00 committed by Commit Bot
parent 8ad8319e23
commit bc32a0a78f
3 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/cctest/heap/test-array-buffer-tracker.cc
View File

@ -114,6 +114,7 @@ TEST(ArrayBuffer_ScavengeAndMC) {
}
TEST(ArrayBuffer_Compaction) {
FLAG_concurrent_marking = false;
FLAG_stress_incremental_marking = false;
FLAG_manual_evacuation_candidates_selection = true;
CcTest::InitializeVM();

4
test/cctest/heap/test-compaction.cc
View File

@ -47,6 +47,7 @@ HEAP_TEST(CompactionFullAbortedPage) {
// Disable concurrent sweeping to ensure memory is in an expected state, i.e.,
// we can reach the state of a half aborted page.
FLAG_concurrent_sweeping = false;
FLAG_concurrent_marking = false;
FLAG_stress_incremental_marking = false;
FLAG_manual_evacuation_candidates_selection = true;
CcTest::InitializeVM();
@ -90,6 +91,7 @@ HEAP_TEST(CompactionPartiallyAbortedPage) {
// Disable concurrent sweeping to ensure memory is in an expected state, i.e.,
// we can reach the state of a half aborted page.
FLAG_concurrent_sweeping = false;
FLAG_concurrent_marking = false;
FLAG_stress_incremental_marking = false;
FLAG_manual_evacuation_candidates_selection = true;
@ -165,6 +167,7 @@ HEAP_TEST(CompactionPartiallyAbortedPageIntraAbortedPointers) {
// Disable concurrent sweeping to ensure memory is in an expected state, i.e.,
// we can reach the state of a half aborted page.
FLAG_concurrent_sweeping = false;
FLAG_concurrent_marking = false;
FLAG_stress_incremental_marking = false;
FLAG_manual_evacuation_candidates_selection = true;
@ -253,6 +256,7 @@ HEAP_TEST(CompactionPartiallyAbortedPageWithStoreBufferEntries) {
// Disable concurrent sweeping to ensure memory is in an expected state, i.e.,
// we can reach the state of a half aborted page.
FLAG_concurrent_sweeping = false;
FLAG_concurrent_marking = false;
FLAG_stress_incremental_marking = false;
FLAG_manual_evacuation_candidates_selection = true;

7
test/cctest/heap/test-heap.cc
View File

@ -742,6 +742,7 @@ TEST(BytecodeArray) {
static const int kFrameSize = 32;
static const int kParameterCount = 2;
FLAG_concurrent_marking = false;
FLAG_manual_evacuation_candidates_selection = true;
FLAG_stress_incremental_marking = false;
CcTest::InitializeVM();
@ -3157,6 +3158,7 @@ TEST(ReleaseOverReservedPages) {
// memory is distributed. Since this is non-deterministic because of
// concurrent sweeping, we disable it for this test.
FLAG_parallel_compaction = false;
FLAG_concurrent_marking = false;
// Concurrent sweeping adds non determinism, depending on when memory is
// available for further reuse.
FLAG_concurrent_sweeping = false;
@ -3867,6 +3869,7 @@ TEST(Regress513496) {
TEST(LargeObjectSlotRecording) {
if (!FLAG_incremental_marking) return;
FLAG_concurrent_marking = false;
FLAG_manual_evacuation_candidates_selection = true;
FLAG_stress_incremental_marking = false;
CcTest::InitializeVM();
@ -4858,6 +4861,7 @@ static void RequestInterrupt(const v8::FunctionCallbackInfo<v8::Value>& args) {
}
HEAP_TEST(Regress538257) {
FLAG_concurrent_marking = false;
FLAG_manual_evacuation_candidates_selection = true;
v8::Isolate::CreateParams create_params;
// Set heap limits.
@ -5656,6 +5660,7 @@ TEST(SharedFunctionInfoIterator) {
}
HEAP_TEST(Regress587004) {
FLAG_concurrent_marking = false;
FLAG_concurrent_sweeping = false;
#ifdef VERIFY_HEAP
FLAG_verify_heap = false;
@ -5698,6 +5703,7 @@ HEAP_TEST(Regress589413) {
FLAG_stress_compaction = true;
FLAG_manual_evacuation_candidates_selection = true;
FLAG_parallel_compaction = false;
FLAG_concurrent_marking = false;
FLAG_concurrent_sweeping = false;
CcTest::InitializeVM();
v8::HandleScope scope(CcTest::isolate());
@ -5945,6 +5951,7 @@ TEST(Regress631969) {
if (!FLAG_incremental_marking) return;
FLAG_manual_evacuation_candidates_selection = true;
FLAG_parallel_compaction = false;
FLAG_concurrent_marking = false;
FLAG_concurrent_sweeping = false;
CcTest::InitializeVM();
v8::HandleScope scope(CcTest::isolate());