AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[build][test] Remove configs for interpreted-regexp builder

Browse Source 
Also removes some obsolete gn definitions.

Bug: v8:8678
Change-Id: I418051177f059ab413b996a641ecf23f70d6c8bc
Reviewed-on: https://chromium-review.googlesource.com/c/1433789
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59163}
This commit is contained in:
Michael Achenbach 2019-01-24 14:45:45 +01:00 committed by Commit Bot
parent b0e1c2bfe5
commit bd6bc70a29
4 changed files with 1 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
BUILD.gn
View File

@ -98,10 +98,6 @@ declare_args() {
v8_enable_pointer_compression = false
v8_enable_31bit_smis_on_64bit_arch = false
# Interpreted regexp engine exists as platform-independent alternative
# based where the regular expression is compiled to a bytecode.
v8_interpreted_regexp = false
# Sets -dOBJECT_PRINT.
v8_enable_object_print = ""
@ -371,9 +367,6 @@ config("features") {
if (v8_enable_v8_checks) {
defines += [ "V8_ENABLE_CHECKS" ]
}
if (v8_interpreted_regexp || v8_enable_lite_mode) {
defines += [ "V8_INTERPRETED_REGEXP" ]
}
if (v8_deprecation_warnings) {
defines += [ "V8_DEPRECATION_WARNINGS" ]
}

7
infra/mb/mb_config.pyl
View File

@ -106,7 +106,6 @@
'V8 Linux64 - gcov coverage': 'release_x64_gcc_coverage',
'V8 Linux - predictable': 'release_x86_predictable',
'V8 Linux - full debug': 'full_debug_x86',
'V8 Linux - interpreted regexp': 'release_x86_interpreted_regexp',
'V8 Random Deopt Fuzzer - debug': 'debug_x64',
},
'client.v8.clusterfuzz': {
@ -538,8 +537,6 @@
'release_bot', 'x86', 'gcmole'],
'release_x86_gcmole_trybot': [
'release_trybot', 'x86', 'gcmole'],
'release_x86_interpreted_regexp': [
'release_bot', 'x86', 'v8_interpreted_regexp'],
'release_x86_minimal_symbols': [
'release_bot', 'x86', 'minimal_symbols'],
'release_x86_no_i18n_trybot': [
@ -833,10 +830,6 @@
'gn_args': 'v8_optimized_debug=false',
},
'v8_interpreted_regexp': {
'gn_args': 'v8_interpreted_regexp=true',
},
'v8_optimized_debug': {
# This is the default in gn for debug.
},

10
infra/testing/builders.pyl
View File

@ -674,16 +674,6 @@
},
],
},
'V8 Linux - interpreted regexp': {
'swarming_task_attrs': {
'expiration': 14400,
'hard_timeout': 3600,
'priority': 35,
},
'tests': [
{'name': 'v8testing'},
],
},
'V8 Linux - noi18n - debug': {
'tests': [
{'name': 'mozilla', 'variant': 'default'},

10
src/flag-definitions.h
View File

@ -1092,15 +1092,7 @@ DEFINE_UINT(serialization_chunk_size, 4096,
// Regexp
DEFINE_BOOL(regexp_optimization, true, "generate optimized regexp code")
DEFINE_BOOL(regexp_mode_modifiers, false, "enable inline flags in regexp.")
#ifdef V8_INTERPRETED_REGEXP
#define V8_INTERPRETED_REGEXP_BOOL true
#else
#define V8_INTERPRETED_REGEXP_BOOL false
#endif
DEFINE_BOOL(regexp_interpret_all, V8_INTERPRETED_REGEXP_BOOL,
"interpret all regexp code")
#undef V8_INTERPRETED_REGEXP_BOOL
DEFINE_BOOL(regexp_interpret_all, false, "interpret all regexp code")
// Testing flags test/cctest/test-{flags,api,serialization}.cc
DEFINE_BOOL(testing_bool_flag, true, "testing_bool_flag")