AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Use combine to make uint64_t from two uint32_t

Browse Source 
Change-Id: I946c9f0db1dcb91ab9414be2de8285444741ca3e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2293499
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68855}
This commit is contained in:
Ng Zhi An 2020-07-14 14:33:57 -07:00 committed by Commit Bot
parent be123e4057
commit bd96493519
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/backend/arm64/code-generator-arm64.cc
View File

@ -2560,9 +2560,9 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
DCHECK(AreConsecutive(src0, src1));
}
int64_t imm1 =
(i.InputInt32(2) & mask) | ((i.InputInt32(3) & mask) << 32);
make_uint64(i.InputInt32(3) & mask, i.InputInt32(2) & mask);
int64_t imm2 =
(i.InputInt32(4) & mask) | ((i.InputInt32(5) & mask) << 32);
make_uint64(i.InputInt32(5) & mask, i.InputInt32(4) & mask);
UseScratchRegisterScope scope(tasm());
VRegister temp = scope.AcquireV(kFormat16B);
__ Movi(temp, imm2, imm1);

6
src/compiler/backend/x64/code-generator-x64.cc
View File

@ -759,10 +759,8 @@ void AdjustStackPointerForTailCall(TurboAssembler* assembler,
void SetupSimdImmediateInRegister(TurboAssembler* assembler, uint32_t* imms,
XMMRegister reg) {
uint64_t value = make_uint64(imms[1], imms[0]);
assembler->Move(reg, value);
value = (imms[2]) | (uint64_t{imms[3]} << 32);
assembler->movq(kScratchRegister, value);
assembler->Move(reg, make_uint64(imms[1], imms[0]));
assembler->movq(kScratchRegister, make_uint64(imms[3], imms[2]));
assembler->Pinsrq(reg, kScratchRegister, int8_t{1});
}