AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm][traphandler] Remove errorneous enable_if

Browse Source 
The type std::enable_if<cond> does always exist, it only makes sense to
check for std::enable_if<cond>::type. But the way this is used here we
also cannot do that, so just replace this by a good old "#ifdef DEBUG".

Drive-by: Minor unrelated cleanup (constexpr and ifdef).

R=eholk@chromium.org

Change-Id: I6bc27ee3adfd3ec3d38d61df67dd9cdff0faf2f7
Reviewed-on: https://chromium-review.googlesource.com/939387
Reviewed-by: Eric Holk <eholk@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51612}
This commit is contained in:
Clemens Hammacher 2018-02-27 14:03:59 +01:00 committed by Commit Bot
parent 0365493a95
commit bdf669be07
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/trap-handler/handler-outside.cc
View File

@ -34,10 +34,10 @@
namespace {
size_t gNextCodeObject = 0;
#if defined(DEBUG)
const bool kEnableDebug = true;
#ifdef DEBUG
constexpr bool kEnableDebug = true;
#else
const bool kEnableDebug = false;
constexpr bool kEnableDebug = false;
#endif
}
@ -54,7 +54,7 @@ constexpr size_t HandlerDataSize(size_t num_protected_instructions) {
}
namespace {
template <typename = std::enable_if<kEnableDebug>>
#ifdef DEBUG
bool IsDisjoint(const CodeProtectionInfo* a, const CodeProtectionInfo* b) {
if (a == nullptr || b == nullptr) {
return true;
@ -65,6 +65,7 @@ bool IsDisjoint(const CodeProtectionInfo* a, const CodeProtectionInfo* b) {
return a_base >= b_base + b->size || b_base >= a_base + a->size;
}
#endif
// Verify that the code range does not overlap any that have already been
// registered.