AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Remove GotoIfNotBlack

Browse Source 
Was only used when concurrent marking was disabled at compile-time.

Change-Id: I3977a2cbcfb27e527b2bca4b49887558595c4215
Reviewed-on: https://chromium-review.googlesource.com/1128959
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@google.com>
Cr-Commit-Position: refs/heads/master@{#54384}
This commit is contained in:
Dominik Inführ 2018-07-12 07:57:40 +02:00 committed by Commit Bot
parent c2bbbb4216
commit bf553836f2
1 changed files with 0 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
src/builtins/builtins-internal-gen.cc
View File

@ -228,48 +228,6 @@ class RecordWriteCodeStubAssembler : public CodeStubAssembler {
IntPtrConstant(0)); IntPtrConstant(0));
} }
void GotoIfNotBlack(Node* object, Label* not_black) {
Label exit(this);
Label* black = &exit;
DCHECK_EQ(strcmp(Marking::kBlackBitPattern, "11"), 0);
Node* cell;
Node* mask;
GetMarkBit(object, &cell, &mask);
mask = TruncateIntPtrToInt32(mask);
Node* bits = Load(MachineType::Int32(), cell);
Node* bit_0 = Word32And(bits, mask);
GotoIf(Word32Equal(bit_0, Int32Constant(0)), not_black);
mask = Word32Shl(mask, Int32Constant(1));
Label word_boundary(this), in_word(this);
// If mask becomes zero, we know mask was `1 << 31`, i.e., the bit is on
// word boundary. Otherwise, the bit is within the word.
Branch(Word32Equal(mask, Int32Constant(0)), &word_boundary, &in_word);
BIND(&word_boundary);
{
Node* bit_1 = Word32And(
Load(MachineType::Int32(), IntPtrAdd(cell, IntPtrConstant(4))),
Int32Constant(1));
Branch(Word32Equal(bit_1, Int32Constant(0)), not_black, black);
}
BIND(&in_word);
{
Branch(Word32Equal(Word32And(bits, mask), Int32Constant(0)), not_black,
black);
}
BIND(&exit);
}
Node* IsWhite(Node* object) { Node* IsWhite(Node* object) {
DCHECK_EQ(strcmp(Marking::kWhiteBitPattern, "00"), 0); DCHECK_EQ(strcmp(Marking::kWhiteBitPattern, "00"), 0);
Node* cell; Node* cell;
@ -444,10 +402,6 @@ TF_BUILTIN(RecordWrite, RecordWriteCodeStubAssembler) {
{ {
Label call_incremental_wb(this); Label call_incremental_wb(this);
#ifndef V8_CONCURRENT_MARKING
GotoIfNotBlack(object, &exit);
#endif
// There are two cases we need to call incremental write barrier. // There are two cases we need to call incremental write barrier.
// 1) value_is_white // 1) value_is_white
GotoIf(IsWhite(value), &call_incremental_wb); GotoIf(IsWhite(value), &call_incremental_wb);