AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[tools] Fix detect-builtins.js

Browse Source 
- include non-default prototypes (useful for TypedArrays)
- print value of string/number properties (avoids endless recursion)

Review-Url: https://codereview.chromium.org/2048593004
Cr-Commit-Position: refs/heads/master@{#36849}
This commit is contained in:
jkummerow 2016-06-09 03:16:33 -07:00 committed by Commit bot
parent 6a5d769be2
commit bf5f2b5998
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/detect-builtins.js
View File

@ -24,6 +24,8 @@
}
// Avoid endless recursion.
if (this_name === "prototype" && name === "constructor") continue;
// Avoid needless duplication.
if (this_name === "__PROTO__" && name === "constructor") continue;
// Could get this from the parent, but having it locally is easier.
var property = { "name": name };
try {
@ -39,9 +41,18 @@
property.length = value.length;
property.prototype = GetProperties("prototype", value.prototype);
}
property.properties = GetProperties(name, value);
if (type === "string" || type === "number") {
property.value = value;
} else {
property.properties = GetProperties(name, value);
}
result[name] = property;
}
// Print the __proto__ if it's not the default Object prototype.
if (typeof object === "object" && object.__proto__ !== null &&
!object.__proto__.hasOwnProperty("__proto__")) {
result.__PROTO__ = GetProperties("__PROTO__", object.__proto__);
}
return result;
};