AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

v8: Fix -Wextra-semi warnings, enable warning.

Browse Source 
For macros expanding to function definitions, I removed the spurious ; after
macro invocations. For macros expandign to function declarations, I made the ;
required and consistently inserted it.

No behavior change.

Bug: chromium:926235
Change-Id: Ib8085d85d913d74307e3481f7fee4b7dc78c7549
Reviewed-on: https://chromium-review.googlesource.com/c/1467545
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59558}
This commit is contained in:
Nico Weber 2019-02-12 19:33:17 -05:00 committed by Commit Bot
parent 0ce2f3d43b
commit bff96cef06
128 changed files with 351 additions and 360 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
BUILD.gn
View File

@ -607,6 +607,9 @@ config("toolchain") {
cflags += [
"-Wmissing-field-initializers",
# TODO(thakis): Remove once enabled globally, https://crbug.com/926235
"-Wextra-semi",
# TODO(hans): Remove once http://crbug.com/428099 is resolved.
"-Winconsistent-missing-override",
]

2
src/allocation.cc
View File

@ -64,7 +64,7 @@ class PageAllocatorInitializer {
};
DEFINE_LAZY_LEAKY_OBJECT_GETTER(PageAllocatorInitializer,
GetPageTableInitializer);
GetPageTableInitializer)
// We will attempt allocation this many times. After each failure, we call
// OnCriticalMemoryPressure to try to free some memory.

2
src/api-inl.h
View File

@ -98,7 +98,7 @@ MAKE_TO_LOCAL(StackFrameToLocal, StackFrameInfo, StackFrame)
MAKE_TO_LOCAL(NumberToLocal, Object, Number)
MAKE_TO_LOCAL(IntegerToLocal, Object, Integer)
MAKE_TO_LOCAL(Uint32ToLocal, Object, Uint32)
MAKE_TO_LOCAL(ToLocal, BigInt, BigInt);
MAKE_TO_LOCAL(ToLocal, BigInt, BigInt)
MAKE_TO_LOCAL(ExternalToLocal, JSObject, External)
MAKE_TO_LOCAL(CallableToLocal, JSReceiver, Function)
MAKE_TO_LOCAL(ToLocalPrimitive, Object, Primitive)

16
src/arm/constants-arm.h
View File

@ -522,16 +522,16 @@ class Instruction {
inline Condition ConditionField() const {
return static_cast<Condition>(BitField(31, 28));
}
DECLARE_STATIC_TYPED_ACCESSOR(int, ConditionValue);
DECLARE_STATIC_TYPED_ACCESSOR(Condition, ConditionField);
DECLARE_STATIC_TYPED_ACCESSOR(int, ConditionValue)
DECLARE_STATIC_TYPED_ACCESSOR(Condition, ConditionField)
inline int TypeValue() const { return Bits(27, 25); }
inline int SpecialValue() const { return Bits(27, 23); }
inline int RnValue() const { return Bits(19, 16); }
DECLARE_STATIC_ACCESSOR(RnValue);
DECLARE_STATIC_ACCESSOR(RnValue)
inline int RdValue() const { return Bits(15, 12); }
DECLARE_STATIC_ACCESSOR(RdValue);
DECLARE_STATIC_ACCESSOR(RdValue)
inline int CoprocessorValue() const { return Bits(11, 8); }
// Support for VFP.
@ -573,7 +573,7 @@ class Instruction {
inline int SValue() const { return Bit(20); }
// with register
inline int RmValue() const { return Bits(3, 0); }
DECLARE_STATIC_ACCESSOR(RmValue);
DECLARE_STATIC_ACCESSOR(RmValue)
inline int ShiftValue() const { return static_cast<ShiftOp>(Bits(6, 5)); }
inline ShiftOp ShiftField() const {
return static_cast<ShiftOp>(BitField(6, 5));
@ -583,13 +583,13 @@ class Instruction {
inline int ShiftAmountValue() const { return Bits(11, 7); }
// with immediate
inline int RotateValue() const { return Bits(11, 8); }
DECLARE_STATIC_ACCESSOR(RotateValue);
DECLARE_STATIC_ACCESSOR(RotateValue)
inline int Immed8Value() const { return Bits(7, 0); }
DECLARE_STATIC_ACCESSOR(Immed8Value);
DECLARE_STATIC_ACCESSOR(Immed8Value)
inline int Immed4Value() const { return Bits(19, 16); }
inline int ImmedMovwMovtValue() const {
return Immed4Value() << 12 | Offset12Value(); }
DECLARE_STATIC_ACCESSOR(ImmedMovwMovtValue);
DECLARE_STATIC_ACCESSOR(ImmedMovwMovtValue)
// Fields used in Load/Store instructions
inline int PUValue() const { return Bits(24, 23); }

12
src/arm/register-arm.h
View File

@ -326,12 +326,12 @@ C_REGISTERS(DECLARE_C_REGISTER)
#undef DECLARE_C_REGISTER
// Define {RegisterName} methods for the register types.
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS);
DEFINE_REGISTER_NAMES(SwVfpRegister, FLOAT_REGISTERS);
DEFINE_REGISTER_NAMES(DwVfpRegister, DOUBLE_REGISTERS);
DEFINE_REGISTER_NAMES(LowDwVfpRegister, LOW_DOUBLE_REGISTERS);
DEFINE_REGISTER_NAMES(QwNeonRegister, SIMD128_REGISTERS);
DEFINE_REGISTER_NAMES(CRegister, C_REGISTERS);
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS)
DEFINE_REGISTER_NAMES(SwVfpRegister, FLOAT_REGISTERS)
DEFINE_REGISTER_NAMES(DwVfpRegister, DOUBLE_REGISTERS)
DEFINE_REGISTER_NAMES(LowDwVfpRegister, LOW_DOUBLE_REGISTERS)
DEFINE_REGISTER_NAMES(QwNeonRegister, SIMD128_REGISTERS)
DEFINE_REGISTER_NAMES(CRegister, C_REGISTERS)
// Give alias names to registers for calling conventions.
constexpr Register kReturnRegister0 = r0;

2
src/arm/simulator-arm.cc
View File

@ -25,7 +25,7 @@ namespace v8 {
namespace internal {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(Simulator::GlobalMonitor,
Simulator::GlobalMonitor::Get);
Simulator::GlobalMonitor::Get)
// This macro provides a platform independent use of sscanf. The reason for
// SScanF not being implemented in a platform independent way through

4
src/arm64/register-arm64.h
View File

@ -717,8 +717,8 @@ class CPURegList {
#define kCallerSavedV CPURegList::GetCallerSavedV()
// Define a {RegisterName} method for {Register} and {VRegister}.
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS);
DEFINE_REGISTER_NAMES(VRegister, VECTOR_REGISTERS);
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS)
DEFINE_REGISTER_NAMES(VRegister, VECTOR_REGISTERS)
// Give alias names to registers for calling conventions.
constexpr Register kReturnRegister0 = x0;

2
src/arm64/simulator-arm64.cc
View File

@ -58,7 +58,7 @@ TEXT_COLOUR clr_debug_message = FLAG_log_colour ? COLOUR(YELLOW) : "";
TEXT_COLOUR clr_printf = FLAG_log_colour ? COLOUR(GREEN) : "";
DEFINE_LAZY_LEAKY_OBJECT_GETTER(Simulator::GlobalMonitor,
Simulator::GlobalMonitor::Get);
Simulator::GlobalMonitor::Get)
// This is basically the same as PrintF, with a guard for FLAG_trace_sim.
void Simulator::TraceSim(const char* format, ...) {

2
src/asmjs/asm-scanner.cc
View File

@ -16,7 +16,7 @@ namespace {
// Cap number of identifiers to ensure we can assign both global and
// local ones a token id in the range of an int32_t.
static const int kMaxIdentifierCount = 0xF000000;
};
} // namespace
AsmJsScanner::AsmJsScanner(Utf16CharacterStream* stream)
: stream_(stream),

2
src/assert-scope.cc
View File

@ -16,7 +16,7 @@ namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(base::Thread::LocalStorageKey,
GetPerThreadAssertKey,
base::Thread::CreateThreadLocalKey());
base::Thread::CreateThreadLocalKey())
} // namespace

4
src/assert-scope.h
View File

@ -133,11 +133,9 @@ typedef PerThreadAssertScopeDebugOnly<HANDLE_ALLOCATION_ASSERT, true>
typedef PerThreadAssertScopeDebugOnly<HEAP_ALLOCATION_ASSERT, false>
DisallowHeapAllocation;
#ifdef DEBUG
#define DISALLOW_HEAP_ALLOCATION(name) DisallowHeapAllocation name
#define DISALLOW_HEAP_ALLOCATION_REF(name) const DisallowHeapAllocation& name
#define DISALLOW_HEAP_ALLOCATION(name) DisallowHeapAllocation name;
#else
#define DISALLOW_HEAP_ALLOCATION(name)
#define DISALLOW_HEAP_ALLOCATION_REF(name)
#endif
// Scope to introduce an exception to DisallowHeapAllocation.

2
src/base/macros.h
View File

@ -146,7 +146,7 @@ V8_INLINE Dest bit_cast(Source const& source) {
// odr-used by the definition of the destructor of that class, [...]
#define DISALLOW_NEW_AND_DELETE() \
void* operator new(size_t) { base::OS::Abort(); } \
void* operator new[](size_t) { base::OS::Abort(); }; \
void* operator new[](size_t) { base::OS::Abort(); } \
void operator delete(void*, size_t) { base::OS::Abort(); } \
void operator delete[](void*, size_t) { base::OS::Abort(); }

2
src/base/platform/platform-posix.cc
View File

@ -93,7 +93,7 @@ bool g_hard_abort = false;
const char* g_gc_fake_mmap = nullptr;
DEFINE_LAZY_LEAKY_OBJECT_GETTER(RandomNumberGenerator,
GetPlatformRandomNumberGenerator);
GetPlatformRandomNumberGenerator)
static LazyMutex rng_mutex = LAZY_MUTEX_INITIALIZER;
#if !V8_OS_FUCHSIA

2
src/base/platform/platform-win32.cc
View File

@ -690,7 +690,7 @@ void OS::StrNCpy(char* dest, int length, const char* src, size_t n) {
#undef STRUNCATE
DEFINE_LAZY_LEAKY_OBJECT_GETTER(RandomNumberGenerator,
GetPlatformRandomNumberGenerator);
GetPlatformRandomNumberGenerator)
static LazyMutex rng_mutex = LAZY_MUTEX_INITIALIZER;
void OS::Initialize(bool hard_abort, const char* const gc_fake_mmap) {

4
src/base/platform/time.cc
View File

@ -314,8 +314,8 @@ class Clock final {
};
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(Clock, GetClock);
};
DEFINE_LAZY_LEAKY_OBJECT_GETTER(Clock, GetClock)
}
Time Time::Now() { return GetClock()->Now(); }

2
src/basic-block-profiler.cc
View File

@ -13,7 +13,7 @@
namespace v8 {
namespace internal {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(BasicBlockProfiler, BasicBlockProfiler::Get);
DEFINE_LAZY_LEAKY_OBJECT_GETTER(BasicBlockProfiler, BasicBlockProfiler::Get)
BasicBlockProfiler::Data::Data(size_t n_blocks)
: n_blocks_(n_blocks),

32
src/builtins/builtins-array-gen.cc
View File

@ -3424,39 +3424,39 @@ TF_BUILTIN(ArrayNArgumentsConstructor, ArrayBuiltinsAssembler) {
// The ArrayNoArgumentConstructor builtin family.
GENERATE_ARRAY_CTOR(NoArgument, PackedSmi, PACKED_SMI_ELEMENTS, DontOverride,
DONT_OVERRIDE);
DONT_OVERRIDE)
GENERATE_ARRAY_CTOR(NoArgument, HoleySmi, HOLEY_SMI_ELEMENTS, DontOverride,
DONT_OVERRIDE);
DONT_OVERRIDE)
GENERATE_ARRAY_CTOR(NoArgument, PackedSmi, PACKED_SMI_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(NoArgument, HoleySmi, HOLEY_SMI_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(NoArgument, Packed, PACKED_ELEMENTS, DisableAllocationSites,
DISABLE_ALLOCATION_SITES);
DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(NoArgument, Holey, HOLEY_ELEMENTS, DisableAllocationSites,
DISABLE_ALLOCATION_SITES);
DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(NoArgument, PackedDouble, PACKED_DOUBLE_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(NoArgument, HoleyDouble, HOLEY_DOUBLE_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
// The ArraySingleArgumentConstructor builtin family.
GENERATE_ARRAY_CTOR(SingleArgument, PackedSmi, PACKED_SMI_ELEMENTS,
DontOverride, DONT_OVERRIDE);
DontOverride, DONT_OVERRIDE)
GENERATE_ARRAY_CTOR(SingleArgument, HoleySmi, HOLEY_SMI_ELEMENTS, DontOverride,
DONT_OVERRIDE);
DONT_OVERRIDE)
GENERATE_ARRAY_CTOR(SingleArgument, PackedSmi, PACKED_SMI_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(SingleArgument, HoleySmi, HOLEY_SMI_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(SingleArgument, Packed, PACKED_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(SingleArgument, Holey, HOLEY_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(SingleArgument, PackedDouble, PACKED_DOUBLE_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
GENERATE_ARRAY_CTOR(SingleArgument, HoleyDouble, HOLEY_DOUBLE_ELEMENTS,
DisableAllocationSites, DISABLE_ALLOCATION_SITES);
DisableAllocationSites, DISABLE_ALLOCATION_SITES)
#undef GENERATE_ARRAY_CTOR

16
src/code-reference.cc
View File

@ -87,14 +87,14 @@ struct CodeDescOps {
} \
}
DISPATCH(Address, constant_pool);
DISPATCH(Address, instruction_start);
DISPATCH(Address, instruction_end);
DISPATCH(int, instruction_size);
DISPATCH(const byte*, relocation_start);
DISPATCH(const byte*, relocation_end);
DISPATCH(int, relocation_size);
DISPATCH(Address, code_comments);
DISPATCH(Address, constant_pool)
DISPATCH(Address, instruction_start)
DISPATCH(Address, instruction_end)
DISPATCH(int, instruction_size)
DISPATCH(const byte*, relocation_start)
DISPATCH(const byte*, relocation_end)
DISPATCH(int, relocation_size)
DISPATCH(Address, code_comments)
#undef DISPATCH

2
src/code-reference.h
View File

@ -59,7 +59,7 @@ class CodeReference {
Handle<Code> js_code_;
};
DISALLOW_NEW_AND_DELETE();
DISALLOW_NEW_AND_DELETE()
};
ASSERT_TRIVIALLY_COPYABLE(CodeReference);

6
src/code-stub-assembler.cc
View File

@ -245,7 +245,7 @@ TNode<Object> CodeStubAssembler::NoContextConstant() {
std::declval<Heap>().rootAccessorName())>::type>::type>( \
LoadRoot(RootIndex::k##rootIndexName)); \
}
HEAP_MUTABLE_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_ACCESSOR);
HEAP_MUTABLE_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_ACCESSOR)
#undef HEAP_CONSTANT_ACCESSOR
#define HEAP_CONSTANT_ACCESSOR(rootIndexName, rootAccessorName, name) \
@ -256,7 +256,7 @@ HEAP_MUTABLE_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_ACCESSOR);
std::declval<ReadOnlyRoots>().rootAccessorName())>::type>::type>( \
LoadRoot(RootIndex::k##rootIndexName)); \
}
HEAP_IMMUTABLE_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_ACCESSOR);
HEAP_IMMUTABLE_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_ACCESSOR)
#undef HEAP_CONSTANT_ACCESSOR
#define HEAP_CONSTANT_TEST(rootIndexName, rootAccessorName, name) \
@ -268,7 +268,7 @@ HEAP_IMMUTABLE_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_ACCESSOR);
SloppyTNode<Object> value) { \
return WordNotEqual(value, name##Constant()); \
}
HEAP_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_TEST);
HEAP_IMMOVABLE_OBJECT_LIST(HEAP_CONSTANT_TEST)
#undef HEAP_CONSTANT_TEST
Node* CodeStubAssembler::IntPtrOrSmiConstant(int value, ParameterMode mode) {

2
src/code-stub-assembler.h
View File

@ -3531,7 +3531,7 @@ class ToDirectStringAssembler : public CodeStubAssembler {
const Flags flags_;
};
DEFINE_OPERATORS_FOR_FLAGS(CodeStubAssembler::AllocationFlags);
DEFINE_OPERATORS_FOR_FLAGS(CodeStubAssembler::AllocationFlags)
} // namespace internal
} // namespace v8

10
src/compiler/backend/instruction.h
View File

@ -307,7 +307,7 @@ class UnallocatedOperand final : public InstructionOperand {
return LifetimeField::decode(value_) == USED_AT_START;
}
INSTRUCTION_OPERAND_CASTS(UnallocatedOperand, UNALLOCATED);
INSTRUCTION_OPERAND_CASTS(UnallocatedOperand, UNALLOCATED)
// The encoding used for UnallocatedOperand operands depends on the policy
// that is
@ -370,7 +370,7 @@ class ConstantOperand : public InstructionOperand {
return InstructionOperand::New(zone, ConstantOperand(virtual_register));
}
INSTRUCTION_OPERAND_CASTS(ConstantOperand, CONSTANT);
INSTRUCTION_OPERAND_CASTS(ConstantOperand, CONSTANT)
STATIC_ASSERT(KindField::kSize == 3);
class VirtualRegisterField : public BitField64<uint32_t, 3, 32> {};
@ -403,7 +403,7 @@ class ImmediateOperand : public InstructionOperand {
return InstructionOperand::New(zone, ImmediateOperand(type, value));
}
INSTRUCTION_OPERAND_CASTS(ImmediateOperand, IMMEDIATE);
INSTRUCTION_OPERAND_CASTS(ImmediateOperand, IMMEDIATE)
STATIC_ASSERT(KindField::kSize == 3);
class TypeField : public BitField64<ImmediateType, 3, 1> {};
@ -521,7 +521,7 @@ class V8_EXPORT_PRIVATE ExplicitOperand
return InstructionOperand::New(zone, ExplicitOperand(kind, rep, index));
}
INSTRUCTION_OPERAND_CASTS(ExplicitOperand, EXPLICIT);
INSTRUCTION_OPERAND_CASTS(ExplicitOperand, EXPLICIT)
};
class AllocatedOperand : public LocationOperand {
@ -534,7 +534,7 @@ class AllocatedOperand : public LocationOperand {
return InstructionOperand::New(zone, AllocatedOperand(kind, rep, index));
}
INSTRUCTION_OPERAND_CASTS(AllocatedOperand, ALLOCATED);
INSTRUCTION_OPERAND_CASTS(AllocatedOperand, ALLOCATED)
};
#undef INSTRUCTION_OPERAND_CASTS

2
src/compiler/bytecode-graph-builder.cc
View File

@ -2805,7 +2805,7 @@ void BytecodeGraphBuilder::VisitDebugger() {
// We cannot create a graph from the debugger copy of the bytecode array.
#define DEBUG_BREAK(Name, ...) \
void BytecodeGraphBuilder::Visit##Name() { UNREACHABLE(); }
DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK);
DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK)
#undef DEBUG_BREAK
void BytecodeGraphBuilder::VisitIncBlockCounter() {

12
src/compiler/code-assembler.cc
View File

@ -1043,12 +1043,12 @@ Node* CodeAssembler::AtomicStore(MachineRepresentation rep, Node* base,
return raw_assembler()->Atomic##name(type, base, offset, value, \
value_high); \
}
ATOMIC_FUNCTION(Exchange);
ATOMIC_FUNCTION(Add);
ATOMIC_FUNCTION(Sub);
ATOMIC_FUNCTION(And);
ATOMIC_FUNCTION(Or);
ATOMIC_FUNCTION(Xor);
ATOMIC_FUNCTION(Exchange)
ATOMIC_FUNCTION(Add)
ATOMIC_FUNCTION(Sub)
ATOMIC_FUNCTION(And)
ATOMIC_FUNCTION(Or)
ATOMIC_FUNCTION(Xor)
#undef ATOMIC_FUNCTION
Node* CodeAssembler::AtomicCompareExchange(MachineType type, Node* base,

2
src/compiler/common-operator.cc
View File

@ -883,7 +883,7 @@ struct CommonOperatorGlobalCache final {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(CommonOperatorGlobalCache,
GetCommonOperatorGlobalCache);
GetCommonOperatorGlobalCache)
}
CommonOperatorBuilder::CommonOperatorBuilder(Zone* zone)

3
src/compiler/js-operator.cc
View File

@ -722,8 +722,7 @@ struct JSOperatorGlobalCache final {
};
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(JSOperatorGlobalCache,
GetJSOperatorGlobalCache);
DEFINE_LAZY_LEAKY_OBJECT_GETTER(JSOperatorGlobalCache, GetJSOperatorGlobalCache)
}
JSOperatorBuilder::JSOperatorBuilder(Zone* zone)

2
src/compiler/machine-operator.cc
View File

@ -818,7 +818,7 @@ struct CommentOperator : public Operator1<const char*> {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(MachineOperatorGlobalCache,
GetMachineOperatorGlobalCache);
GetMachineOperatorGlobalCache)
}
MachineOperatorBuilder::MachineOperatorBuilder(

2
src/compiler/node-matchers.h
View File

@ -427,7 +427,7 @@ enum class AddressOption : uint8_t {
};
typedef base::Flags<AddressOption, uint8_t> AddressOptions;
DEFINE_OPERATORS_FOR_FLAGS(AddressOptions);
DEFINE_OPERATORS_FOR_FLAGS(AddressOptions)
template <class AddMatcher>
struct BaseWithIndexAndDisplacementMatcher {

44
src/compiler/raw-machine-assembler.h
View File

@ -236,12 +236,12 @@ class V8_EXPORT_PRIVATE RawMachineAssembler {
DCHECK_NULL(value_high); \
return AddNode(machine()->Word32Atomic##name(rep), base, index, value); \
}
ATOMIC_FUNCTION(Exchange);
ATOMIC_FUNCTION(Add);
ATOMIC_FUNCTION(Sub);
ATOMIC_FUNCTION(And);
ATOMIC_FUNCTION(Or);
ATOMIC_FUNCTION(Xor);
ATOMIC_FUNCTION(Exchange)
ATOMIC_FUNCTION(Add)
ATOMIC_FUNCTION(Sub)
ATOMIC_FUNCTION(And)
ATOMIC_FUNCTION(Or)
ATOMIC_FUNCTION(Xor)
#undef ATOMIC_FUNCTION
#undef VALUE_HALVES
@ -496,18 +496,18 @@ class V8_EXPORT_PRIVATE RawMachineAssembler {
: prefix##32##name(a, b); \
}
INTPTR_BINOP(Int, Add);
INTPTR_BINOP(Int, AddWithOverflow);
INTPTR_BINOP(Int, Sub);
INTPTR_BINOP(Int, SubWithOverflow);
INTPTR_BINOP(Int, Mul);
INTPTR_BINOP(Int, Div);
INTPTR_BINOP(Int, LessThan);
INTPTR_BINOP(Int, LessThanOrEqual);
INTPTR_BINOP(Word, Equal);
INTPTR_BINOP(Word, NotEqual);
INTPTR_BINOP(Int, GreaterThanOrEqual);
INTPTR_BINOP(Int, GreaterThan);
INTPTR_BINOP(Int, Add)
INTPTR_BINOP(Int, AddWithOverflow)
INTPTR_BINOP(Int, Sub)
INTPTR_BINOP(Int, SubWithOverflow)
INTPTR_BINOP(Int, Mul)
INTPTR_BINOP(Int, Div)
INTPTR_BINOP(Int, LessThan)
INTPTR_BINOP(Int, LessThanOrEqual)
INTPTR_BINOP(Word, Equal)
INTPTR_BINOP(Word, NotEqual)
INTPTR_BINOP(Int, GreaterThanOrEqual)
INTPTR_BINOP(Int, GreaterThan)
#undef INTPTR_BINOP
@ -517,10 +517,10 @@ class V8_EXPORT_PRIVATE RawMachineAssembler {
: prefix##32##name(a, b); \
}
UINTPTR_BINOP(Uint, LessThan);
UINTPTR_BINOP(Uint, LessThanOrEqual);
UINTPTR_BINOP(Uint, GreaterThanOrEqual);
UINTPTR_BINOP(Uint, GreaterThan);
UINTPTR_BINOP(Uint, LessThan)
UINTPTR_BINOP(Uint, LessThanOrEqual)
UINTPTR_BINOP(Uint, GreaterThanOrEqual)
UINTPTR_BINOP(Uint, GreaterThan)
#undef UINTPTR_BINOP

2
src/compiler/simplified-operator.cc
View File

@ -1169,7 +1169,7 @@ struct SimplifiedOperatorGlobalCache final {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(SimplifiedOperatorGlobalCache,
GetSimplifiedOperatorGlobalCache);
GetSimplifiedOperatorGlobalCache)
}
SimplifiedOperatorBuilder::SimplifiedOperatorBuilder(Zone* zone)

2
src/compiler/type-cache.cc
View File

@ -10,7 +10,7 @@ namespace v8 {
namespace internal {
namespace compiler {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(const TypeCache, TypeCache::Get);
DEFINE_LAZY_LEAKY_OBJECT_GETTER(const TypeCache, TypeCache::Get)
} // namespace compiler
} // namespace internal

2
src/compiler/typer.h
View File

@ -56,7 +56,7 @@ class V8_EXPORT_PRIVATE Typer {
DISALLOW_COPY_AND_ASSIGN(Typer);
};
DEFINE_OPERATORS_FOR_FLAGS(Typer::Flags);
DEFINE_OPERATORS_FOR_FLAGS(Typer::Flags)
} // namespace compiler
} // namespace internal

2
src/contexts.h
View File

@ -669,7 +669,7 @@ class Context : public HeapObject {
static bool IsBootstrappingOrValidParentContext(Object object, Context kid);
#endif
OBJECT_CONSTRUCTORS(Context, HeapObject)
OBJECT_CONSTRUCTORS(Context, HeapObject);
};
class NativeContext : public Context {

2
src/elements.cc
View File

@ -1378,7 +1378,7 @@ class ElementsAccessorBase : public InternalElementsAccessor {
Handle<JSObject> object,
uint32_t length) final {
return Subclass::CreateListFromArrayLikeImpl(isolate, object, length);
};
}
static Handle<FixedArray> CreateListFromArrayLikeImpl(Isolate* isolate,
Handle<JSObject> object,

4
src/external-reference.cc
View File

@ -230,7 +230,7 @@ struct IsValidExternalReferenceType<Result (Class::*)(Args...)> {
}
FUNCTION_REFERENCE(incremental_marking_record_write_function,
IncrementalMarking::RecordWriteFromCode);
IncrementalMarking::RecordWriteFromCode)
ExternalReference ExternalReference::store_buffer_overflow_function() {
return ExternalReference(
@ -913,7 +913,7 @@ static int EnterMicrotaskContextWrapper(HandleScopeImplementer* hsi,
return 0;
}
FUNCTION_REFERENCE(call_enter_context_function, EnterMicrotaskContextWrapper);
FUNCTION_REFERENCE(call_enter_context_function, EnterMicrotaskContextWrapper)
bool operator==(ExternalReference lhs, ExternalReference rhs) {
return lhs.address() == rhs.address();

2
src/handler-table.h
View File

@ -110,7 +110,7 @@ class V8_EXPORT_PRIVATE HandlerTable {
// the GC heap (either {ByteArray} or {Code}) and hence would become stale
// during a collection. Hence we disallow any allocation.
Address raw_encoded_data_;
DISALLOW_HEAP_ALLOCATION(no_gc_);
DISALLOW_HEAP_ALLOCATION(no_gc_)
// Layout description for handler table based on ranges.
static const int kRangeStartIndex = 0;

4
src/heap/heap.h
View File

@ -2134,7 +2134,7 @@ class CodePageMemoryModificationScope {
// Disallow any GCs inside this scope, as a relocation of the underlying
// object would change the {MemoryChunk} that this scope targets.
DISALLOW_HEAP_ALLOCATION(no_heap_allocation_);
DISALLOW_HEAP_ALLOCATION(no_heap_allocation_)
};
// Visitor class to verify interior pointers in spaces that do not contain
@ -2234,7 +2234,7 @@ class HeapIterator {
private:
HeapObject NextObject();
DISALLOW_HEAP_ALLOCATION(no_heap_allocation_);
DISALLOW_HEAP_ALLOCATION(no_heap_allocation_)
Heap* heap_;
HeapObjectsFiltering filtering_;

6
src/heap/mark-compact.cc
View File

@ -2848,7 +2848,7 @@ class PageEvacuationTask : public ItemParallelJob::Task {
evacuator_->EvacuatePage(item->chunk());
item->MarkFinished();
}
};
}
private:
Evacuator* evacuator_;
@ -3170,7 +3170,7 @@ class PointersUpdatingTask : public ItemParallelJob::Task {
item->Process();
item->MarkFinished();
}
};
}
private:
GCTracer* tracer_;
@ -4415,7 +4415,7 @@ class YoungGenerationMarkingTask : public ItemParallelJob::Task {
PrintIsolate(collector_->isolate(), "marking[%p]: time=%f\n",
static_cast<void*>(this), marking_time);
}
};
}
void MarkObject(Object object) {
if (!Heap::InYoungGeneration(object)) return;

2
src/heap/scavenger.cc
View File

@ -65,7 +65,7 @@ class ScavengingTask final : public ItemParallelJob::Task {
static_cast<void*>(this), scavenging_time,
scavenger_->bytes_copied(), scavenger_->bytes_promoted());
}
};
}
private:
Heap* const heap_;

18
src/ia32/assembler-ia32.h
View File

@ -899,10 +899,10 @@ class V8_EXPORT_PRIVATE Assembler : public AssemblerBase {
} \
void instr##ps(XMMRegister dst, Operand src) { cmpps(dst, src, imm8); }
SSE_CMP_P(cmpeq, 0x0);
SSE_CMP_P(cmplt, 0x1);
SSE_CMP_P(cmple, 0x2);
SSE_CMP_P(cmpneq, 0x4);
SSE_CMP_P(cmpeq, 0x0)
SSE_CMP_P(cmplt, 0x1)
SSE_CMP_P(cmple, 0x2)
SSE_CMP_P(cmpneq, 0x4)
#undef SSE_CMP_P
@ -1517,7 +1517,7 @@ class V8_EXPORT_PRIVATE Assembler : public AssemblerBase {
vpd(opcode, dst, src1, src2); \
}
PACKED_OP_LIST(AVX_PACKED_OP_DECLARE);
PACKED_OP_LIST(AVX_PACKED_OP_DECLARE)
void vps(byte op, XMMRegister dst, XMMRegister src1, Operand src2);
void vpd(byte op, XMMRegister dst, XMMRegister src1, Operand src2);
@ -1530,10 +1530,10 @@ class V8_EXPORT_PRIVATE Assembler : public AssemblerBase {
vcmpps(dst, src1, src2, imm8); \
}
AVX_CMP_P(vcmpeq, 0x0);
AVX_CMP_P(vcmplt, 0x1);
AVX_CMP_P(vcmple, 0x2);
AVX_CMP_P(vcmpneq, 0x4);
AVX_CMP_P(vcmpeq, 0x0)
AVX_CMP_P(vcmplt, 0x1)
AVX_CMP_P(vcmple, 0x2)
AVX_CMP_P(vcmpneq, 0x4)
#undef AVX_CMP_P

4
src/ic/handler-configuration.h
View File

@ -180,7 +180,7 @@ class LoadHandler final : public DataHandler {
// Decodes the KeyedAccessLoadMode from a {handler}.
static KeyedAccessLoadMode GetKeyedAccessLoadMode(MaybeObject handler);
OBJECT_CONSTRUCTORS(LoadHandler, DataHandler)
OBJECT_CONSTRUCTORS(LoadHandler, DataHandler);
};
// A set of bit fields representing Smi handlers for stores and a HeapObject
@ -301,7 +301,7 @@ class StoreHandler final : public DataHandler {
int descriptor, FieldIndex field_index,
Representation representation);
OBJECT_CONSTRUCTORS(StoreHandler, DataHandler)
OBJECT_CONSTRUCTORS(StoreHandler, DataHandler);
};
} // namespace internal

2
src/identity-map.h
View File

@ -94,7 +94,7 @@ class IdentityMap : public IdentityMapBase {
explicit IdentityMap(Heap* heap,
AllocationPolicy allocator = AllocationPolicy())
: IdentityMapBase(heap), allocator_(allocator) {}
~IdentityMap() override { Clear(); };
~IdentityMap() override { Clear(); }
// Searches this map for the given key using the object's address
// as the identity, returning:

2
src/inspector/v8-runtime-agent-impl.cc
View File

@ -55,7 +55,7 @@ static const char customObjectFormatterEnabled[] =
"customObjectFormatterEnabled";
static const char runtimeEnabled[] = "runtimeEnabled";
static const char bindings[] = "bindings";
};
} // namespace V8RuntimeAgentImplState
using protocol::Runtime::RemoteObject;

4
src/interface-descriptors.h
View File

@ -847,7 +847,7 @@ class ConstructStubDescriptor : public CallInterfaceDescriptor {
public:
// TODO(jgruber): Remove the unused allocation site parameter.
DEFINE_JS_PARAMETERS(kAllocationSite)
DEFINE_JS_PARAMETER_TYPES(MachineType::AnyTagged());
DEFINE_JS_PARAMETER_TYPES(MachineType::AnyTagged())
// TODO(ishell): Use DECLARE_JS_COMPATIBLE_DESCRIPTOR if registers match
DECLARE_DESCRIPTOR(ConstructStubDescriptor, CallInterfaceDescriptor)
@ -870,7 +870,7 @@ class AllocateHeapNumberDescriptor : public CallInterfaceDescriptor {
class ArrayConstructorDescriptor : public CallInterfaceDescriptor {
public:
DEFINE_JS_PARAMETERS(kAllocationSite)
DEFINE_JS_PARAMETER_TYPES(MachineType::AnyTagged());
DEFINE_JS_PARAMETER_TYPES(MachineType::AnyTagged())
DECLARE_JS_COMPATIBLE_DESCRIPTOR(ArrayConstructorDescriptor,
CallInterfaceDescriptor, 1)

2
src/interpreter/bytecode-register.h
View File

@ -87,7 +87,7 @@ class V8_EXPORT_PRIVATE Register final {
}
private:
DISALLOW_NEW_AND_DELETE();
DISALLOW_NEW_AND_DELETE()
static const int kInvalidIndex = kMaxInt;
static const int kRegisterFileStartOffset =

2
src/interpreter/interpreter-generator.cc
View File

@ -3028,7 +3028,7 @@ IGNITION_HANDLER(Debugger, InterpreterAssembler) {
SetAccumulator(return_value); \
DispatchToBytecode(original_bytecode, BytecodeOffset()); \
}
DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK);
DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK)
#undef DEBUG_BREAK
// IncBlockCounter <slot>

2
src/layout-descriptor.h
View File

@ -142,7 +142,7 @@ class LayoutDescriptor : public ByteArray {
V8_INLINE V8_WARN_UNUSED_RESULT LayoutDescriptor SetTagged(int field_index,
bool tagged);
OBJECT_CONSTRUCTORS(LayoutDescriptor, ByteArray)
OBJECT_CONSTRUCTORS(LayoutDescriptor, ByteArray);
};

2
src/objects/api-callbacks-inl.h
View File

@ -37,7 +37,7 @@ ACCESSORS(AccessorInfo, expected_receiver_type, Object,
ACCESSORS_CHECKED2(AccessorInfo, getter, Object, kGetterOffset, true,
Foreign::IsNormalized(value))
ACCESSORS_CHECKED2(AccessorInfo, setter, Object, kSetterOffset, true,
Foreign::IsNormalized(value));
Foreign::IsNormalized(value))
ACCESSORS(AccessorInfo, js_getter, Object, kJsGetterOffset)
ACCESSORS(AccessorInfo, data, Object, kDataOffset)

2
src/objects/bigint.cc
View File

@ -209,7 +209,7 @@ class MutableBigInt : public FreshlyAllocatedBigInt {
NEVER_READ_ONLY_SPACE
OBJECT_CONSTRUCTORS(MutableBigInt, FreshlyAllocatedBigInt)
OBJECT_CONSTRUCTORS(MutableBigInt, FreshlyAllocatedBigInt);
};
OBJECT_CONSTRUCTORS_IMPL(MutableBigInt, FreshlyAllocatedBigInt)

8
src/objects/code.h
View File

@ -484,7 +484,7 @@ class Code::OptimizedCodeIterator {
Code current_code_;
Isolate* isolate_;
DISALLOW_HEAP_ALLOCATION(no_gc);
DISALLOW_HEAP_ALLOCATION(no_gc)
DISALLOW_COPY_AND_ASSIGN(OptimizedCodeIterator);
};
@ -601,7 +601,7 @@ class AbstractCode : public HeapObject {
// nesting that is deeper than 5 levels into account.
static const int kMaxLoopNestingMarker = 6;
OBJECT_CONSTRUCTORS(AbstractCode, HeapObject)
OBJECT_CONSTRUCTORS(AbstractCode, HeapObject);
};
// Dependent code is a singly linked list of weak fixed arrays. Each array
@ -712,7 +712,7 @@ class DependentCode : public WeakFixedArray {
class CountField : public BitField<int, 3, 27> {};
STATIC_ASSERT(kGroupCount <= GroupField::kMax + 1);
OBJECT_CONSTRUCTORS(DependentCode, WeakFixedArray)
OBJECT_CONSTRUCTORS(DependentCode, WeakFixedArray);
};
// BytecodeArray represents a sequence of interpreter bytecodes.
@ -928,7 +928,7 @@ class DeoptimizationData : public FixedArray {
static int LengthFor(int entry_count) { return IndexForEntry(entry_count); }
OBJECT_CONSTRUCTORS(DeoptimizationData, FixedArray)
OBJECT_CONSTRUCTORS(DeoptimizationData, FixedArray);
};
class SourcePositionTableWithFrameCache : public Tuple2 {

2
src/objects/data-handler.h
View File

@ -56,7 +56,7 @@ class DataHandler : public Struct {
class BodyDescriptor;
OBJECT_CONSTRUCTORS(DataHandler, Struct)
OBJECT_CONSTRUCTORS(DataHandler, Struct);
};
} // namespace internal

2
src/objects/debug-objects.h
View File

@ -139,7 +139,7 @@ class DebugInfo : public Struct {
// Id assigned to the function for debugging.
// This could also be implemented as a weak hash table.
DECL_INT_ACCESSORS(debugging_id);
DECL_INT_ACCESSORS(debugging_id)
// Bit positions in |debugger_hints|.
#define DEBUGGER_HINTS_BIT_FIELDS(V, _) \

12
src/objects/dictionary.h
View File

@ -86,7 +86,7 @@ class Dictionary : public HashTable<Derived, Shape> {
Handle<Object> value,
PropertyDetails details);
OBJECT_CONSTRUCTORS(Dictionary, HashTable<Derived, Shape>)
OBJECT_CONSTRUCTORS(Dictionary, HashTable<Derived, Shape>);
};
template <typename Key>
@ -188,7 +188,7 @@ class BaseNameDictionary : public Dictionary<Derived, Shape> {
Isolate* isolate, Handle<Derived> dictionary, Key key,
Handle<Object> value, PropertyDetails details, int* entry_out = nullptr);
OBJECT_CONSTRUCTORS(BaseNameDictionary, Dictionary<Derived, Shape>)
OBJECT_CONSTRUCTORS(BaseNameDictionary, Dictionary<Derived, Shape>);
};
class NameDictionary
@ -204,7 +204,7 @@ class NameDictionary
inline int hash() const;
OBJECT_CONSTRUCTORS(NameDictionary,
BaseNameDictionary<NameDictionary, NameDictionaryShape>)
BaseNameDictionary<NameDictionary, NameDictionaryShape>);
};
class GlobalDictionaryShape : public NameDictionaryShape {
@ -241,7 +241,7 @@ class GlobalDictionary
OBJECT_CONSTRUCTORS(
GlobalDictionary,
BaseNameDictionary<GlobalDictionary, GlobalDictionaryShape>)
BaseNameDictionary<GlobalDictionary, GlobalDictionaryShape>);
};
class NumberDictionaryBaseShape : public BaseDictionaryShape<uint32_t> {
@ -301,7 +301,7 @@ class SimpleNumberDictionary
OBJECT_CONSTRUCTORS(
SimpleNumberDictionary,
Dictionary<SimpleNumberDictionary, SimpleNumberDictionaryShape>)
Dictionary<SimpleNumberDictionary, SimpleNumberDictionaryShape>);
};
extern template class EXPORT_TEMPLATE_DECLARE(
@ -361,7 +361,7 @@ class NumberDictionary
static const uint32_t kPreferFastElementsSizeFactor = 3;
OBJECT_CONSTRUCTORS(NumberDictionary,
Dictionary<NumberDictionary, NumberDictionaryShape>)
Dictionary<NumberDictionary, NumberDictionaryShape>);
};
} // namespace internal

4
src/objects/fixed-array.h
View File

@ -111,7 +111,7 @@ class FixedArrayBase : public HeapObject {
// their ptr() is a Smi.
inline FixedArrayBase(Address ptr, AllowInlineSmiStorage allow_smi);
OBJECT_CONSTRUCTORS(FixedArrayBase, HeapObject)
OBJECT_CONSTRUCTORS(FixedArrayBase, HeapObject);
};
// FixedArray describes fixed-sized arrays with element type Object.
@ -583,7 +583,7 @@ class PodArray : public ByteArray {
class FixedTypedArrayBase : public FixedArrayBase {
public:
// [base_pointer]: Either points to the FixedTypedArrayBase itself or nullptr.
DECL_ACCESSORS(base_pointer, Object);
DECL_ACCESSORS(base_pointer, Object)
// [external_pointer]: Contains the offset between base_pointer and the start
// of the data. If the base_pointer is a nullptr, the external_pointer

12
src/objects/hash-table.h
View File

@ -126,7 +126,7 @@ class V8_EXPORT_PRIVATE HashTableBase : public NON_EXPORTED_BASE(FixedArray) {
return (last + number) & (size - 1);
}
OBJECT_CONSTRUCTORS(HashTableBase, FixedArray)
OBJECT_CONSTRUCTORS(HashTableBase, FixedArray);
};
template <typename Derived, typename Shape>
@ -241,7 +241,7 @@ class HashTable : public HashTableBase {
// Rehashes this hash-table into the new table.
void Rehash(Isolate* isolate, Derived new_table);
OBJECT_CONSTRUCTORS(HashTable, HashTableBase)
OBJECT_CONSTRUCTORS(HashTable, HashTableBase);
};
// HashTableKey is an abstract superclass for virtual key behavior.
@ -318,7 +318,7 @@ class ObjectHashTableBase : public HashTable<Derived, Shape> {
void AddEntry(int entry, Object key, Object value);
void RemoveEntry(int entry);
OBJECT_CONSTRUCTORS(ObjectHashTableBase, HashTable<Derived, Shape>)
OBJECT_CONSTRUCTORS(ObjectHashTableBase, HashTable<Derived, Shape>);
};
// ObjectHashTable maps keys that are arbitrary objects to object values by
@ -331,7 +331,7 @@ class ObjectHashTable
OBJECT_CONSTRUCTORS(
ObjectHashTable,
ObjectHashTableBase<ObjectHashTable, ObjectHashTableShape>)
ObjectHashTableBase<ObjectHashTable, ObjectHashTableShape>);
};
class EphemeronHashTableShape : public ObjectHashTableShape {
@ -354,7 +354,7 @@ class EphemeronHashTable
OBJECT_CONSTRUCTORS(
EphemeronHashTable,
ObjectHashTableBase<EphemeronHashTable, EphemeronHashTableShape>)
ObjectHashTableBase<EphemeronHashTable, EphemeronHashTableShape>);
};
class ObjectHashSetShape : public ObjectHashTableShape {
@ -374,7 +374,7 @@ class ObjectHashSet : public HashTable<ObjectHashSet, ObjectHashSetShape> {
DECL_CAST(ObjectHashSet)
OBJECT_CONSTRUCTORS(ObjectHashSet,
HashTable<ObjectHashSet, ObjectHashSetShape>)
HashTable<ObjectHashSet, ObjectHashSetShape>);
};
} // namespace internal

6
src/objects/instance-type-inl.h
View File

@ -17,7 +17,7 @@ namespace internal {
namespace InstanceTypeChecker {
// Define type checkers for classes with single instance type.
INSTANCE_TYPE_CHECKERS_SINGLE(INSTANCE_TYPE_CHECKER);
INSTANCE_TYPE_CHECKERS_SINGLE(INSTANCE_TYPE_CHECKER)
#define TYPED_ARRAY_INSTANCE_TYPE_CHECKER(Type, type, TYPE, ctype) \
INSTANCE_TYPE_CHECKER(Fixed##Type##Array, FIXED_##TYPE##_ARRAY_TYPE)
@ -35,7 +35,7 @@ STRUCT_LIST(STRUCT_INSTANCE_TYPE_CHECKER)
V8_INLINE bool Is##type(InstanceType instance_type) { \
return IsInRange(instance_type, first_instance_type, last_instance_type); \
}
INSTANCE_TYPE_CHECKERS_RANGE(INSTANCE_TYPE_CHECKER_RANGE);
INSTANCE_TYPE_CHECKERS_RANGE(INSTANCE_TYPE_CHECKER_RANGE)
#undef INSTANCE_TYPE_CHECKER_RANGE
V8_INLINE bool IsFixedArrayBase(InstanceType instance_type) {
@ -67,7 +67,7 @@ V8_INLINE bool IsJSReceiver(InstanceType instance_type) {
// TODO(v8:7786): For instance types that have a single map instance on the
// roots, and when that map is a embedded in the binary, compare against the map
// pointer rather than looking up the instance type.
INSTANCE_TYPE_CHECKERS(TYPE_CHECKER);
INSTANCE_TYPE_CHECKERS(TYPE_CHECKER)
#define TYPED_ARRAY_TYPE_CHECKER(Type, type, TYPE, ctype) \
TYPE_CHECKER(Fixed##Type##Array)

2
src/objects/intl-objects.cc
View File

@ -1730,7 +1730,7 @@ class ICUTimezoneCache : public base::TimezoneCache {
public:
ICUTimezoneCache() : timezone_(nullptr) { Clear(); }
~ICUTimezoneCache() override { Clear(); };
~ICUTimezoneCache() override { Clear(); }
const char* LocalTimezone(double time_ms) override;

2
src/objects/js-break-iterator.h
View File

@ -87,7 +87,7 @@ class JSV8BreakIterator : public JSObject {
DEFINE_FIELD_OFFSET_CONSTANTS(JSObject::kHeaderSize, BREAK_ITERATOR_FIELDS)
#undef BREAK_ITERATOR_FIELDS
OBJECT_CONSTRUCTORS(JSV8BreakIterator, JSObject)
OBJECT_CONSTRUCTORS(JSV8BreakIterator, JSObject);
};
} // namespace internal

4
src/objects/js-collator-inl.h
View File

@ -21,9 +21,9 @@ namespace internal {
OBJECT_CONSTRUCTORS_IMPL(JSCollator, JSObject)
ACCESSORS(JSCollator, icu_collator, Managed<icu::Collator>, kICUCollatorOffset)
ACCESSORS(JSCollator, bound_compare, Object, kBoundCompareOffset);
ACCESSORS(JSCollator, bound_compare, Object, kBoundCompareOffset)
CAST_ACCESSOR(JSCollator);
CAST_ACCESSOR(JSCollator)
} // namespace internal
} // namespace v8

2
src/objects/js-collator.h
View File

@ -57,7 +57,7 @@ class JSCollator : public JSObject {
#undef JS_COLLATOR_FIELDS
DECL_ACCESSORS(icu_collator, Managed<icu::Collator>)
DECL_ACCESSORS(bound_compare, Object);
DECL_ACCESSORS(bound_compare, Object)
OBJECT_CONSTRUCTORS(JSCollator, JSObject);
};

6
src/objects/js-date-time-format-inl.h
View File

@ -20,10 +20,10 @@ namespace internal {
OBJECT_CONSTRUCTORS_IMPL(JSDateTimeFormat, JSObject)
ACCESSORS(JSDateTimeFormat, icu_locale, Managed<icu::Locale>, kICULocaleOffset);
ACCESSORS(JSDateTimeFormat, icu_locale, Managed<icu::Locale>, kICULocaleOffset)
ACCESSORS(JSDateTimeFormat, icu_simple_date_format,
Managed<icu::SimpleDateFormat>, kICUSimpleDateFormatOffset)
ACCESSORS(JSDateTimeFormat, bound_format, Object, kBoundFormatOffset);
ACCESSORS(JSDateTimeFormat, bound_format, Object, kBoundFormatOffset)
SMI_ACCESSORS(JSDateTimeFormat, flags, kFlagsOffset)
inline void JSDateTimeFormat::set_hour_cycle(Intl::HourCycle hour_cycle) {
@ -58,7 +58,7 @@ inline JSDateTimeFormat::DateTimeStyle JSDateTimeFormat::time_style() const {
return TimeStyleBits::decode(flags());
}
CAST_ACCESSOR(JSDateTimeFormat);
CAST_ACCESSOR(JSDateTimeFormat)
} // namespace internal
} // namespace v8

2
src/objects/js-list-format-inl.h
View File

@ -48,7 +48,7 @@ inline JSListFormat::Type JSListFormat::type() const {
return TypeBits::decode(flags());
}
CAST_ACCESSOR(JSListFormat);
CAST_ACCESSOR(JSListFormat)
} // namespace internal
} // namespace v8

4
src/objects/js-locale-inl.h
View File

@ -21,9 +21,9 @@ namespace internal {
OBJECT_CONSTRUCTORS_IMPL(JSLocale, JSObject)
ACCESSORS(JSLocale, icu_locale, Managed<icu::Locale>, kICULocaleOffset);
ACCESSORS(JSLocale, icu_locale, Managed<icu::Locale>, kICULocaleOffset)
CAST_ACCESSOR(JSLocale);
CAST_ACCESSOR(JSLocale)
} // namespace internal
} // namespace v8

2
src/objects/js-number-format-inl.h
View File

@ -50,7 +50,7 @@ inline JSNumberFormat::CurrencyDisplay JSNumberFormat::currency_display()
return CurrencyDisplayBits::decode(flags());
}
CAST_ACCESSOR(JSNumberFormat);
CAST_ACCESSOR(JSNumberFormat)
} // namespace internal
} // namespace v8

2
src/objects/js-objects.h
View File

@ -1416,7 +1416,7 @@ class JSMessageObject : public JSObject {
kSize>
BodyDescriptor;
OBJECT_CONSTRUCTORS(JSMessageObject, JSObject)
OBJECT_CONSTRUCTORS(JSMessageObject, JSObject);
};
// The [Async-from-Sync Iterator] object

2
src/objects/js-plural-rules-inl.h
View File

@ -39,7 +39,7 @@ inline JSPluralRules::Type JSPluralRules::type() const {
return TypeBits::decode(flags());
}
CAST_ACCESSOR(JSPluralRules);
CAST_ACCESSOR(JSPluralRules)
} // namespace internal
} // namespace v8

2
src/objects/js-promise.h
View File

@ -100,7 +100,7 @@ class JSPromise : public JSObject {
Handle<Object> argument,
PromiseReaction::Type type);
OBJECT_CONSTRUCTORS(JSPromise, JSObject)
OBJECT_CONSTRUCTORS(JSPromise, JSObject);
};
} // namespace internal

2
src/objects/js-regexp.h
View File

@ -181,7 +181,7 @@ class JSRegExp : public JSObject {
// The uninitialized value for a regexp code object.
static const int kUninitializedValue = -1;
OBJECT_CONSTRUCTORS(JSRegExp, JSObject)
OBJECT_CONSTRUCTORS(JSRegExp, JSObject);
};
DEFINE_OPERATORS_FOR_FLAGS(JSRegExp::Flags)

2
src/objects/js-relative-time-format-inl.h
View File

@ -48,7 +48,7 @@ inline JSRelativeTimeFormat::Numeric JSRelativeTimeFormat::numeric() const {
return NumericBits::decode(flags());
}
CAST_ACCESSOR(JSRelativeTimeFormat);
CAST_ACCESSOR(JSRelativeTimeFormat)
} // namespace internal
} // namespace v8

2
src/objects/js-segment-iterator-inl.h
View File

@ -31,7 +31,7 @@ BIT_FIELD_ACCESSORS(JSSegmentIterator, flags, is_break_type_set,
SMI_ACCESSORS(JSSegmentIterator, flags, kFlagsOffset)
CAST_ACCESSOR(JSSegmentIterator);
CAST_ACCESSOR(JSSegmentIterator)
inline void JSSegmentIterator::set_granularity(
JSSegmenter::Granularity granularity) {

2
src/objects/js-segmenter-inl.h
View File

@ -37,7 +37,7 @@ inline JSSegmenter::Granularity JSSegmenter::granularity() const {
return GranularityBits::decode(flags());
}
CAST_ACCESSOR(JSSegmenter);
CAST_ACCESSOR(JSSegmenter)
} // namespace internal
} // namespace v8

2
src/objects/js-weak-refs.h
View File

@ -172,7 +172,7 @@ class FinalizationGroupCleanupJobTask : public Microtask {
FINALIZATION_GROUP_CLEANUP_JOB_TASK_FIELDS)
#undef FINALIZATION_GROUP_CLEANUP_JOB_TASK_FIELDS
OBJECT_CONSTRUCTORS(FinalizationGroupCleanupJobTask, Microtask)
OBJECT_CONSTRUCTORS(FinalizationGroupCleanupJobTask, Microtask);
};
class JSFinalizationGroupCleanupIterator : public JSObject {

20
src/objects/literal-objects-inl.h
View File

@ -20,7 +20,7 @@ OBJECT_CONSTRUCTORS_IMPL(ObjectBoilerplateDescription, FixedArray)
CAST_ACCESSOR(ObjectBoilerplateDescription)
SMI_ACCESSORS(ObjectBoilerplateDescription, flags,
FixedArray::OffsetOfElementAt(kLiteralTypeOffset));
FixedArray::OffsetOfElementAt(kLiteralTypeOffset))
OBJECT_CONSTRUCTORS_IMPL(ClassBoilerplate, FixedArray)
CAST_ACCESSOR(ClassBoilerplate)
@ -32,34 +32,34 @@ BIT_FIELD_ACCESSORS(ClassBoilerplate, flags, arguments_count,
ClassBoilerplate::Flags::ArgumentsCountBits)
SMI_ACCESSORS(ClassBoilerplate, flags,
FixedArray::OffsetOfElementAt(kFlagsIndex));
FixedArray::OffsetOfElementAt(kFlagsIndex))
ACCESSORS(ClassBoilerplate, static_properties_template, Object,
FixedArray::OffsetOfElementAt(kClassPropertiesTemplateIndex));
FixedArray::OffsetOfElementAt(kClassPropertiesTemplateIndex))
ACCESSORS(ClassBoilerplate, static_elements_template, Object,
FixedArray::OffsetOfElementAt(kClassElementsTemplateIndex));
FixedArray::OffsetOfElementAt(kClassElementsTemplateIndex))
ACCESSORS(ClassBoilerplate, static_computed_properties, FixedArray,
FixedArray::OffsetOfElementAt(kClassComputedPropertiesIndex));
FixedArray::OffsetOfElementAt(kClassComputedPropertiesIndex))
ACCESSORS(ClassBoilerplate, instance_properties_template, Object,
FixedArray::OffsetOfElementAt(kPrototypePropertiesTemplateIndex));
FixedArray::OffsetOfElementAt(kPrototypePropertiesTemplateIndex))
ACCESSORS(ClassBoilerplate, instance_elements_template, Object,
FixedArray::OffsetOfElementAt(kPrototypeElementsTemplateIndex));
FixedArray::OffsetOfElementAt(kPrototypeElementsTemplateIndex))
ACCESSORS(ClassBoilerplate, instance_computed_properties, FixedArray,
FixedArray::OffsetOfElementAt(kPrototypeComputedPropertiesIndex));
FixedArray::OffsetOfElementAt(kPrototypeComputedPropertiesIndex))
OBJECT_CONSTRUCTORS_IMPL(ArrayBoilerplateDescription, Struct)
CAST_ACCESSOR(ArrayBoilerplateDescription)
SMI_ACCESSORS(ArrayBoilerplateDescription, flags, kFlagsOffset);
SMI_ACCESSORS(ArrayBoilerplateDescription, flags, kFlagsOffset)
ACCESSORS(ArrayBoilerplateDescription, constant_elements, FixedArrayBase,
kConstantElementsOffset);
kConstantElementsOffset)
ElementsKind ArrayBoilerplateDescription::elements_kind() const {
return static_cast<ElementsKind>(flags());

4
src/objects/literal-objects.h
View File

@ -49,7 +49,7 @@ class ObjectBoilerplateDescription : public FixedArray {
private:
bool has_number_of_properties() const;
OBJECT_CONSTRUCTORS(ObjectBoilerplateDescription, FixedArray)
OBJECT_CONSTRUCTORS(ObjectBoilerplateDescription, FixedArray);
};
class ArrayBoilerplateDescription : public Struct {
@ -155,7 +155,7 @@ class ClassBoilerplate : public FixedArray {
private:
DECL_INT_ACCESSORS(flags)
OBJECT_CONSTRUCTORS(ClassBoilerplate, FixedArray)
OBJECT_CONSTRUCTORS(ClassBoilerplate, FixedArray);
};
} // namespace internal

2
src/objects/map.h
View File

@ -1018,7 +1018,7 @@ class NormalizedMapCache : public WeakFixedArray {
Object get(int index);
void set(int index, Object value);
OBJECT_CONSTRUCTORS(NormalizedMapCache, WeakFixedArray)
OBJECT_CONSTRUCTORS(NormalizedMapCache, WeakFixedArray);
};
} // namespace internal

2
src/objects/object-macros.h
View File

@ -25,7 +25,7 @@
const Type* operator->() const { return this; } \
\
protected: \
explicit inline Type(Address ptr);
explicit inline Type(Address ptr)
#define OBJECT_CONSTRUCTORS_IMPL(Type, Super) \
inline Type::Type(Address ptr) : Super(ptr) { SLOW_DCHECK(Is##Type()); }

16
src/objects/ordered-hash-table.h
View File

@ -222,7 +222,7 @@ class OrderedHashTable : public FixedArray {
return set(RemovedHolesIndex() + index, Smi::FromInt(removed_index));
}
OBJECT_CONSTRUCTORS(OrderedHashTable, FixedArray)
OBJECT_CONSTRUCTORS(OrderedHashTable, FixedArray);
private:
friend class OrderedNameDictionaryHandler;
@ -248,7 +248,7 @@ class OrderedHashSet : public OrderedHashTable<OrderedHashSet, 1> {
static inline bool Is(Handle<HeapObject> table);
static const int kPrefixSize = 0;
OBJECT_CONSTRUCTORS(OrderedHashSet, OrderedHashTable<OrderedHashSet, 1>)
OBJECT_CONSTRUCTORS(OrderedHashSet, OrderedHashTable<OrderedHashSet, 1>);
};
class OrderedHashMap : public OrderedHashTable<OrderedHashMap, 2> {
@ -279,7 +279,7 @@ class OrderedHashMap : public OrderedHashTable<OrderedHashMap, 2> {
static const int kValueOffset = 1;
static const int kPrefixSize = 0;
OBJECT_CONSTRUCTORS(OrderedHashMap, OrderedHashTable<OrderedHashMap, 2>)
OBJECT_CONSTRUCTORS(OrderedHashMap, OrderedHashTable<OrderedHashMap, 2>);
};
// This is similar to the OrderedHashTable, except for the memory
@ -571,7 +571,7 @@ class SmallOrderedHashTable : public HeapObject {
friend class OrderedNameDictionaryHandler;
friend class CodeStubAssembler;
OBJECT_CONSTRUCTORS(SmallOrderedHashTable, HeapObject)
OBJECT_CONSTRUCTORS(SmallOrderedHashTable, HeapObject);
};
class SmallOrderedHashSet : public SmallOrderedHashTable<SmallOrderedHashSet> {
@ -597,7 +597,7 @@ class SmallOrderedHashSet : public SmallOrderedHashTable<SmallOrderedHashSet> {
Handle<SmallOrderedHashSet> table,
int new_capacity);
OBJECT_CONSTRUCTORS(SmallOrderedHashSet,
SmallOrderedHashTable<SmallOrderedHashSet>)
SmallOrderedHashTable<SmallOrderedHashSet>);
};
class SmallOrderedHashMap : public SmallOrderedHashTable<SmallOrderedHashMap> {
@ -627,7 +627,7 @@ class SmallOrderedHashMap : public SmallOrderedHashTable<SmallOrderedHashMap> {
int new_capacity);
OBJECT_CONSTRUCTORS(SmallOrderedHashMap,
SmallOrderedHashTable<SmallOrderedHashMap>)
SmallOrderedHashTable<SmallOrderedHashMap>);
};
// TODO(gsathya): Rename this to OrderedHashTable, after we rename
@ -713,7 +713,7 @@ class OrderedNameDictionary
static const int kPrefixSize = 1;
OBJECT_CONSTRUCTORS(OrderedNameDictionary,
OrderedHashTable<OrderedNameDictionary, 3>)
OrderedHashTable<OrderedNameDictionary, 3>);
};
class OrderedNameDictionaryHandler
@ -807,7 +807,7 @@ class SmallOrderedNameDictionary
static inline RootIndex GetMapRootIndex();
OBJECT_CONSTRUCTORS(SmallOrderedNameDictionary,
SmallOrderedHashTable<SmallOrderedNameDictionary>)
SmallOrderedHashTable<SmallOrderedNameDictionary>);
};
class JSCollectionIterator : public JSObject {

6
src/objects/promise-inl.h
View File

@ -43,10 +43,10 @@ ACCESSORS(PromiseResolveThenableJobTask, then, JSReceiver, kThenOffset)
ACCESSORS(PromiseResolveThenableJobTask, thenable, JSReceiver, kThenableOffset)
ACCESSORS(PromiseReactionJobTask, context, Context, kContextOffset)
ACCESSORS(PromiseReactionJobTask, argument, Object, kArgumentOffset);
ACCESSORS(PromiseReactionJobTask, handler, HeapObject, kHandlerOffset);
ACCESSORS(PromiseReactionJobTask, argument, Object, kArgumentOffset)
ACCESSORS(PromiseReactionJobTask, handler, HeapObject, kHandlerOffset)
ACCESSORS(PromiseReactionJobTask, promise_or_capability, HeapObject,
kPromiseOrCapabilityOffset);
kPromiseOrCapabilityOffset)
ACCESSORS(PromiseCapability, promise, HeapObject, kPromiseOffset)
ACCESSORS(PromiseCapability, resolve, Object, kResolveOffset)

8
src/objects/promise.h
View File

@ -50,7 +50,7 @@ class PromiseReactionJobTask : public Microtask {
DECL_CAST(PromiseReactionJobTask)
DECL_VERIFIER(PromiseReactionJobTask)
OBJECT_CONSTRUCTORS(PromiseReactionJobTask, Microtask)
OBJECT_CONSTRUCTORS(PromiseReactionJobTask, Microtask);
};
// Struct to hold state required for a PromiseReactionJob of type "Fulfill".
@ -61,7 +61,7 @@ class PromiseFulfillReactionJobTask : public PromiseReactionJobTask {
DECL_PRINTER(PromiseFulfillReactionJobTask)
DECL_VERIFIER(PromiseFulfillReactionJobTask)
OBJECT_CONSTRUCTORS(PromiseFulfillReactionJobTask, PromiseReactionJobTask)
OBJECT_CONSTRUCTORS(PromiseFulfillReactionJobTask, PromiseReactionJobTask);
};
// Struct to hold state required for a PromiseReactionJob of type "Reject".
@ -72,7 +72,7 @@ class PromiseRejectReactionJobTask : public PromiseReactionJobTask {
DECL_PRINTER(PromiseRejectReactionJobTask)
DECL_VERIFIER(PromiseRejectReactionJobTask)
OBJECT_CONSTRUCTORS(PromiseRejectReactionJobTask, PromiseReactionJobTask)
OBJECT_CONSTRUCTORS(PromiseRejectReactionJobTask, PromiseReactionJobTask);
};
// A container struct to hold state required for PromiseResolveThenableJob.
@ -101,7 +101,7 @@ class PromiseResolveThenableJobTask : public Microtask {
DECL_PRINTER(PromiseResolveThenableJobTask)
DECL_VERIFIER(PromiseResolveThenableJobTask)
OBJECT_CONSTRUCTORS(PromiseResolveThenableJobTask, Microtask)
OBJECT_CONSTRUCTORS(PromiseResolveThenableJobTask, Microtask);
};
// Struct to hold the state of a PromiseCapability.

2
src/objects/property-descriptor-object.h
View File

@ -56,7 +56,7 @@ class PropertyDescriptorObject : public FixedArray {
static const int kSetOffset =
FixedArray::OffsetOfElementAt(PropertyDescriptorObject::kSetIndex);
OBJECT_CONSTRUCTORS(PropertyDescriptorObject, FixedArray)
OBJECT_CONSTRUCTORS(PropertyDescriptorObject, FixedArray);
};
} // namespace internal

2
src/objects/scope-info.h
View File

@ -321,7 +321,7 @@ class ScopeInfo : public FixedArray {
friend std::ostream& operator<<(std::ostream& os,
ScopeInfo::VariableAllocationInfo var);
OBJECT_CONSTRUCTORS(ScopeInfo, FixedArray)
OBJECT_CONSTRUCTORS(ScopeInfo, FixedArray);
};
std::ostream& operator<<(std::ostream& os,

4
src/objects/shared-function-info.h
View File

@ -629,7 +629,7 @@ class SharedFunctionInfo : public HeapObject {
Script::Iterator script_iterator_;
WeakArrayList::Iterator noscript_sfi_iterator_;
SharedFunctionInfo::ScriptIterator sfi_iterator_;
DISALLOW_HEAP_ALLOCATION(no_gc_);
DISALLOW_HEAP_ALLOCATION(no_gc_)
DISALLOW_COPY_AND_ASSIGN(GlobalIterator);
};
@ -733,7 +733,7 @@ class SharedFunctionInfoWithID : public SharedFunctionInfo {
static const int kAlignedSize = POINTER_SIZE_ALIGN(kSize);
OBJECT_CONSTRUCTORS(SharedFunctionInfoWithID, SharedFunctionInfo)
OBJECT_CONSTRUCTORS(SharedFunctionInfoWithID, SharedFunctionInfo);
};
// Printing support.

2
src/objects/string-inl.h
View File

@ -551,7 +551,7 @@ void ConsString::set_second(Isolate* isolate, String value,
CONDITIONAL_WRITE_BARRIER(*this, kSecondOffset, value, mode);
}
ACCESSORS(ThinString, actual, String, kActualOffset);
ACCESSORS(ThinString, actual, String, kActualOffset)
HeapObject ThinString::unchecked_actual() const {
return HeapObject::unchecked_cast(READ_FIELD(*this, kActualOffset));

4
src/objects/string-table.h
View File

@ -93,7 +93,7 @@ class StringTable : public HashTable<StringTable, StringTableShape> {
template <bool seq_one_byte>
friend class JsonParser;
OBJECT_CONSTRUCTORS(StringTable, HashTable<StringTable, StringTableShape>)
OBJECT_CONSTRUCTORS(StringTable, HashTable<StringTable, StringTableShape>);
};
class StringSetShape : public BaseShape<String> {
@ -114,7 +114,7 @@ class StringSet : public HashTable<StringSet, StringSetShape> {
bool Has(Isolate* isolate, Handle<String> name);
DECL_CAST(StringSet)
OBJECT_CONSTRUCTORS(StringSet, HashTable<StringSet, StringSetShape>)
OBJECT_CONSTRUCTORS(StringSet, HashTable<StringSet, StringSetShape>);
};
} // namespace internal

2
src/objects/struct.h
View File

@ -23,7 +23,7 @@ class Struct : public HeapObject {
DECL_CAST(Struct)
void BriefPrintDetails(std::ostream& os);
OBJECT_CONSTRUCTORS(Struct, HeapObject)
OBJECT_CONSTRUCTORS(Struct, HeapObject);
};
class Tuple2 : public Struct {

2
src/objects/templates.h
View File

@ -277,7 +277,7 @@ class ObjectTemplateInfo : public TemplateInfo {
class EmbedderFieldCount
: public BitField<int, IsImmutablePrototype::kNext, 29> {};
OBJECT_CONSTRUCTORS(ObjectTemplateInfo, TemplateInfo)
OBJECT_CONSTRUCTORS(ObjectTemplateInfo, TemplateInfo);
};
} // namespace internal

20
src/parsing/parse-info.h
View File

@ -94,28 +94,28 @@ class V8_EXPORT_PRIVATE ParseInfo {
FLAG_ACCESSOR(kIsDeclaration, is_declaration, set_declaration)
FLAG_ACCESSOR(kRequiresInstanceMembersInitializer,
requires_instance_members_initializer,
set_requires_instance_members_initializer);
set_requires_instance_members_initializer)
FLAG_ACCESSOR(kMightAlwaysOpt, might_always_opt, set_might_always_opt)
FLAG_ACCESSOR(kAllowNativeSyntax, allow_natives_syntax,
set_allow_natives_syntax)
FLAG_ACCESSOR(kAllowLazyCompile, allow_lazy_compile, set_allow_lazy_compile)
FLAG_ACCESSOR(kAllowNativeSyntax, allow_native_syntax,
set_allow_native_syntax);
set_allow_native_syntax)
FLAG_ACCESSOR(kAllowHarmonyPublicFields, allow_harmony_public_fields,
set_allow_harmony_public_fields);
set_allow_harmony_public_fields)
FLAG_ACCESSOR(kAllowHarmonyStaticFields, allow_harmony_static_fields,
set_allow_harmony_static_fields);
set_allow_harmony_static_fields)
FLAG_ACCESSOR(kAllowHarmonyDynamicImport, allow_harmony_dynamic_import,
set_allow_harmony_dynamic_import);
set_allow_harmony_dynamic_import)
FLAG_ACCESSOR(kAllowHarmonyImportMeta, allow_harmony_import_meta,
set_allow_harmony_import_meta);
set_allow_harmony_import_meta)
FLAG_ACCESSOR(kAllowHarmonyNumericSeparator, allow_harmony_numeric_separator,
set_allow_harmony_numeric_separator);
set_allow_harmony_numeric_separator)
FLAG_ACCESSOR(kAllowHarmonyPrivateFields, allow_harmony_private_fields,
set_allow_harmony_private_fields);
set_allow_harmony_private_fields)
FLAG_ACCESSOR(kAllowHarmonyPrivateMethods, allow_harmony_private_methods,
set_allow_harmony_private_methods);
FLAG_ACCESSOR(kIsOneshotIIFE, is_oneshot_iife, set_is_oneshot_iife);
set_allow_harmony_private_methods)
FLAG_ACCESSOR(kIsOneshotIIFE, is_oneshot_iife, set_is_oneshot_iife)
#undef FLAG_ACCESSOR
void set_parse_restriction(ParseRestriction restriction) {

14
src/parsing/parser-base.h
View File

@ -278,13 +278,13 @@ class ParserBase {
bool allow_##name() const { return allow_##name##_; } \
void set_allow_##name(bool allow) { allow_##name##_ = allow; }
ALLOW_ACCESSORS(natives);
ALLOW_ACCESSORS(harmony_public_fields);
ALLOW_ACCESSORS(harmony_static_fields);
ALLOW_ACCESSORS(harmony_dynamic_import);
ALLOW_ACCESSORS(harmony_import_meta);
ALLOW_ACCESSORS(harmony_private_methods);
ALLOW_ACCESSORS(eval_cache);
ALLOW_ACCESSORS(natives)
ALLOW_ACCESSORS(harmony_public_fields)
ALLOW_ACCESSORS(harmony_static_fields)
ALLOW_ACCESSORS(harmony_dynamic_import)
ALLOW_ACCESSORS(harmony_import_meta)
ALLOW_ACCESSORS(harmony_private_methods)
ALLOW_ACCESSORS(eval_cache)
#undef ALLOW_ACCESSORS

2
src/parsing/preparse-data-impl.h
View File

@ -59,7 +59,7 @@ class BaseConsumedPreparseData : public ConsumedPreparseData {
private:
ByteData* consumed_data_;
DISALLOW_HEAP_ALLOCATION(no_gc);
DISALLOW_HEAP_ALLOCATION(no_gc)
};
void SetPosition(int position) {

6
src/parsing/preparse-data.cc
View File

@ -456,7 +456,7 @@ class BuilderProducedPreparseData final : public ProducedPreparseData {
ZonePreparseData* Serialize(Zone* zone) final {
return builder_->Serialize(zone);
};
}
private:
PreparseDataBuilder* builder_;
@ -475,7 +475,7 @@ class OnHeapProducedPreparseData final : public ProducedPreparseData {
ZonePreparseData* Serialize(Zone* zone) final {
// Not required.
UNREACHABLE();
};
}
private:
Handle<PreparseData> data_;
@ -489,7 +489,7 @@ class ZoneProducedPreparseData final : public ProducedPreparseData {
return data_->Serialize(isolate);
}
ZonePreparseData* Serialize(Zone* zone) final { return data_; };
ZonePreparseData* Serialize(Zone* zone) final { return data_; }
private:
ZonePreparseData* data_;

6
src/ppc/constants-ppc.h
View File

@ -2829,11 +2829,11 @@ class Instruction {
inline int RSValue() const { return Bits(25, 21); }
inline int RTValue() const { return Bits(25, 21); }
inline int RAValue() const { return Bits(20, 16); }
DECLARE_STATIC_ACCESSOR(RAValue);
DECLARE_STATIC_ACCESSOR(RAValue)
inline int RBValue() const { return Bits(15, 11); }
DECLARE_STATIC_ACCESSOR(RBValue);
DECLARE_STATIC_ACCESSOR(RBValue)
inline int RCValue() const { return Bits(10, 6); }
DECLARE_STATIC_ACCESSOR(RCValue);
DECLARE_STATIC_ACCESSOR(RCValue)
inline int OpcodeValue() const { return static_cast<Opcode>(Bits(31, 26)); }
inline uint32_t OpcodeField() const {

4
src/ppc/register-ppc.h
View File

@ -286,8 +286,8 @@ C_REGISTERS(DECLARE_C_REGISTER)
#undef DECLARE_C_REGISTER
// Define {RegisterName} methods for the register types.
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS);
DEFINE_REGISTER_NAMES(DoubleRegister, DOUBLE_REGISTERS);
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS)
DEFINE_REGISTER_NAMES(DoubleRegister, DOUBLE_REGISTERS)
// Give alias names to registers for calling conventions.
constexpr Register kReturnRegister0 = r3;

2
src/ppc/simulator-ppc.cc
View File

@ -27,7 +27,7 @@ namespace v8 {
namespace internal {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(Simulator::GlobalMonitor,
Simulator::GlobalMonitor::Get);
Simulator::GlobalMonitor::Get)
// This macro provides a platform independent use of sscanf. The reason for
// SScanF not being implemented in a platform independent way through

2
src/profiler/cpu-profiler.cc
View File

@ -287,7 +287,7 @@ class CpuProfilersManager {
base::Mutex mutex_;
};
DEFINE_LAZY_LEAKY_OBJECT_GETTER(CpuProfilersManager, GetProfilersManager);
DEFINE_LAZY_LEAKY_OBJECT_GETTER(CpuProfilersManager, GetProfilersManager)
} // namespace

4
src/register-configuration.cc
View File

@ -92,7 +92,7 @@ class ArchDefaultRegisterConfiguration : public RegisterConfiguration {
};
DEFINE_LAZY_LEAKY_OBJECT_GETTER(ArchDefaultRegisterConfiguration,
GetDefaultRegisterConfiguration);
GetDefaultRegisterConfiguration)
// Allocatable registers with the masking register removed.
class ArchDefaultPoisoningRegisterConfiguration : public RegisterConfiguration {
@ -128,7 +128,7 @@ int ArchDefaultPoisoningRegisterConfiguration::allocatable_general_codes_
[kMaxAllocatableGeneralRegisterCount - 1];
DEFINE_LAZY_LEAKY_OBJECT_GETTER(ArchDefaultPoisoningRegisterConfiguration,
GetDefaultPoisoningRegisterConfiguration);
GetDefaultPoisoningRegisterConfiguration)
// RestrictedRegisterConfiguration uses the subset of allocatable general
// registers the architecture support, which results into generating assembly

2
src/runtime/runtime-test.cc
View File

@ -45,7 +45,7 @@ using WasmCompileControlsMap = std::map<v8::Isolate*, WasmCompileControls>;
// isolates concurrently. Methods need to hold the accompanying mutex on access.
// To avoid upsetting the static initializer count, we lazy initialize this.
DEFINE_LAZY_LEAKY_OBJECT_GETTER(WasmCompileControlsMap,
GetPerIsolateWasmControls);
GetPerIsolateWasmControls)
base::LazyMutex g_PerIsolateWasmControlsMutex = LAZY_MUTEX_INITIALIZER;
bool IsWasmCompileAllowed(v8::Isolate* isolate, v8::Local<v8::Value> value,

9
src/s390/constants-s390.h
View File

@ -1822,15 +1822,6 @@ class Instruction {
};
static OpcodeFormatType OpcodeFormatTable[256];
// Helper macro to define static accessors.
// We use the cast to char* trick to bypass the strict anti-aliasing rules.
#define DECLARE_STATIC_TYPED_ACCESSOR(return_type, Name) \
static inline return_type Name(Instr instr) { \
char* temp = reinterpret_cast<char*>(&instr); \
return reinterpret_cast<Instruction*>(temp)->Name(); \
}
#define DECLARE_STATIC_ACCESSOR(Name) DECLARE_STATIC_TYPED_ACCESSOR(int, Name)
// Get the raw instruction bits.
template <typename T>

4
src/s390/register-s390.h
View File

@ -246,8 +246,8 @@ C_REGISTERS(DECLARE_C_REGISTER)
#undef DECLARE_C_REGISTER
// Define {RegisterName} methods for the register types.
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS);
DEFINE_REGISTER_NAMES(DoubleRegister, DOUBLE_REGISTERS);
DEFINE_REGISTER_NAMES(Register, GENERAL_REGISTERS)
DEFINE_REGISTER_NAMES(DoubleRegister, DOUBLE_REGISTERS)
// Give alias names to registers for calling conventions.
constexpr Register kReturnRegister0 = r2;

2
src/safepoint-table.h
View File

@ -143,7 +143,7 @@ class SafepointTable {
static void PrintBits(std::ostream& os, // NOLINT
uint8_t byte, int digits);
DISALLOW_HEAP_ALLOCATION(no_allocation_);
DISALLOW_HEAP_ALLOCATION(no_allocation_)
Address instruction_start_;
uint32_t stack_slots_;
unsigned length_;

2
src/snapshot/code-serializer.h
View File

@ -68,7 +68,7 @@ class CodeSerializer : public Serializer {
bool SerializeReadOnlyObject(HeapObject obj);
DISALLOW_HEAP_ALLOCATION(no_gc_);
DISALLOW_HEAP_ALLOCATION(no_gc_)
uint32_t source_hash_;
DISALLOW_COPY_AND_ASSIGN(CodeSerializer);
};

Some files were not shown because too many files have changed in this diff Show More