AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Do not mark JS heap writable during compilation

Browse Source 
Now that wasm code lives in its own native heap, we no longer need to
switch protection for the js code space. Hence, remove a left-over
CodeSpaceMemoryModificationScope.

Change-Id: I80830bc4b0eee672c9e5c7ba0088ffcbc5b2da57
Bug: v8:7549
Reviewed-on: https://chromium-review.googlesource.com/960002
Commit-Queue: Stephan Herhut <herhut@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51899}
This commit is contained in:
Stephan Herhut 2018-03-13 10:32:46 +01:00 committed by Commit Bot
parent 7e45e961b2
commit c04e9e0cd8
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wasm/module-compiler.cc
View File

@ -3150,11 +3150,6 @@ class AsyncCompileJob::ExecuteAndFinishCompilationUnits : public CompileStep {
}
void RunInForeground() override {
// TODO(6792): No longer needed once WebAssembly code is off heap.
// Use base::Optional to be able to close the scope before we resolve or
// reject the promise.
base::Optional<CodeSpaceMemoryModificationScope> modification_scope(
base::in_place_t(), job_->isolate_->heap());
TRACE_COMPILE("(4a) Finishing compilation units...\n");
if (failed_) {
// The job failed already, no need to do more work.
@ -3206,9 +3201,6 @@ class AsyncCompileJob::ExecuteAndFinishCompilationUnits : public CompileStep {
// Make sure all compilation tasks stopped running.
job_->background_task_manager_.CancelAndWait();
// Close the CodeSpaceMemoryModificationScope before we reject the promise
// in AsyncCompileFailed. Promise::Reject calls directly into JavaScript.
modification_scope.reset();
return job_->AsyncCompileFailed(thrower);
}
if (job_->outstanding_units_ == 0) {