From c0c7680ec05458e852d65e1a525195d4fcf7717a Mon Sep 17 00:00:00 2001 From: Milad Farazmand Date: Wed, 15 Jan 2020 13:11:49 +0000 Subject: [PATCH] PPC/s390: [wasm-simd][liftoff] Support SIMD locals Port ba14c2f35437540952b1bba622ddb20a31e6a3ad Original Commit Message: Add kWasmS128 to the list of supported types, and implement Fill for all the architectures so that LocalGet works. Add a new test file to contain tests that run only on Liftoff, and assert that the code is indeed compiled by Liftoff. We cannot rely on the nooptimization variant for testing because by default, if Liftoff compilation fails, it will fall back to Turbofan, and we accidentally get a test passing. We skip these tests on mips architecture that don't support SIMD, since there is no way to implement these, and we don't have a "lowering" phase for Liftoff. As we implement more of SIMD in Liftoff, we can add more tests to this file and ensure correctness. Future patches will introduce support for globals and params. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I776b3d93dd4dc53641650ac30b26661e52142287 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002688 Reviewed-by: Clemens Backes Commit-Queue: Milad Farazmand Cr-Commit-Position: refs/heads/master@{#65792} --- test/cctest/cctest.status | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 5d31cf3df4..8b8a3900fe 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -386,6 +386,9 @@ # Liftoff is not currently supported on ppc and s390 'test-liftoff-*': [SKIP], + # SIMD not fully implemented yet + 'test-run-wasm-simd-liftoff/*': [SKIP], + }], # 'arch == ppc or arch == ppc64 or arch == s390 or arch == s390x' ['arch == ppc64', {