AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Intl] Not harden the array return by supportedLocalesOf

Browse Source 
see spec change in
https://github.com/tc39/ecma402/pull/278/

Bug: v8:8398
Change-Id: If5582f96d6dc3debdccb466d3d239efa52bbbf06
Reviewed-on: https://chromium-review.googlesource.com/c/1404436
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58717}
This commit is contained in:
Frank Tang 2019-01-10 09:34:08 -08:00 committed by Commit Bot
parent 82e58aaa80
commit c17d21a0fa
2 changed files with 10 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/objects/intl-objects.cc
View File

@ -1324,35 +1324,6 @@ Handle<JSArray> CreateArrayFromList(Isolate* isolate,
return array; return array;
} }
// TODO(bstell): should this be moved somewhere where it is reusable?
// Implement steps 5, 6, 7 for ECMA 402 9.2.9 SupportedLocales
// https://tc39.github.io/ecma402/#sec-supportedlocales
MaybeHandle<JSObject> CreateReadOnlyArray(Isolate* isolate,
std::vector<std::string> elements) {
if (elements.size() >= kMaxUInt32) {
THROW_NEW_ERROR(
isolate, NewRangeError(MessageTemplate::kInvalidArrayLength), JSObject);
}
PropertyAttributes attr =
static_cast<PropertyAttributes>(READ_ONLY | DONT_DELETE);
// 5. Let subset be CreateArrayFromList(elements).
Handle<JSArray> subset = CreateArrayFromList(isolate, elements, attr);
// 6. Let keys be subset.[[OwnPropertyKeys]]().
// 7.a. Let desc be PropertyDescriptor { [[Configurable]]: false,
// [[Writable]]: false }.
PropertyDescriptor desc;
desc.set_writable(false);
desc.set_configurable(false);
// 7.b. Perform ! DefinePropertyOrThrow(subset, P, desc).
JSArray::ArraySetLength(isolate, subset, &desc, kThrowOnError).ToChecked();
return subset;
}
// ECMA 402 9.2.9 SupportedLocales(availableLocales, requestedLocales, options) // ECMA 402 9.2.9 SupportedLocales(availableLocales, requestedLocales, options)
// https://tc39.github.io/ecma402/#sec-supportedlocales // https://tc39.github.io/ecma402/#sec-supportedlocales
MaybeHandle<JSObject> SupportedLocales( MaybeHandle<JSObject> SupportedLocales(
@ -1394,22 +1365,11 @@ MaybeHandle<JSObject> SupportedLocales(
LookupSupportedLocales(available_locales, requested_locales); LookupSupportedLocales(available_locales, requested_locales);
} }
// TODO(jkummerow): Possibly revisit why the spec has the individual entries // 5. Return CreateArrayFromList(supportedLocales).
// readonly but the array is not frozen. PropertyAttributes attr = static_cast<PropertyAttributes>(NONE);
// https://github.com/tc39/ecma402/issues/258 return CreateArrayFromList(isolate, supported_locales, attr);
// 5. Let subset be CreateArrayFromList(supportedLocales).
// 6. Let keys be subset.[[OwnPropertyKeys]]().
// 7. For each element P of keys in List order, do
// a. Let desc be PropertyDescriptor { [[Configurable]]: false,
// [[Writable]]: false }.
// b. Perform ! DefinePropertyOrThrow(subset, P, desc).
MaybeHandle<JSObject> subset =
CreateReadOnlyArray(isolate, supported_locales);
// 8. Return subset.
return subset;
} }
} // namespace } // namespace
// ecma-402 #sec-intl.getcanonicallocales // ecma-402 #sec-intl.getcanonicallocales

6
test/test262/test262.status
View File

@ -529,6 +529,12 @@
'language/expressions/call/eval-spread-empty-leading': [FAIL], 'language/expressions/call/eval-spread-empty-leading': [FAIL],
'language/expressions/call/eval-spread-empty-trailing': [FAIL], 'language/expressions/call/eval-spread-empty-trailing': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=8398
'intl402/supportedLocalesOf-returned-array-elements-are-frozen': [FAIL],
'intl402/ListFormat/constructor/supportedLocalesOf/result-type': [FAIL],
'intl402/RelativeTimeFormat/constructor/supportedLocalesOf/result-type': [FAIL],
'intl402/Segmenter/constructor/supportedLocalesOf/result-type': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7472 # https://bugs.chromium.org/p/v8/issues/detail?id=7472
'intl402/NumberFormat/currency-digits': [FAIL], 'intl402/NumberFormat/currency-digits': [FAIL],