From c1e24b60875991f3e7be47e657a2515b29f19040 Mon Sep 17 00:00:00 2001 From: wychen Date: Tue, 2 May 2017 01:49:38 -0700 Subject: [PATCH] Split GN target v8_headers for browser non-code dependency This is for https://crrev.com/2851953002/ BUG= chromium:716359 Review-Url: https://codereview.chromium.org/2853783002 Cr-Commit-Position: refs/heads/master@{#45009} --- BUILD.gn | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 7e78fb0c6c..7c2f052f20 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -1018,6 +1018,21 @@ v8_header_set("v8_version") { ] } +# This is split out to be a non-code containing target that the Chromium browser +# can depend upon to get basic v8 types. +v8_header_set("v8_headers") { + configs = [ ":internal_config" ] + + sources = [ + "include/v8.h", + "include/v8config.h", + ] + + deps = [ + ":v8_version", + ] +} + v8_source_set("v8_base") { visibility = [ ":*" ] # Only targets in this file can depend on this. @@ -2366,9 +2381,9 @@ v8_source_set("v8_base") { defines = [] deps = [ + ":v8_headers", ":v8_libbase", ":v8_libsampler", - ":v8_version", "src/inspector:inspector", ]