From c2455500f4a88a00ebb4fb2a27c4f46aff560bf5 Mon Sep 17 00:00:00 2001 From: Tom Anderson Date: Mon, 4 Jun 2018 10:56:49 -0700 Subject: [PATCH] Remove manual references to exe_and_shlib_deps After [1], a manual dependency on exe_and_shlib_deps is no longer necessary since it's automatically added. This CL removes all remaining manual references to exe_and_shlib_deps. [1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5 BUG=chromium:845700 R=machenbach Change-Id: I17da573b7b6509a690caf8be6ae6afc180105f07 Reviewed-on: https://chromium-review.googlesource.com/1082913 Commit-Queue: Thomas Anderson Reviewed-by: Michael Achenbach Cr-Commit-Position: refs/heads/master@{#53500} --- BUILD.gn | 8 -------- test/cctest/BUILD.gn | 2 -- test/inspector/BUILD.gn | 1 - test/mkgrokdump/BUILD.gn | 1 - test/unittests/BUILD.gn | 2 -- 5 files changed, 14 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 189c11f5d5..2c50262a7e 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -3059,7 +3059,6 @@ if (v8_monolithic) { ":v8_libbase", ":v8_libplatform", ":v8_libsampler", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] @@ -3087,7 +3086,6 @@ if (v8_use_snapshot && current_toolchain == v8_snapshot_toolchain) { ":v8_libbase", ":v8_libplatform", ":v8_nosnapshot", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] } @@ -3141,7 +3139,6 @@ if (current_toolchain == v8_snapshot_toolchain) { deps = [ ":v8_libbase", "third_party/antlr4:antlr4", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] @@ -3315,7 +3312,6 @@ v8_executable("d8") { ":v8", ":v8_libbase", ":v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] @@ -3352,7 +3348,6 @@ v8_executable("v8_hello_world") { ":v8", ":v8_libbase", ":v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] } @@ -3373,7 +3368,6 @@ v8_executable("v8_sample_process") { ":v8", ":v8_libbase", ":v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] } @@ -3395,7 +3389,6 @@ if (want_v8_shell) { ":v8", ":v8_libbase", ":v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] } @@ -3407,7 +3400,6 @@ template("v8_fuzzer") { v8_executable("v8_simple_" + name) { deps = [ ":" + name, - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] diff --git a/test/cctest/BUILD.gn b/test/cctest/BUILD.gn index 273cc1129d..2ac483d32c 100644 --- a/test/cctest/BUILD.gn +++ b/test/cctest/BUILD.gn @@ -377,7 +377,6 @@ v8_source_set("cctest_sources") { "../..:v8_libbase", "../..:v8_libplatform", "../..:wasm_module_runner", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] @@ -474,7 +473,6 @@ v8_executable("generate-bytecode-expectations") { "../..:v8", "../..:v8_libbase", "../..:v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] } diff --git a/test/inspector/BUILD.gn b/test/inspector/BUILD.gn index 0999e19b89..fc3d51506f 100644 --- a/test/inspector/BUILD.gn +++ b/test/inspector/BUILD.gn @@ -24,7 +24,6 @@ v8_executable("inspector-test") { "../..:v8", "../..:v8_libbase", "../..:v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] diff --git a/test/mkgrokdump/BUILD.gn b/test/mkgrokdump/BUILD.gn index e35ce57d84..eae9f26578 100644 --- a/test/mkgrokdump/BUILD.gn +++ b/test/mkgrokdump/BUILD.gn @@ -21,7 +21,6 @@ v8_executable("mkgrokdump") { "../..:v8", "../..:v8_libbase", "../..:v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", ] diff --git a/test/unittests/BUILD.gn b/test/unittests/BUILD.gn index 4d41f9dfaf..f7ff8cd699 100644 --- a/test/unittests/BUILD.gn +++ b/test/unittests/BUILD.gn @@ -17,7 +17,6 @@ v8_executable("unittests") { "../..:v8_for_testing", "../..:v8_libbase", "../..:v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", "//testing/gmock", "//testing/gtest", @@ -248,7 +247,6 @@ v8_source_set("unittests_sources") { "../..:v8_for_testing", "../..:v8_libbase", "../..:v8_libplatform", - "//build/config:exe_and_shlib_deps", "//build/win:default_exe_manifest", "//testing/gmock", "//testing/gtest",