AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove bogus DCHECK and add a comment

Browse Source 
Bug: chromium:1062916
Change-Id: Ic29ca849fb17c1409cc11018fdbc9d3363ebd55c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110027
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66801}
This commit is contained in:
Georg Neis 2020-03-19 17:30:21 +01:00 committed by Commit Bot
parent 7905090da2
commit c25cc4e273
2 changed files with 27 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/compiler/constant-folding-reducer.cc
View File

@ -43,18 +43,16 @@ Node* TryGetConstant(JSGraph* jsgraph, Node* node) {
bool IsAlreadyBeingFolded(Node* node) { bool IsAlreadyBeingFolded(Node* node) {
DCHECK(FLAG_assert_types); DCHECK(FLAG_assert_types);
if (node->opcode() == IrOpcode::kFoldConstant) return true; if (node->opcode() == IrOpcode::kFoldConstant) return true;
bool found = false;
for (Edge edge : node->use_edges()) { for (Edge edge : node->use_edges()) {
if (!NodeProperties::IsValueEdge(edge)) continue; if (NodeProperties::IsValueEdge(edge) &&
if (edge.from()->opcode() == IrOpcode::kFoldConstant) { edge.from()->opcode() == IrOpcode::kFoldConstant) {
DCHECK(!found); // Note: {node} may have gained new value uses since the time it was
found = true; // "constant-folded", and theses uses should ideally be rewritten as well.
#ifndef ENABLE_SLOW_DCHECKS // For simplicity, we ignore them here.
break; return true;
#endif
} }
} }
return found; return false;
} }
} // namespace } // namespace

20
test/mjsunit/compiler/regress-1062916.js Normal file
View File

@ -0,0 +1,20 @@
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --no-analyze-environment-liveness --no-use-ic
function foo(x) {
var a = [];
for (var k1 in x) {
for (var k2 in x) {
a.k2;
}
}
return a.join();
}
%PrepareFunctionForOptimization(foo);
foo({p: 42});
%OptimizeFunctionOnNextCall(foo);
foo();