AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[baseline] Fix compilation on platforms without sparkplug

Browse Source 
A few of the changes added by https://crrev.com/c/3229379 are
causing compilation errors on platforms without sparkplug.

Change-Id: Ic6088b33ba910ae5a96881fa7609e30d35db5d8a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226548
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#77456}
This commit is contained in:
Milad Fa 2021-10-18 12:55:11 -04:00 committed by V8 LUCI CQ
parent b7acd5100b
commit c2757f6ca2
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/baseline/baseline-batch-compiler.cc
View File

@ -365,6 +365,8 @@ namespace v8 {
namespace internal { namespace internal {
namespace baseline { namespace baseline {
class ConcurrentBaselineCompiler {};
BaselineBatchCompiler::BaselineBatchCompiler(Isolate* isolate) BaselineBatchCompiler::BaselineBatchCompiler(Isolate* isolate)
: isolate_(isolate), : isolate_(isolate),
compilation_queue_(Handle<WeakFixedArray>::null()), compilation_queue_(Handle<WeakFixedArray>::null()),
@ -379,6 +381,8 @@ BaselineBatchCompiler::~BaselineBatchCompiler() {
} }
} }
void BaselineBatchCompiler::InstallBatch() { UNREACHABLE(); }
} // namespace baseline } // namespace baseline
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8

2
src/flags/flag-definitions.h
View File

@ -709,6 +709,8 @@ DEFINE_NEG_IMPLICATION(concurrent_sparkplug, write_protect_code_memory)
#endif #endif
#else #else
DEFINE_BOOL(baseline_batch_compilation, false, "batch compile Sparkplug code") DEFINE_BOOL(baseline_batch_compilation, false, "batch compile Sparkplug code")
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
"compile Sparkplug code in a background thread")
#endif #endif
DEFINE_STRING(sparkplug_filter, "*", "filter for Sparkplug baseline compiler") DEFINE_STRING(sparkplug_filter, "*", "filter for Sparkplug baseline compiler")
DEFINE_BOOL(sparkplug_needs_short_builtins, false, DEFINE_BOOL(sparkplug_needs_short_builtins, false,