AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Require pointer_compression_shared_cage for virtual_memory_cage

Browse Source 
The shared pointer compression cage is a requirement for the V8 virtual
memory cage, and there are some configurations that don't enable the
former but enable the latter, which thus break.

Bug: chromium:1218005
Change-Id: I734598a952ccafd57e4ed63a71e76e4dc252057e
Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211996
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77305}
This commit is contained in:
Samuel Groß 2021-10-08 16:25:02 +02:00 committed by V8 LUCI CQ
parent 5b4b305ae1
commit c3068d133b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
BUILD.gn
View File

@ -476,8 +476,7 @@ if (build_with_chromium && v8_current_cpu == "arm64" &&
}
# Enable the virtual memory cage on 64-bit Chromium builds.
if (build_with_chromium &&
(v8_current_cpu == "arm64" || v8_current_cpu == "x64")) {
if (build_with_chromium && v8_enable_pointer_compression_shared_cage) {
# The cage is incompatible with lsan.
v8_enable_virtual_memory_cage = !is_lsan
}