AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[liftoff] Ignore num locals in total frame slot count

Browse Source 
Whenever we spill, num_used_spill_bytes_ is already updated using
RecordSpillSpillSlot, so we don't need to add the number of locals.

Bug: v8:9909
Change-Id: Ieecf957e71e0711be744a3f378d8ae11b941fc5b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947349
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65306}
This commit is contained in:
Ng Zhi An 2019-12-03 04:42:51 -08:00 committed by Commit Bot
parent 7a51fe240b
commit c31ea1e8d0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wasm/baseline/liftoff-assembler.h
View File

@ -679,8 +679,7 @@ class LiftoffAssembler : public TurboAssembler {
uint32_t GetTotalFrameSlotCount() const {
// TODO(zhin): Temporary for migration from index to offset.
return num_locals_ +
((num_used_spill_bytes_ + kStackSlotSize - 1) / kStackSlotSize);
return ((num_used_spill_bytes_ + kStackSlotSize - 1) / kStackSlotSize);
}
uint32_t GetTotalFrameSlotSize() const { return num_used_spill_bytes_; }