diff --git a/src/runtime.cc b/src/runtime.cc index 0d15e05eaa..ef0609e196 100644 --- a/src/runtime.cc +++ b/src/runtime.cc @@ -4061,7 +4061,9 @@ static Object* Runtime_ResolvePossiblyDirectEval(Arguments args) { while (!context.is_null()) { receiver = context->Lookup(Factory::eval_symbol(), FOLLOW_PROTOTYPE_CHAIN, &index, &attributes); - if (attributes != ABSENT) break; + // Stop search when eval is found or when the global context is + // reached. + if (attributes != ABSENT || context->IsGlobalContext()) break; if (context->is_function_context()) { context = Handle(Context::cast(context->closure()->context())); } else { @@ -4069,6 +4071,15 @@ static Object* Runtime_ResolvePossiblyDirectEval(Arguments args) { } } + // If eval could not be resolved, it has been deleted and we need to + // throw a reference error. + if (attributes == ABSENT) { + Handle name = Factory::eval_symbol(); + Handle reference_error = + Factory::NewReferenceError("not_defined", HandleVector(&name, 1)); + return Top::Throw(*reference_error); + } + if (context->IsGlobalContext()) { // 'eval' is bound in the global context, but it may have been overwritten. // Compare it to the builtin 'GlobalEval' function to make sure. diff --git a/test/mjsunit/regress/regress-221.js b/test/mjsunit/regress/regress-221.js new file mode 100644 index 0000000000..d3f2e35539 --- /dev/null +++ b/test/mjsunit/regress/regress-221.js @@ -0,0 +1,34 @@ +// Copyright 2009 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Test that direct eval calls handle the case where eval has been +// deleted correctly. + +// See http://code.google.com/p/v8/issues/detail?id=221 + +assertThrows('eval(delete eval)'); +