AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix place where linter complains about lonely {

Browse Source 
Fix place where ARM compiler loses track of whether variables were initialized.
Review URL: http://codereview.chromium.org/9244

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
erik.corry@gmail.com 2008-11-03 12:08:01 +00:00
parent 6951059c6a
commit c390485090
3 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/objects-inl.h
View File

@ -185,31 +185,22 @@ bool Object::IsSlicedString() {
StringShape::StringShape(String* str)
: type_(str->map()->instance_type())
#ifdef DEBUG
, valid_(true)
#endif // def DEBUG
{
: type_(str->map()->instance_type()) {
set_valid();
ASSERT((type_ & kIsNotStringMask) == kStringTag);
}
StringShape::StringShape(Map* map)
: type_(map->instance_type())
#ifdef DEBUG
, valid_(true)
#endif // def DEBUG
{
: type_(map->instance_type()) {
set_valid();
ASSERT((type_ & kIsNotStringMask) == kStringTag);
}
StringShape::StringShape(InstanceType t)
: type_(static_cast<uint32_t>(t))
#ifdef DEBUG
, valid_(true)
#endif // def DEBUG
{
: type_(static_cast<uint32_t>(t)) {
set_valid();
ASSERT((type_ & kIsNotStringMask) == kStringTag);
}

3
src/objects.h
View File

@ -3060,7 +3060,10 @@ class StringShape BASE_EMBEDDED {
private:
uint32_t type_;
#ifdef DEBUG
inline void set_valid() { valid_ = true; }
bool valid_;
#else
inline void set_valid() { }
#endif
};

3
src/runtime.cc
View File

@ -2258,7 +2258,8 @@ static inline int Unescape(String* source,
int length,
int* step) {
uint16_t character = source->Get(shape, i);
int32_t hi, lo;
int32_t hi = 0;
int32_t lo = 0;
if (character == '%' &&
i <= length - 6 &&
source->Get(shape, i + 1) == 'u' &&