From c3b2b64be4faf056da81054e918d8e020e58d90a Mon Sep 17 00:00:00 2001 From: Jakob Gruber Date: Tue, 3 Nov 2020 15:06:50 +0100 Subject: [PATCH] [nci] Enable --turbo-nci behind --future to gather perf data .. to be reverted in a day or two. Bug: v8:8888 Change-Id: Iee156da614b50c351ca9a07cc497177c92de865d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512907 Commit-Queue: Jakob Gruber Reviewed-by: Lutz Vahl Cr-Commit-Position: refs/heads/master@{#70949} --- src/flags/flag-definitions.h | 5 +++++ test/cctest/cctest.status | 5 +++-- test/mjsunit/mjsunit.status | 5 +++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index 59a35073e2..b5dcc6d4ad 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -431,6 +431,11 @@ DEFINE_BOOL(future, FUTURE_BOOL, DEFINE_WEAK_IMPLICATION(future, write_protect_code_memory) DEFINE_WEAK_IMPLICATION(future, finalize_streaming_on_background) DEFINE_WEAK_IMPLICATION(future, super_ic) +#ifdef V8_TARGET_ARCH_X64 +// Enabled for a few rolls to gather perf data. See also: +// https://bugs.chromium.org/p/v8/issues/detail?id=11087 +DEFINE_WEAK_IMPLICATION(future, turbo_nci) +#endif // Flags for jitless DEFINE_BOOL(jitless, V8_LITE_BOOL, diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 930e0cc511..96cc2a9c77 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -657,7 +657,8 @@ }], ################################################################################ -['variant == nci or variant == nci_as_midtier', { +['variant == nci or variant == nci_as_midtier or variant == future', { + # TODO(jgruber): Exclude the future variant again. # Optimizes and deopts differently than TurboFan. 'test-api/FastApiCalls': [SKIP], 'test-cpu-profiler/Deopt*': [SKIP], @@ -674,6 +675,6 @@ # NCI code currently does not use the feedback vector's optimized code cache. 'test-compiler/OptimizedCodeSharing1': [SKIP], -}], # variant == nci or variant == nci_as_midtier +}], # variant == nci or variant == nci_as_midtier or variant == future ] diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index fc6b057412..7718ed37f6 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -1303,7 +1303,8 @@ }], # variant == slow_path ################################################################################ -['variant == nci or variant == nci_as_midtier', { +['variant == nci or variant == nci_as_midtier or variant == future', { + # TODO(jgruber): Exclude the future variant again. # Deopts differently than TurboFan. # Deoptimization support is still incomplete in general, since deopts can # only happen when explicitly requested by tests. NCI code objects are then @@ -1432,7 +1433,7 @@ 'compiler/serializer-feedback-propagation-1': [SKIP], 'compiler/serializer-feedback-propagation-2': [SKIP], 'compiler/serializer-transition-propagation': [SKIP], -}], # variant == nci or variant == nci_as_midtier +}], # variant == nci or variant == nci_as_midtier or variant == future ['((arch == mipsel or arch == mips64el or arch == mips or arch == mips64) and not simd_mips) or (arch in [ppc64, s390x])', { # Requires scalar lowering for 64x2 SIMD instructions, which are not