AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix grokdump inspector search for invalid addresses.

Browse Source 
R=ulan@chromium.org
TEST=tools/grokdump.py

Review URL: https://chromiumcodereview.appspot.com/10467003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11701 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
mstarzinger@chromium.org 2012-06-01 12:41:31 +00:00
parent e4b410f88f
commit c5160606f0
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/grokdump.py
View File

@ -1462,6 +1462,9 @@ class InspectionShell(cmd.Cmd):
for slot in xrange(start, for slot in xrange(start,
start + self.reader.PointerSize() * 10, start + self.reader.PointerSize() * 10,
self.reader.PointerSize()): self.reader.PointerSize()):
if not self.reader.IsValidAddress(slot):
print "Address is not contained within the minidump!"
return
maybe_address = self.reader.ReadUIntPtr(slot) maybe_address = self.reader.ReadUIntPtr(slot)
heap_object = self.padawan.SenseObject(maybe_address) heap_object = self.padawan.SenseObject(maybe_address)
print "%s: %s %s" % (self.reader.FormatIntPtr(slot), print "%s: %s %s" % (self.reader.FormatIntPtr(slot),