AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove nosnap configs and references

Browse Source 
Bug: v8:9856
Change-Id: Ia7dd11c3e603b7880a90fb89087d3118409b432f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864650
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64404}
This commit is contained in:
Liviu Rau 2019-10-16 11:49:09 +02:00 committed by Commit Bot
parent 84cd9a82ff
commit c5783e27c7
7 changed files with 1 additions and 139 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
infra/mb/mb_config.pyl
View File

@ -51,8 +51,6 @@
# Linux.
'V8 Linux - builder': 'release_x86_gcmole',
'V8 Linux - debug builder': 'debug_x86',
'V8 Linux - nosnap builder': 'release_x86_no_snap',
'V8 Linux - nosnap debug builder': 'debug_x86_no_snap',
'V8 Linux - shared': 'release_x86_shared_verify_heap',
'V8 Linux - noi18n - debug': 'debug_x86_no_i18n',
'V8 Linux - verify csa': 'release_x86_verify_csa',
@ -72,8 +70,6 @@
# Windows.
'V8 Win32 - builder': 'release_x86_minimal_symbols',
'V8 Win32 - debug builder': 'debug_x86_minimal_symbols',
'V8 Win32 - nosnap - shared':
'release_x86_no_snap_shared_minimal_symbols',
# TODO(machenbach): Remove after switching to x64 on infra side.
'V8 Win64 ASAN': 'release_x64_asan_no_lsan',
'V8 Win64': 'release_x64_minimal_symbols',
@ -156,8 +152,6 @@
'V8 Arm64 - builder': 'release_arm64',
'V8 Linux - arm64 - sim': 'release_simulate_arm64',
'V8 Linux - arm64 - sim - debug': 'debug_simulate_arm64',
'V8 Linux - arm64 - sim - nosnap - debug':
'debug_simulate_arm64_no_snap',
'V8 Linux - arm64 - sim - gc stress': 'debug_simulate_arm64',
# Mips.
'V8 Linux - mipsel - sim - builder': 'release_simulate_mipsel',
@ -202,8 +196,6 @@
'v8_linux_noi18n_compile_dbg': 'debug_x86_no_i18n',
'v8_linux_noi18n_rel_ng': 'release_x86_no_i18n_trybot',
'v8_linux_gc_stress_dbg': 'debug_x86_trybot',
'v8_linux_nosnap_rel': 'release_x86_no_snap_trybot',
'v8_linux_nosnap_dbg': 'debug_x86_no_snap_trybot',
'v8_linux_gcc_compile_rel': 'release_x86_gcc_minimal_symbols',
'v8_linux_gcc_rel': 'release_x86_gcc_minimal_symbols',
'v8_linux_shared_compile_rel': 'release_x86_shared_verify_heap',
@ -237,8 +229,6 @@
'v8_win_dbg': 'debug_x86_trybot',
'v8_win_compile_dbg': 'debug_x86_trybot',
'v8_win_rel_ng': 'release_x86_trybot',
'v8_win_nosnap_shared_rel_ng':
'release_x86_no_snap_shared_minimal_symbols',
'v8_win64_asan_rel_ng': 'release_x64_asan_no_lsan',
'v8_win64_msvc_compile_rel': 'release_x64_msvc',
'v8_win64_dbg': 'debug_x64_minimal_symbols',
@ -348,9 +338,6 @@
'debug_bot', 'simulate_arm64'],
'debug_simulate_arm64_asan_edge': [
'debug_bot', 'simulate_arm64', 'asan', 'lsan', 'edge'],
'debug_simulate_arm64_no_snap': [
'debug', 'simulate_arm64', 'shared', 'goma', 'v8_optimized_debug',
'v8_snapshot_none'],
# Release configs for simulators.
'release_simulate_arm': [
@ -514,10 +501,6 @@
'debug_bot', 'x86', 'minimal_symbols'],
'debug_x86_no_i18n': [
'debug_bot', 'x86', 'v8_no_i18n'],
'debug_x86_no_snap': [
'debug_bot', 'x86', 'v8_snapshot_none'],
'debug_x86_no_snap_trybot': [
'debug_trybot', 'x86', 'v8_snapshot_none'],
'debug_x86_trybot': [
'debug_trybot', 'x86'],
'debug_x86_vtunejit': [
@ -541,13 +524,6 @@
'release_bot', 'x86', 'minimal_symbols'],
'release_x86_no_i18n_trybot': [
'release_trybot', 'x86', 'v8_no_i18n'],
'release_x86_no_snap': [
'release_bot', 'x86', 'v8_snapshot_none'],
'release_x86_no_snap_shared_minimal_symbols': [
'release', 'x86', 'goma', 'minimal_symbols', 'shared',
'v8_snapshot_none'],
'release_x86_no_snap_trybot': [
'release_trybot', 'x86', 'v8_snapshot_none'],
'release_x86_predictable': [
'release_bot', 'x86', 'v8_enable_verify_predictable'],
'release_x86_shared_verify_heap': [
@ -825,10 +801,6 @@
'gn_args': 'v8_use_external_startup_data=false',
},
# TODO(https://crbug.com/v8/8531): Remove this config and all bots, since
# no-snapshot was deprecated and removed.
'v8_snapshot_none': {},
'v8_verify_heap': {
'gn_args': 'v8_enable_verify_heap=true',
},

62
infra/testing/builders.pyl
View File

@ -108,22 +108,6 @@
{'name': 'v8testing', 'variant': 'default', 'shards': 2},
],
},
'v8_linux_nosnap_rel': {
'swarming_dimensions' : {
'os': 'Ubuntu-16.04',
},
'tests': [
{'name': 'v8testing', 'variant': 'default', 'shards': 6},
],
},
'v8_linux_nosnap_dbg': {
'swarming_task_attrs': {
'hard_timeout': 3600,
},
'tests': [
{'name': 'v8testing', 'variant': 'default', 'shards': 9},
],
},
'v8_linux_rel_ng_triggered': {
'swarming_dimensions' : {
'cpu': 'x86-64-avx2',
@ -511,15 +495,6 @@
{'name': 'v8testing', 'shards': 3},
],
},
'v8_win_nosnap_shared_rel_ng_triggered': {
'swarming_dimensions' : {
'cpu': 'x86-64',
'os': 'Windows-7-SP1',
},
'tests': [
{'name': 'v8testing', 'variant': 'default', 'shards': 4},
],
},
'v8_win_rel_ng_triggered': {
'swarming_dimensions' : {
'cpu': 'x86-64',
@ -794,34 +769,6 @@
{'name': 'v8testing', 'variant': 'default'},
],
},
'V8 Linux - nosnap': {
'swarming_dimensions': {
'os': 'Ubuntu-16.04',
},
'swarming_task_attrs': {
'expiration': 14400,
'hard_timeout': 3600,
'priority': 35,
},
'tests': [
{'name': 'mozilla', 'variant': 'default'},
{'name': 'test262', 'variant': 'default', 'shards': 6},
{'name': 'v8testing', 'variant': 'default', 'shards': 3},
],
},
'V8 Linux - nosnap - debug': {
'swarming_dimensions': {
'os': 'Ubuntu-16.04',
},
'swarming_task_attrs': {
'expiration': 14400,
'hard_timeout': 3600,
'priority': 35,
},
'tests': [
{'name': 'v8testing', 'variant': 'default', 'shards': 12},
],
},
'V8 Linux - predictable': {
'swarming_dimensions': {
'os': 'Ubuntu-16.04',
@ -1188,15 +1135,6 @@
{'name': 'v8testing', 'shards': 5},
],
},
'V8 Win32 - nosnap - shared': {
'swarming_dimensions': {
'cpu': 'x86-64',
'os': 'Windows-7-SP1',
},
'tests': [
{'name': 'v8testing', 'variant': 'default', 'shards': 2},
],
},
'V8 Win64': {
'swarming_dimensions': {
'os': 'Windows-10-15063',

31
test/cctest/cctest.status
View File

@ -198,37 +198,6 @@
'test-api/NewStringRangeError': [PASS, NO_VARIANTS],
}], # 'tsan == True'
##############################################################################
['no_snap == True', {
# Slow tests.
'test-api/ExternalWrap': [PASS, SLOW],
'test-api/FastReturnValues*': [PASS, SLOW],
'test-decls/CrossScriptReferences_Simple2': [PASS, SLOW],
# "WithWarmup" means starting from a snapshot, for which nosnap builds lack
# support.
'test-serialize/CustomSnapshotDataBlobWithWarmup': [SKIP],
'test-serialize/SnapshotDataBlobWithWarmup': [SKIP],
# Fails the embedded blob <-> Isolate verification step.
'test-serialize/CustomSnapshotDataBlobWithLocker': [SKIP],
# https://crbug.com/v8/7763
'test-lockers/ExtensionsRegistration': [SKIP],
}], # 'no_snap == True'
##############################################################################
['no_snap == True and system != windows and mode == debug', {
# BUG(v8:9400).
'test-heap/Regress615489': [SKIP],
}], # 'no_snap == True and system != windows and mode == debug'
##############################################################################
# TODO(machenbach): Fix application of '*'. Nosnap windows needs a separate
# section to not overwrite the expectations for TestThatAlwaysFails.
['no_snap == True and system == windows', {
# Windows doesn't support nosnap mode.
'test-serialize/*': [SKIP],
}], # 'no_snap == True and system == windows'
##############################################################################
['is_full_debug', {
# Tests too slow in non-optimized debug mode.

6
test/inspector/inspector.status
View File

@ -76,12 +76,6 @@
'debugger/set-script-source-stack-padding': [SKIP],
}], # 'arch == s390 or arch == s390x'
##############################################################################
['no_snap == True', {
# https://crbug.com/v8/8521
'debugger/pause-on-oom': [SKIP],
}],
##############################################################################
['variant == jitless and not embedded_builtins', {
'*': [SKIP],

2
test/mjsunit/mjsunit.status
View File

@ -196,7 +196,7 @@
'wasm/compare-exchange64-stress': [PASS, SLOW, NO_VARIANTS],
# worker creation/shutdown is very slow in debug mode
'd8/d8-worker-shutdown*': [PASS, ['mode == debug', SLOW], ['no_snap', SKIP]],
'd8/d8-worker-shutdown*': [PASS, ['mode == debug', SLOW]],
# case-insensitive unicode regexp relies on case mapping provided by ICU.
'es6/unicode-regexp-ignore-case': [PASS, ['no_i18n == True', FAIL]],

6
tools/testrunner/base_runner.py
View File

@ -194,9 +194,6 @@ class BuildConfig(object):
self.is_full_debug = build_config['is_full_debug']
self.msan = build_config['is_msan']
self.no_i18n = not build_config['v8_enable_i18n_support']
# TODO(https://crbug.com/v8/8531)
# 'v8_use_snapshot' was removed, 'no_snap' can be removed as well.
self.no_snap = False
self.predictable = build_config['v8_enable_verify_predictable']
self.tsan = build_config['is_tsan']
# TODO(machenbach): We only have ubsan not ubsan_vptr.
@ -230,8 +227,6 @@ class BuildConfig(object):
detected_options.append('msan')
if self.no_i18n:
detected_options.append('no_i18n')
if self.no_snap:
detected_options.append('no_snap')
if self.predictable:
detected_options.append('predictable')
if self.tsan:
@ -698,7 +693,6 @@ class BaseTestRunner(object):
"msan": self.build_config.msan,
"no_harness": options.no_harness,
"no_i18n": self.build_config.no_i18n,
"no_snap": self.build_config.no_snap,
"novfp3": False,
"optimize_for_size": "--optimize-for-size" in options.extra_flags,
"predictable": self.build_config.predictable,

5
tools/testrunner/standard_runner.py
View File

@ -174,11 +174,6 @@ class StandardTestRunner(base_runner.BaseTestRunner):
if self.build_config.asan:
options.extra_flags.append('--invoke-weak-callbacks')
if self.build_config.no_snap:
# Speed up slow nosnap runs. Allocation verification is covered by
# running mksnapshot on other builders.
options.extra_flags.append('--no-turbo-verify-allocation')
if options.novfp3:
options.extra_flags.append('--noenable-vfp3')