AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm][memory64] Update spec tests

Browse Source 
Update the wasm spec tests to include the memory64 proposal. Some tests
are failing currently because of broken spec tests or missing v8
support. This will be addressed in follow-up CLs.

R=ahaas@chromium.org
CC=zhin@chromium.org

Bug: v8:11401
Change-Id: I1a8f75e70f9d0828ad32c960c113f5e4c0d1a44b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679683
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72561}
This commit is contained in:
Clemens Backes 2021-02-08 13:29:52 +01:00 committed by Commit Bot
parent c7ff90d97d
commit c5b9cae05b
6 changed files with 38 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/wasm-js/testcfg.py
View File

@ -39,6 +39,11 @@ proposal_flags = [{
'flags': ['--experimental-wasm-simd',
'--wasm-staging']
},
{
'name': 'memory64',
'flags': ['--experimental-wasm-memory64',
'--wasm-staging']
},
]

2
test/wasm-js/tests.tar.gz.sha1
View File

@ -1 +1 @@
33ac895644065668858271a73d458dd0db8001d5
ef30002bb06bd09b91b62d3fa152d1af94b28eaf

5
test/wasm-spec-tests/testcfg.py
View File

@ -32,6 +32,11 @@ proposal_flags = [{
'flags': ['--experimental-wasm-simd',
'--wasm-staging']
},
{
'name': 'memory64',
'flags': ['--experimental-wasm-memory64',
'--wasm-staging']
},
]
class TestLoader(testsuite.JSTestLoader):

2
test/wasm-spec-tests/tests.tar.gz.sha1
View File

@ -1 +1 @@
69eb576e76237d8dc7fdb26fbbdf6f64bc3af5f6
4db01ba8549a087ae9adaa8540cec2689c7dad64

29
test/wasm-spec-tests/wasm-spec-tests.status
View File

@ -18,8 +18,9 @@
'data': [FAIL],
# TODO(wasm): Roll newest tests into "js-types" repository.
'proposals/js-types/imports': [FAIL],
'proposals/js-types/elem': [FAIL],
'proposals/js-types/globals': [FAIL],
'proposals/js-types/imports': [FAIL],
'proposals/js-types/linking': [FAIL],
# TODO(wasm): Roll newest tests into "tail-call" repository.
@ -36,11 +37,31 @@
# This test requires the reftypes flag to be disabled.
'proposals/bulk-memory-operations/imports': [FAIL],
# TODO(v8:11331): Remove once spec tests are updated with v128.any_true.
'proposals/simd/simd_boolean': [FAIL],
'proposals/simd/simd_lane': [FAIL],
# TODO(v8:11331): Remove once nosse is fixed.
'proposals/simd/simd_boolean': [FAIL, PASS],
'proposals/simd/simd_load16_lane': [FAIL, PASS],
'proposals/simd/simd_load32_lane': [FAIL, PASS],
'proposals/simd/simd_load64_lane': [FAIL, PASS],
'proposals/simd/simd_load8_lane': [FAIL, PASS],
# TODO(v8:11401): Fix memory64 spec tests / the v8 implementation (whatever
# is broken).
'proposals/memory64/address64': [FAIL],
'proposals/memory64/data': [FAIL],
'proposals/memory64/elem': [FAIL],
'proposals/memory64/float_memory64': [FAIL],
'proposals/memory64/imports': [FAIL],
'proposals/memory64/load64': [FAIL],
'proposals/memory64/memory64': [FAIL],
'proposals/memory64/memory_grow64': [FAIL],
'proposals/memory64/memory_trap64': [FAIL],
}], # ALWAYS
['arch == arm', {
# TODO(zhin): Fails on arm, hitting UNIMPLEMENTED in instruction selector.
'proposals/simd/simd_i64x2_cmp': [FAIL],
}], # arch == arm
['arch == arm and not simulator_run', {
# See https://crbug.com/v8/10938 denormals not handled correctly on ARM.
'proposals/simd/simd_f32x4': [PASS, FAIL],

2
tools/wasm/update-wasm-spec-tests.sh
View File

@ -71,7 +71,7 @@ log_and_run cp -r ${TMP_DIR}/spec/test/js-api/* ${JS_API_TEST_DIR}/tests
# Generate the proposal tests.
###############################################################################
repos='bulk-memory-operations reference-types js-types tail-call simd'
repos='bulk-memory-operations reference-types js-types tail-call simd memory64'
for repo in ${repos}; do
echo "Process ${repo}"