AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove a few unnecssary scopers from unit tests.

Browse Source 
TestWithIsolate and TestWithContext already instantiate the scopers.

BUG=none

Review-Url: https://codereview.chromium.org/2690303009
Cr-Commit-Position: refs/heads/master@{#43268}
This commit is contained in:
dcheng 2017-02-17 01:51:07 -08:00 committed by Commit bot
parent 4a7436101d
commit c5ccae970d
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unittests/api/isolate-unittest.cc
View File

@ -44,8 +44,6 @@ class MemoryPressureTask : public v8::Task {
// Check that triggering a memory pressure notification on the isolate thread
// doesn't request a GC interrupt.
TEST_F(IsolateTest, MemoryPressureNotificationForeground) {
Isolate::Scope isolate_scope(isolate());
internal::Isolate* i_isolate =
reinterpret_cast<internal::Isolate*>(isolate());
@ -57,8 +55,6 @@ TEST_F(IsolateTest, MemoryPressureNotificationForeground) {
// Check that triggering a memory pressure notification on an background thread
// requests a GC interrupt.
TEST_F(IsolateTest, MemoryPressureNotificationBackground) {
Isolate::Scope isolate_scope(isolate());
internal::Isolate* i_isolate =
reinterpret_cast<internal::Isolate*>(isolate());

2
test/unittests/api/v8-object-unittest.cc
View File

@ -15,8 +15,6 @@ void accessor_name_getter_callback(Local<Name>,
const PropertyCallbackInfo<Value>&) {}
TEST_F(ObjectTest, SetAccessorWhenUnconfigurablePropAlreadyDefined) {
Context::Scope context_scope(context());
TryCatch try_catch(isolate());
Local<Object> global = context()->Global();