AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[gc][static-roots] Fix more accesses to r/o markbits

Browse Source 
Two overlooked ones in marking barrier and cppgc.

Fixes blink tests.

Bug: v8:13717
Change-Id: I2c8beb0db1bcc38ae37a058f02da448dae9c7207
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224152
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Auto-Submit: Olivier Flückiger <olivf@chromium.org>
Commit-Queue: Olivier Flückiger <olivf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85692}
This commit is contained in:
Olivier Flückiger 2023-02-06 17:51:36 +01:00 committed by V8 LUCI CQ
parent 31da231deb
commit c5ff664bc8
3 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/heap/cppgc-js/unified-heap-marking-state-inl.h
View File

@ -46,6 +46,7 @@ void UnifiedHeapMarkingState::MarkAndPush(
return; return;
} }
HeapObject heap_object = HeapObject::cast(object); HeapObject heap_object = HeapObject::cast(object);
if (heap_object.InReadOnlySpace()) return;
if (marking_state_->WhiteToGrey(heap_object)) { if (marking_state_->WhiteToGrey(heap_object)) {
local_marking_worklist_->Push(heap_object); local_marking_worklist_->Push(heap_object);
} }

1
src/heap/marking-barrier-inl.h
View File

@ -72,6 +72,7 @@ void MarkingBarrier::MarkValueShared(HeapObject value) {
} }
void MarkingBarrier::MarkValueLocal(HeapObject value) { void MarkingBarrier::MarkValueLocal(HeapObject value) {
DCHECK(!value.InReadOnlySpace());
if (is_minor()) { if (is_minor()) {
// We do not need to insert into RememberedSet<OLD_TO_NEW> here because the // We do not need to insert into RememberedSet<OLD_TO_NEW> here because the
// C++ marking barrier already does this for us. // C++ marking barrier already does this for us.

2
src/heap/marking-barrier.cc
View File

@ -60,7 +60,7 @@ void MarkingBarrier::WriteWithoutHost(HeapObject value) {
return; return;
} }
} }
if (value.InReadOnlySpace()) return;
MarkValueLocal(value); MarkValueLocal(value);
} }