AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Fix external bytes accounting when promoting large objects

Browse Source 
Unlike other spaces we didn't update external bytes counters when
adding or removing pages from large spaces.

Bug: chromium:1329766
Change-Id: I5fbc8703964f9e4e846d986c32c5d57ed4f0c0c5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3681118
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80877}
This commit is contained in:
Dominik Inführ 2022-05-31 21:47:26 +02:00 committed by V8 LUCI CQ
parent 6f1e3e6f4a
commit c6527293a5
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/heap/large-spaces.cc
View File

@ -267,6 +267,10 @@ void LargeObjectSpace::AddPage(LargePage* page, size_t object_size) {
page->set_owner(this); page->set_owner(this);
page->SetOldGenerationPageFlags(!is_off_thread() && page->SetOldGenerationPageFlags(!is_off_thread() &&
heap()->incremental_marking()->IsMarking()); heap()->incremental_marking()->IsMarking());
for (size_t i = 0; i < ExternalBackingStoreType::kNumTypes; i++) {
ExternalBackingStoreType t = static_cast<ExternalBackingStoreType>(i);
IncrementExternalBackingStoreBytes(t, page->ExternalBackingStoreBytes(t));
}
} }
void LargeObjectSpace::RemovePage(LargePage* page) { void LargeObjectSpace::RemovePage(LargePage* page) {
size_ -= static_cast<int>(page->size()); size_ -= static_cast<int>(page->size());
@ -274,6 +278,10 @@ void LargeObjectSpace::RemovePage(LargePage* page) {
page_count_--; page_count_--;
memory_chunk_list_.Remove(page); memory_chunk_list_.Remove(page);
page->set_owner(nullptr); page->set_owner(nullptr);
for (size_t i = 0; i < ExternalBackingStoreType::kNumTypes; i++) {
ExternalBackingStoreType t = static_cast<ExternalBackingStoreType>(i);
DecrementExternalBackingStoreBytes(t, page->ExternalBackingStoreBytes(t));
}
} }
namespace { namespace {

16
test/mjsunit/large-external-string.js Normal file
View File

@ -0,0 +1,16 @@
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --expose-gc --expose-externalize-string --verify-heap
const LENGTH = 100 * 1000;
const data = new Array();
for (var i = 0; i < LENGTH; ++i) {
data.push('do ');
}
const largeText = data.join();
externalizeString(largeText);
gc();