AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Update unicode-regexp-ignore-case-noi18n expectations

Browse Source 
There appear to be one or several bugs in noi18n mode such that
expectations in this test are no longer met. This CL updates
expectations to the current behavior and re-enables the test so we at
least preserve coverage in the other cases.

The behavior in question should be investigated in the future
(low priority).

Bug: v8:10120
Change-Id: Ib7c9a18133a386e6e39ee54d68ce4106d9b28c84
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081815
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66524}
This commit is contained in:
Jakob Gruber 2020-03-02 12:03:35 +01:00 committed by Commit Bot
parent 5f27695a77
commit c6c9d4bf1b
3 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/cctest/cctest.status
View File

@ -140,8 +140,6 @@
##############################################################################
['arch == arm64', {
'test-api/Bug618': [PASS],
# BUG(v8:3385).
'test-serialize/StartupSerializerOnceRunScript': [PASS, FAIL],
'test-serialize/StartupSerializerTwiceRunScript': [PASS, FAIL],

23
test/mjsunit/es6/unicode-regexp-ignore-case-noi18n.js
View File

@ -29,11 +29,24 @@ assertFalse(/\u{10400}/ui.test("\u{10428}"));
assertFalse(/\ud801\udc00/ui.test("\u{10428}"));
assertFalse(/[\u{10428}]/ui.test("\u{10400}"));
assertFalse(/[\ud801\udc28]/ui.test("\u{10400}"));
assertEquals(["\uff21\u{10400}"],
/[\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc"));
assertEquals(["abc"], /[^\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc\uff23"));
assertEquals(["\uff53\u24bb"],
/[\u24d5-\uff33]+/ui.exec("\uff54\uff53\u24bb\u24ba"));
// TODO(v8:10120): Investigate why these don't behave as expected.
{
// assertEquals(["\uff21\u{10400}"],
// /[\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc"));
assertEquals(["\u{10400}"],
/[\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc"));
}
{
// assertEquals(["abc"], /[^\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc\uff23"));
assertEquals(["\u{ff21}"], /[^\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc\uff23"));
}
{
// assertEquals(["\uff53\u24bb"],
// /[\u24d5-\uff33]+/ui.exec("\uff54\uff53\u24bb\u24ba"));
assertEquals(null,
/[\u24d5-\uff33]+/ui.exec("\uff54\uff53\u24bb\u24ba"));
}
// Full mappings are ignored.
assertFalse(/\u00df/ui.test("SS"));

11
test/mjsunit/mjsunit.status
View File

@ -62,12 +62,6 @@
# Issue 9380: Memory leaks of shared WebAssembly.Memory objects
'wasm/shared-memory-worker-gc': [SKIP],
# crbug.com/v8/10120: This test is meant to pass (only) in no_i18n builds,
# but currently doesn't:
'es6/unicode-regexp-ignore-case-noi18n': [FAIL],
# Once the bug is fixed, the expectations should be:
# 'es6/unicode-regexp-ignore-case-noi18n': [PASS, ['no_i18n == False', FAIL]],
# BUG(v8:10197)
'regress/regress-748069': [SKIP],
@ -160,6 +154,10 @@
# OOM with too many isolates/memory objects (https://crbug.com/1010272)
# Predictable tests fail due to race between postMessage and GrowMemory
'regress/wasm/regress-1010272': [PASS, NO_VARIANTS, ['system == android', SKIP], ['predictable', SKIP]],
# Only makes sense in the no_i18n variant.
'es6/unicode-regexp-ignore-case-noi18n':
[['no_i18n == True', PASS], ['no_i18n == False', FAIL]],
}], # ALWAYS
##############################################################################
@ -391,7 +389,6 @@
'regexp-modifiers-autogenerated-i18n': [FAIL],
# desugaring regexp property class relies on ICU.
'harmony/regexp-property-*': [FAIL],
'harmony/regexp-property-invalid': [PASS],
'regress/regress-793588': [FAIL],
# noi18n build cannot parse characters in supplementary plane.