AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

X87: Support for super assignments in for..in.

Browse Source 
port r24560.

original commit message:
  Support for super assignments in for..in.

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/653823002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24572 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
weiliang.lin@intel.com 2014-10-14 02:55:29 +00:00
parent d9cda16c6a
commit c704369eab
1 changed files with 37 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
src/x87/full-codegen-x87.cc
View File

@ -2417,16 +2417,8 @@ void FullCodeGenerator::EmitBinaryOp(BinaryOperation* expr,
void FullCodeGenerator::EmitAssignment(Expression* expr) {
DCHECK(expr->IsValidReferenceExpression());
// Left-hand side can only be a property, a global or a (parameter or local)
// slot.
enum LhsKind { VARIABLE, NAMED_PROPERTY, KEYED_PROPERTY };
LhsKind assign_type = VARIABLE;
Property* prop = expr->AsProperty();
if (prop != NULL) {
assign_type = (prop->key()->IsPropertyName())
? NAMED_PROPERTY
: KEYED_PROPERTY;
}
LhsKind assign_type = GetAssignType(prop);
switch (assign_type) {
case VARIABLE: {
@ -2445,6 +2437,42 @@ void FullCodeGenerator::EmitAssignment(Expression* expr) {
CallStoreIC();
break;
}
case NAMED_SUPER_PROPERTY: {
__ push(eax);
VisitForStackValue(prop->obj()->AsSuperReference()->this_var());
EmitLoadHomeObject(prop->obj()->AsSuperReference());
// stack: value, this; eax: home_object
Register scratch = ecx;
Register scratch2 = edx;
__ mov(scratch, result_register()); // home_object
__ mov(eax, MemOperand(esp, kPointerSize)); // value
__ mov(scratch2, MemOperand(esp, 0)); // this
__ mov(MemOperand(esp, kPointerSize), scratch2); // this
__ mov(MemOperand(esp, 0), scratch); // home_object
// stack: this, home_object. eax: value
EmitNamedSuperPropertyStore(prop);
break;
}
case KEYED_SUPER_PROPERTY: {
__ push(eax);
VisitForStackValue(prop->obj()->AsSuperReference()->this_var());
EmitLoadHomeObject(prop->obj()->AsSuperReference());
__ push(result_register());
VisitForAccumulatorValue(prop->key());
Register scratch = ecx;
Register scratch2 = edx;
__ mov(scratch2, MemOperand(esp, 2 * kPointerSize)); // value
// stack: value, this, home_object; eax: key, edx: value
__ mov(scratch, MemOperand(esp, kPointerSize)); // this
__ mov(MemOperand(esp, 2 * kPointerSize), scratch);
__ mov(scratch, MemOperand(esp, 0)); // home_object
__ mov(MemOperand(esp, kPointerSize), scratch);
__ mov(MemOperand(esp, 0), eax);
__ mov(eax, scratch2);
// stack: this, home_object, key; eax: value.
EmitKeyedSuperPropertyStore(prop);
break;
}
case KEYED_PROPERTY: {
__ push(eax); // Preserve value.
VisitForStackValue(prop->obj());