AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[arm64] Make sure that memory allocated for assembler tests is executable.

Browse Source 
Fix some crashes when tests are run on real hardware.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1748603002

Cr-Commit-Position: refs/heads/master@{#34355}
This commit is contained in:
baptiste.afsa 2016-02-29 02:51:28 -08:00 committed by Commit bot
parent 27a75f7ad0
commit c7339e6ee4
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/cctest/test-assembler-arm64.cc
View File

@ -37,6 +37,7 @@
#include "src/arm64/disasm-arm64.h"
#include "src/arm64/simulator-arm64.h"
#include "src/arm64/utils-arm64.h"
#include "src/base/platform/platform.h"
#include "src/base/utils/random-number-generator.h"
#include "src/macro-assembler.h"
#include "test/cctest/cctest.h"
@ -173,8 +174,10 @@ static void InitializeVM() {
Isolate* isolate = CcTest::i_isolate(); \
HandleScope scope(isolate); \
CHECK(isolate != NULL); \
byte* buf = new byte[buf_size]; \
MacroAssembler masm(isolate, buf, buf_size, \
size_t actual_size; \
byte* buf = static_cast<byte*>( \
v8::base::OS::Allocate(buf_size, &actual_size, true)); \
MacroAssembler masm(isolate, buf, actual_size, \
v8::internal::CodeObjectRequired::kYes); \
RegisterDump core;
@ -208,7 +211,7 @@ static void InitializeVM() {
__ GetCode(NULL);
#define TEARDOWN() \
delete[] buf;
v8::base::OS::Free(buf, actual_size);
#endif // ifdef USE_SIMULATOR.