AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Clarify a comment.

Browse Source 
R=mvstanton@chromium.org

Change-Id: I4e717b0d608837cdde2bea2ebbcf83a2a5d6b749
Reviewed-on: https://chromium-review.googlesource.com/1165144
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54945}
This commit is contained in:
Georg Neis 2018-08-07 13:34:43 +02:00 committed by Commit Bot
parent 7f99d292e2
commit c790b2790f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/js-call-reducer.cc
View File

@ -1532,7 +1532,6 @@ Reduction JSCallReducer::ReduceArrayMap(Node* node,
simplified()->LoadField(AccessBuilder::ForJSArrayLength(kind)), receiver,
effect, control);
// This array should be HOLEY_SMI_ELEMENTS because of the non-zero length.
// Even though {JSCreateArray} is not marked as {kNoThrow}, we can elide the
// exceptional projections because it cannot throw with the given parameters.
Node* a = control = effect = graph()->NewNode(
@ -1634,6 +1633,9 @@ Reduction JSCallReducer::ReduceArrayMap(Node* node,
&check_fail, &control);
}
// The array {a} should be HOLEY_SMI_ELEMENTS because we'd only come into this
// loop if the input array length is non-zero, and "new Array({x > 0})" always
// produces a HOLEY array.
Handle<Map> double_map(Map::cast(native_context()->get(
Context::ArrayMapIndex(HOLEY_DOUBLE_ELEMENTS))),
isolate());