From c84e19eae0e9e040259ebb88b5121ecfbea05fbd Mon Sep 17 00:00:00 2001 From: Ng Zhi An Date: Mon, 1 Jul 2019 13:23:16 -0700 Subject: [PATCH] [wasm simd] Run no lowering tests for I64x2 and F64x2 Lowering does not work correctly for I64x2 and F64x2. Those tests are guarded with X64, so it is fine, but if we remove the guard next time, the failing tests will be confusing. Bug: v8:8460 Change-Id: I98da0a2de1fefa8f46bdc5c0a1407973e3ed2b81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683928 Auto-Submit: Zhi An Ng Reviewed-by: Deepti Gandluri Commit-Queue: Zhi An Ng Cr-Commit-Position: refs/heads/master@{#62494} --- test/cctest/wasm/test-run-wasm-simd.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/cctest/wasm/test-run-wasm-simd.cc b/test/cctest/wasm/test-run-wasm-simd.cc index b1fc9c260f..e2e8963f65 100644 --- a/test/cctest/wasm/test-run-wasm-simd.cc +++ b/test/cctest/wasm/test-run-wasm-simd.cc @@ -377,7 +377,7 @@ bool IsExtreme(float x) { } #if V8_TARGET_ARCH_X64 -WASM_SIMD_TEST(F64x2Splat) { +WASM_SIMD_TEST_NO_LOWERING(F64x2Splat) { WasmRunner r(execution_tier, lower_simd); // Set up a global to hold output vector. double* g = r.builder().AddGlobal(kWasmS128); @@ -712,7 +712,7 @@ WASM_SIMD_TEST(F32x4Le) { } #if V8_TARGET_ARCH_X64 -WASM_SIMD_TEST(I64x2Splat) { +WASM_SIMD_TEST_NO_LOWERING(I64x2Splat) { WasmRunner r(execution_tier, lower_simd); // Set up a global to hold output vector. int64_t* g = r.builder().AddGlobal(kWasmS128);