[compiler] Disable some tests on NCI

Split globals.js into two parts, one being skipped on NCI due to
assertions about optimization status.

Change-Id: Ifc572526d9c6aed369802a65d12c4456cde65ce0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539909
Auto-Submit: Georg Neis <neis@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71199}
This commit is contained in:
Georg Neis 2020-11-16 10:51:46 +01:00 committed by Commit Bot
parent 3728728d88
commit c85ab364d6
3 changed files with 82 additions and 80 deletions

View File

@ -1,86 +1,9 @@
// Copyright 2009 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --opt --no-always-opt
// Test references and assignments to global variables.
var g = 0;
// Test compilation of a global variable store.
assertEquals(1, eval('g = 1'));
// Test that the store worked.
assertEquals(1, g);
// Test that patching the IC in the compiled code works.
assertEquals(1, eval('g = 1'));
assertEquals(1, g);
assertEquals(1, eval('g = 1'));
assertEquals(1, g);
// Test a second store.
assertEquals("2", eval('g = "2"'));
assertEquals("2", g);
// Test a load.
assertEquals("2", eval('g'));
// Test that patching the IC in the compiled code works.
assertEquals("2", eval('g'));
assertEquals("2", eval('g'));
// Test a second load.
g = 3;
assertEquals(3, eval('g'));
// Test postfix count operation
var t;
t = g++;
assertEquals(3, t);
assertEquals(4, g);
code = "g--; 1";
assertEquals(1, eval(code));
assertEquals(3, g);
// Test simple assignment to non-deletable and deletable globals.
var glo1 = 0;
function f1(x) { glo1 = x; }
f1(42);
assertEquals(glo1, 42);
glo2 = 0;
function f2(x) { glo2 = x; }
f2(42);
assertEquals(42, glo2);
//////////////////////////////////////////////////////////////////////////////
// Test Constant cell value going from writable to read-only.
{

77
test/mjsunit/globals.js Normal file
View File

@ -0,0 +1,77 @@
// Copyright 2009 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Test references and assignments to global variables.
var g = 0;
// Test compilation of a global variable store.
assertEquals(1, eval('g = 1'));
// Test that the store worked.
assertEquals(1, g);
// Test that patching the IC in the compiled code works.
assertEquals(1, eval('g = 1'));
assertEquals(1, g);
assertEquals(1, eval('g = 1'));
assertEquals(1, g);
// Test a second store.
assertEquals("2", eval('g = "2"'));
assertEquals("2", g);
// Test a load.
assertEquals("2", eval('g'));
// Test that patching the IC in the compiled code works.
assertEquals("2", eval('g'));
assertEquals("2", eval('g'));
// Test a second load.
g = 3;
assertEquals(3, eval('g'));
// Test postfix count operation
var t;
t = g++;
assertEquals(3, t);
assertEquals(4, g);
code = "g--; 1";
assertEquals(1, eval(code));
assertEquals(3, g);
// Test simple assignment to non-deletable and deletable globals.
var glo1 = 0;
function f1(x) { glo1 = x; }
f1(42);
assertEquals(glo1, 42);
glo2 = 0;
function f2(x) { glo2 = x; }
f2(42);
assertEquals(42, glo2);

View File

@ -1353,6 +1353,8 @@
'compiler/dataview-set': [SKIP],
'compiler/deopt-inlined-from-call': [SKIP],
'compiler/field-representation-tracking': [SKIP],
'compiler/globals-change-writable': [SKIP],
'compiler/globals-freeze-*': [SKIP],
'compiler/manual-concurrent-recompile': [SKIP],
'compiler/native-context-specialization-hole-check': [SKIP],
'compiler/number-divide': [SKIP],