AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[test] Fix a crash in fast API interface types test

Browse Source 
This CL hardens the test facility in d8 for interface types for
the fast C API.

Bug: chromium:1201011
Change-Id: Ibfe1bb242f86b4a5edd0d195e049852430f8a2fe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2843344
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74079}
This commit is contained in:
Maya Lekova 2021-04-21 09:31:42 +02:00 committed by Commit Bot
parent 2cd77745d9
commit c8e8f482f3
3 changed files with 34 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/d8/d8-test.cc
View File

@ -122,6 +122,9 @@ class FastCApiObject {
return false;
}
if (!arg->IsObject()) {
return false;
}
Object* object = Object::Cast(arg);
if (!IsValidApiObject(object)) return false;
@ -150,6 +153,7 @@ class FastCApiObject {
"is_valid_api_object should be called with 2 arguments");
return;
}
if (args[1]->IsObject()) {
Object* object = Object::Cast(*args[1]);
if (!IsValidApiObject(object)) {
result = false;
@ -158,6 +162,7 @@ class FastCApiObject {
->GetTestApiObjectCtor()
->IsLeafTemplateForApiObject(object);
}
}
args.GetReturnValue().Set(Boolean::New(isolate, result));
}

11
test/mjsunit/compiler/regress-crbug-1201011.js Normal file
View File

@ -0,0 +1,11 @@
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --turbo-fast-api-calls
const fast_c_api = new d8.test.FastCAPI();
function foo(obj) {
return fast_c_api.is_fast_c_api_object(false, obj);
}
foo();

11
test/mjsunit/compiler/regress-crbug-1201082.js Normal file
View File

@ -0,0 +1,11 @@
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --turbo-fast-api-calls
const fast_c_api = new d8.test.FastCAPI();
function foo(obj) {
return fast_c_api.is_fast_c_api_object(false, obj);
}
foo(1);