AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Mark interpreter methods in subclasses with override.

Browse Source 
Fixing clang-tidy warning.

Bug: v8:8015
Change-Id: Ibc3dedb0bce78ddce4004ee386757ce504bb073a
Reviewed-on: https://chromium-review.googlesource.com/1226792
Commit-Queue: Florian Sattler <sattlerf@google.com>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55931}
This commit is contained in:
Florian Sattler 2018-09-17 09:09:56 +02:00 committed by Commit Bot
parent df5263b0c0
commit c8fd2870dd
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/interpreter/bytecode-generator.cc
View File

@ -402,7 +402,7 @@ class BytecodeGenerator::ControlScopeForIteration final
loop_builder_(loop_builder) { loop_builder_(loop_builder) {
generator->loop_depth_++; generator->loop_depth_++;
} }
~ControlScopeForIteration() { generator()->loop_depth_--; } ~ControlScopeForIteration() override { generator()->loop_depth_--; }
protected: protected:
bool Execute(Command command, Statement* statement, bool Execute(Command command, Statement* statement,

2
src/interpreter/bytecode-register-optimizer.h
View File

@ -39,7 +39,7 @@ class V8_EXPORT_PRIVATE BytecodeRegisterOptimizer final
BytecodeRegisterAllocator* register_allocator, BytecodeRegisterAllocator* register_allocator,
int fixed_registers_count, int parameter_count, int fixed_registers_count, int parameter_count,
BytecodeWriter* bytecode_writer); BytecodeWriter* bytecode_writer);
virtual ~BytecodeRegisterOptimizer() = default; ~BytecodeRegisterOptimizer() override = default;
// Perform explicit register transfer operations. // Perform explicit register transfer operations.
void DoLdar(Register input) { void DoLdar(Register input) {

12
src/interpreter/control-flow-builders.h
View File

@ -41,7 +41,7 @@ class V8_EXPORT_PRIVATE BreakableControlFlowBuilder
break_labels_(builder->zone()), break_labels_(builder->zone()),
node_(node), node_(node),
block_coverage_builder_(block_coverage_builder) {} block_coverage_builder_(block_coverage_builder) {}
virtual ~BreakableControlFlowBuilder(); ~BreakableControlFlowBuilder() override;
// This method is called when visiting break statements in the AST. // This method is called when visiting break statements in the AST.
// Inserts a jump to an unbound label that is patched when the corresponding // Inserts a jump to an unbound label that is patched when the corresponding
@ -113,7 +113,7 @@ class V8_EXPORT_PRIVATE LoopBuilder final : public BreakableControlFlowBuilder {
node, SourceRangeKind::kBody); node, SourceRangeKind::kBody);
} }
} }
~LoopBuilder(); ~LoopBuilder() override;
void LoopHeader(); void LoopHeader();
void LoopBody(); void LoopBody();
@ -149,7 +149,7 @@ class V8_EXPORT_PRIVATE SwitchBuilder final
case_sites_(builder->zone()) { case_sites_(builder->zone()) {
case_sites_.resize(number_of_cases); case_sites_.resize(number_of_cases);
} }
~SwitchBuilder(); ~SwitchBuilder() override;
// This method should be called by the SwitchBuilder owner when the case // This method should be called by the SwitchBuilder owner when the case
// statement with |index| is emitted to update the case jump site. // statement with |index| is emitted to update the case jump site.
@ -186,7 +186,7 @@ class V8_EXPORT_PRIVATE TryCatchBuilder final : public ControlFlowBuilder {
block_coverage_builder_(block_coverage_builder), block_coverage_builder_(block_coverage_builder),
statement_(statement) {} statement_(statement) {}
~TryCatchBuilder(); ~TryCatchBuilder() override;
void BeginTry(Register context); void BeginTry(Register context);
void EndTry(); void EndTry();
@ -217,7 +217,7 @@ class V8_EXPORT_PRIVATE TryFinallyBuilder final : public ControlFlowBuilder {
block_coverage_builder_(block_coverage_builder), block_coverage_builder_(block_coverage_builder),
statement_(statement) {} statement_(statement) {}
~TryFinallyBuilder(); ~TryFinallyBuilder() override;
void BeginTry(Register context); void BeginTry(Register context);
void LeaveTry(); void LeaveTry();
@ -260,7 +260,7 @@ class V8_EXPORT_PRIVATE ConditionalControlFlowBuilder final
node, SourceRangeKind::kElse); node, SourceRangeKind::kElse);
} }
} }
~ConditionalControlFlowBuilder(); ~ConditionalControlFlowBuilder() override;
BytecodeLabels* then_labels() { return &then_labels_; } BytecodeLabels* then_labels() { return &then_labels_; }
BytecodeLabels* else_labels() { return &else_labels_; } BytecodeLabels* else_labels() { return &else_labels_; }