From c977b08db18f5930ee55821d23851b412073b911 Mon Sep 17 00:00:00 2001 From: Sigurd Schneider Date: Wed, 20 Feb 2019 14:00:50 +0000 Subject: [PATCH] Revert "[torque] Temporarily remove torque format check to pass presubmit" This reverts commit 5a161ce35c4b1b0cfd5ee63bdd3009c02d5d18f9. Reason for revert: Fix is available Original change's description: > [torque] Temporarily remove torque format check to pass presubmit > > .. also from v8_presubmit.py > > Revert this once the bug is fixed. > > TBR=machenbach@chromium.org > > Change-Id: I82f443e1d6bea4c4c43d50631f559b3aa25f8410 > Bug: v8:8873 > Notry: true > Notreechecks: true > Reviewed-on: https://chromium-review.googlesource.com/c/1478690 > Reviewed-by: Sigurd Schneider > Reviewed-by: Michael Achenbach > Commit-Queue: Sigurd Schneider > Cr-Commit-Position: refs/heads/master@{#59722} TBR=machenbach@chromium.org,sigurds@chromium.org Change-Id: I9b8f01e9563cc53d34c0835872fb6fe8b5ddb240 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8873 Reviewed-on: https://chromium-review.googlesource.com/c/1478195 Reviewed-by: Sigurd Schneider Commit-Queue: Sigurd Schneider Cr-Commit-Position: refs/heads/master@{#59732} --- tools/v8_presubmit.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/v8_presubmit.py b/tools/v8_presubmit.py index f629ac0616..1fe3221118 100755 --- a/tools/v8_presubmit.py +++ b/tools/v8_presubmit.py @@ -688,8 +688,9 @@ def Main(): print("Running C++ lint check...") success &= CppLintProcessor(use_cache=use_linter_cache).RunOnPath(workspace) - print("Running Torque formatting check... (ignoring results)") - TorqueLintProcessor(use_cache=use_linter_cache).RunOnPath(workspace) + print("Running Torque formatting check...") + success &= TorqueLintProcessor(use_cache=use_linter_cache).RunOnPath( + workspace) print("Running copyright header, trailing whitespaces and " \ "two empty lines between declarations check...") success &= SourceProcessor().RunOnPath(workspace)