AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Nerf regression test size

Browse Source 
This verifies that asm.js over the internal parameter count limit
does not crash. The internal limit is 1000 parameters, and the test
was using >3000 parameters. Reduce this down to 1005, and also
introduce a test which does not dynamically construct the string
and eval it, because the construction of this string takes time.
Mark the old test as slow in debug mode.

R=machenbach@chromium.org
BUG=v8:8165

Change-Id: Ib6ef5e1e58d3f37a71720fb59afa19464e7f2ff7
Reviewed-on: https://chromium-review.googlesource.com/1224057
Commit-Queue: Ben Titzer <titzer@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55860}
This commit is contained in:
Ben L. Titzer 2018-09-13 14:03:35 +02:00 committed by Commit Bot
parent 34c5458c37
commit ca894e093a
3 changed files with 1213 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/mjsunit/mjsunit.status
View File

@ -168,6 +168,7 @@
'regress/regress-605470': [PASS, SLOW],
'regress/regress-655573': [PASS, SLOW],
'regress/regress-1200351': [PASS, SLOW],
'regress/wasm/regress-810973': [PASS, SLOW],
'string-replace-gc': [PASS, SLOW],
'wasm/asm-wasm-f32': [PASS, SLOW],
'wasm/asm-wasm-f64': [PASS, SLOW],
@ -660,7 +661,6 @@
# Slow tests.
'es6/typedarray-of': [PASS, SLOW],
'regress/regress-crbug-854299': [PASS, SLOW],
'regress/wasm/regress-810973': [PASS, SLOW],
}], # 'isolates'
##############################################################################

5
test/mjsunit/regress/wasm/regress-810973.js
View File

@ -12,7 +12,7 @@ function MjsUnitAssertionError() {
};
let __v_692 = `(function module() { "use asm";function foo(`;
const __v_693 =
3695;
1005;
for (let __v_695 = 0; __v_695 < __v_693; ++__v_695) {
__v_692 += `arg${__v_695},`;
}
@ -28,5 +28,6 @@ for (let __v_697 = 0; __v_697 < __v_693; ++__v_697) {
}
__v_692 += "1.0)|0;}";
__v_692 += "return bar})()()";
__v_692 += "return bar})()()";
const __v_694 = eval(__v_692);

1209
test/mjsunit/regress/wasm/regress-810973b.js Normal file
View File

File diff suppressed because it is too large Load Diff