AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[bash-completion] Support macOS + jsvu binaries

Browse Source 
macOS’s `readlink` doesn’t support the `-f` flag. By using `realpath`
we get the same functionality with added support for macOS.

Finally, this patch adds `v8` and `v8-debug` to the completion
command. These are the binary names used by jsvu [1].

[1]: https://github.com/GoogleChromeLabs/jsvu

Bug: v8:11567
Change-Id: I1ec47752e50bce4bfb97a7ce23571d0a6e55dbc1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762147
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73438}
This commit is contained in:
Mathias Bynens 2021-03-16 14:19:37 +01:00 committed by Commit Bot
parent 6ff9f24be7
commit cab07dfbca
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/bash-completion.sh
View File

@ -32,7 +32,7 @@
# Flag completion rule for bash.
# To load in your shell, "source path/to/this/file".
v8_source=$(readlink -f $(dirname $BASH_SOURCE)/..)
v8_source="$(realpath "$(dirname "$BASH_SOURCE")"/..)"
_get_v8_flags() {
# The first `sed` command joins lines when a line ends with '('.
@ -48,16 +48,15 @@ _get_v8_flags() {
grep "^ V(harmony_" "$flags_file" \
| sed -e 's/^ V/DEFINE-BOOL/' \
| sed -e 's/_/-/g'; \
grep "^ V(" $v8_source/src/wasm/wasm-feature-flags.h \
grep "^ V(" "$v8_source/src/wasm/wasm-feature-flags.h" \
| sed -e 's/^ V(/DEFINE-BOOL(experimental-wasm-/' \
| sed -e 's/_/-/g')
sed -ne 's/^DEFINE-[^(]*(\([^,]*\).*/--\1/p' <<< $defines
sed -ne 's/^DEFINE-BOOL(\([^,]*\).*/--no\1/p' <<< $defines
sed -ne 's/^DEFINE-[^(]*(\([^,]*\).*/--\1/p' <<< "$defines"
sed -ne 's/^DEFINE-BOOL(\([^,]*\).*/--no\1/p' <<< "$defines"
}
_get_d8_flags() {
cat $v8_source/src/d8/d8.cc \
| grep "strcmp(argv\[i\]" \
grep "strcmp(argv\[i\]" "$v8_source/src/d8/d8.cc" \
| sed -ne 's/^[^"]*"--\([^"]*\)".*/--\1/p'
}
@ -75,7 +74,7 @@ _test_flag() {
return 0
}
complete -F _d8_flag -f d8
complete -F _d8_flag -f d8 v8 v8-debug
complete -F _test_flag -f cctest unittests
# Many distros set up their own GDB completion scripts. The logic below is