AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[parsing] Provide location for function redeclaration error.

Browse Source 
Bug: v8:7387
Change-Id: I831bf8f580d4112d7e0f48d90bbe2f44eff73225
Reviewed-on: https://chromium-review.googlesource.com/897326
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51047}
This commit is contained in:
Georg Neis 2018-02-01 21:10:23 +01:00 committed by Commit Bot
parent e0a761042d
commit cb01cbf2f3
5 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/parsing/parser.cc
View File

@ -1532,8 +1532,7 @@ Statement* Parser::DeclareFunction(const AstRawString* variable_name,
ZoneList<const AstRawString*>* names, ZoneList<const AstRawString*>* names,
bool* ok) { bool* ok) {
VariableProxy* proxy = VariableProxy* proxy =
factory()->NewVariableProxy(variable_name, NORMAL_VARIABLE); factory()->NewVariableProxy(variable_name, NORMAL_VARIABLE, pos);
Declaration* declaration = Declaration* declaration =
factory()->NewFunctionDeclaration(proxy, function, pos); factory()->NewFunctionDeclaration(proxy, function, pos);
Declare(declaration, DeclarationDescriptor::NORMAL, mode, kCreatedInitialized, Declare(declaration, DeclarationDescriptor::NORMAL, mode, kCreatedInitialized,

10
test/message/fail/redeclaration4.js Normal file
View File

@ -0,0 +1,10 @@
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
"use strict";
{
function foo() {}
function foo() {}
}

5
test/message/fail/redeclaration4.out Normal file
View File

@ -0,0 +1,5 @@
*%(basename)s:9: SyntaxError: Identifier 'foo' has already been declared
function foo() {}
^
SyntaxError: Identifier 'foo' has already been declared

8
test/message/fail/redeclaration5.js Normal file
View File

@ -0,0 +1,8 @@
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// MODULE
function foo() {}
function foo() {}

5
test/message/fail/redeclaration5.out Normal file
View File

@ -0,0 +1,5 @@
*%(basename)s:8: SyntaxError: Identifier 'foo' has already been declared
function foo() {}
^
SyntaxError: Identifier 'foo' has already been declared