AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Revert "Remove ENTER_V8_DO_NOT_USE usage from other macros""

Browse Source 
This reverts commit 75843f4f28.

Reason for revert: Shouldn't affect test

Original change's description:
> Revert "Remove ENTER_V8_DO_NOT_USE usage from other macros"
> 
> This reverts commit 2ba1fcda5f.
> 
> Reason for revert: Speculative for:
> https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8413
> 
> Original change's description:
> > Remove ENTER_V8_DO_NOT_USE usage from other macros
> > 
> > Eventually I want to delete that macro, so just inline it at the places
> > where we'll need to keep it.
> > 
> > BUG=v8:5830
> > R=​marja@chromium.org
> > 
> > Change-Id: I904a1dd3555c23c69e457e078faaaa86a9514932
> > Reviewed-on: https://chromium-review.googlesource.com/518043
> > Reviewed-by: Marja Hölttä <marja@chromium.org>
> > Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#45561}
> 
> NOTRY=true
> NOTREECHECKS=true
> NOPRESUBMIT=true
> 
> TBR=marja@chromium.org,jochen@chromium.org
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> BUG=v8:5830
> 
> Change-Id: I7097597d2695980f71fc93a79999d59956dd76c9
> Reviewed-on: https://chromium-review.googlesource.com/518107
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#45578}

TBR=machenbach@chromium.org,marja@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=v8:5830

Change-Id: I148f2415249c4f2a554229f814ae46688acc3918
Reviewed-on: https://chromium-review.googlesource.com/518111
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45583}
This commit is contained in:
Jochen Eisinger 2017-05-30 07:15:19 +00:00 committed by Commit Bot
parent 8339d0115d
commit cc2fb993a1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/api.cc
View File

@ -96,7 +96,7 @@ namespace v8 {
HandleScopeClass handle_scope(isolate); \
CallDepthScope<do_callback> call_depth_scope(isolate, context); \
LOG_API(isolate, class_name, function_name); \
ENTER_V8_DO_NOT_USE(isolate); \
i::VMState<v8::OTHER> __state__((isolate)); \
bool has_pending_exception = false
#define PREPARE_FOR_DEBUG_INTERFACE_EXECUTION_WITH_ISOLATE(isolate, T) \
@ -105,7 +105,7 @@ namespace v8 {
} \
InternalEscapableScope handle_scope(isolate); \
CallDepthScope<false> call_depth_scope(isolate, v8::Local<v8::Context>()); \
ENTER_V8_DO_NOT_USE(isolate); \
i::VMState<v8::OTHER> __state__((isolate)); \
bool has_pending_exception = false
#define PREPARE_FOR_EXECUTION_WITH_CONTEXT(context, class_name, function_name, \