AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Only one active new space allocation observer

Browse Source 
This CL exclusively activates ScavengeTaskObserver, used by Scavenger
and atomic MinorMC, or MinorMCTaskObserver, used by concurrent
MinorMC.

Bug: v8:13012
Change-Id: I313b0cbe250828cc76d7d4b25e9abb457315112e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871295
Commit-Queue: Leon Bettscheider <bettscheider@google.com>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82955}
This commit is contained in:
Leon Bettscheider 2022-09-02 14:55:33 +00:00 committed by V8 LUCI CQ
parent d7c306a2d9
commit cc3bd0e631
1 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/heap/heap.cc
View File

@ -5498,14 +5498,22 @@ void Heap::SetUpSpaces(LinearAllocationArea& new_allocation_info,
}
if (new_space()) {
scavenge_job_.reset(new ScavengeJob());
scavenge_task_observer_.reset(new ScavengeTaskObserver(
this, ScavengeJob::YoungGenerationTaskTriggerSize(this)));
new_space()->AddAllocationObserver(scavenge_task_observer_.get());
minor_mc_task_observer_.reset(
new MinorMCTaskObserver(this, MinorMCTaskTriggerSize()));
new_space()->AddAllocationObserver(minor_mc_task_observer_.get());
if (FLAG_concurrent_minor_mc) {
// TODO(v8:13012): Atomic MinorMC should not use ScavengeJob. Instead, we
// should schedule MinorMC tasks at a soft limit, which are used by atomic
// MinorMC, and to finalize concurrent MinorMC. The condition
// FLAG_concurrent_minor_mc can then be changed to FLAG_minor_mc (here and
// at the RemoveAllocationObserver call site).
minor_mc_task_observer_.reset(
new MinorMCTaskObserver(this, MinorMCTaskTriggerSize()));
new_space()->AddAllocationObserver(minor_mc_task_observer_.get());
} else {
// ScavengeJob is used by atomic MinorMC and Scavenger.
scavenge_job_.reset(new ScavengeJob());
scavenge_task_observer_.reset(new ScavengeTaskObserver(
this, ScavengeJob::YoungGenerationTaskTriggerSize(this)));
new_space()->AddAllocationObserver(scavenge_task_observer_.get());
}
}
SetGetExternallyAllocatedMemoryInBytesCallback(
@ -5774,8 +5782,11 @@ void Heap::TearDown() {
}
if (new_space()) {
new_space()->RemoveAllocationObserver(scavenge_task_observer_.get());
new_space()->RemoveAllocationObserver(minor_mc_task_observer_.get());
if (FLAG_concurrent_minor_mc) {
new_space()->RemoveAllocationObserver(minor_mc_task_observer_.get());
} else {
new_space()->RemoveAllocationObserver(scavenge_task_observer_.get());
}
}
scavenge_task_observer_.reset();