AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[stringrefs] Rename stringview_iter.cur to stringview_iter.next

Browse Source 
See https://github.com/WebAssembly/stringref/pull/29.

Bug: v8:12868
Change-Id: I5a1e3662a7c3457c6835d7dfccf3a1583ef49f2a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747873
Commit-Queue: Andy Wingo <wingo@igalia.com>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81570}
This commit is contained in:
Andy Wingo 2022-07-06 15:40:20 +02:00 committed by V8 LUCI CQ
parent 1e061cd2b5
commit cd33c3780e
6 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wasm/baseline/liftoff-compiler.cc
View File

@ -6614,8 +6614,8 @@ class LiftoffCompiler {
UNIMPLEMENTED();
}
void StringViewIterCur(FullDecoder* decoder, const Value& view,
Value* result) {
void StringViewIterNext(FullDecoder* decoder, const Value& view,
Value* result) {
UNIMPLEMENTED();
}

10
src/wasm/function-body-decoder-impl.h
View File

@ -1197,7 +1197,7 @@ struct ControlBase : public PcForErrors<validate> {
F(StringViewWtf16Slice, const Value& view, const Value& start, \
const Value& end, Value* result) \
F(StringAsIter, const Value& str, Value* result) \
F(StringViewIterCur, const Value& view, Value* result) \
F(StringViewIterNext, const Value& view, Value* result) \
F(StringViewIterAdvance, const Value& view, const Value& codepoints, \
Value* result) \
F(StringViewIterRewind, const Value& view, const Value& codepoints, \
@ -2177,7 +2177,7 @@ class WasmDecoder : public Decoder {
case kExprStringViewWtf16GetCodeUnit:
case kExprStringViewWtf16Slice:
case kExprStringAsIter:
case kExprStringViewIterCur:
case kExprStringViewIterNext:
case kExprStringViewIterAdvance:
case kExprStringViewIterRewind:
case kExprStringViewIterSlice:
@ -2391,7 +2391,7 @@ class WasmDecoder : public Decoder {
case kExprStringAsWtf16:
case kExprStringAsIter:
case kExprStringViewWtf16Length:
case kExprStringViewIterCur:
case kExprStringViewIterNext:
return { 1, 1 };
case kExprStringNewWtf8:
case kExprStringNewWtf16:
@ -5459,11 +5459,11 @@ class WasmFullDecoder : public WasmDecoder<validate, decoding_mode> {
Push(result);
return opcode_length;
}
case kExprStringViewIterCur: {
case kExprStringViewIterNext: {
NON_CONST_ONLY
Value view = Peek(0, 0, kWasmStringViewIter);
Value result = CreateValue(kWasmI32);
CALL_INTERFACE_IF_OK_AND_REACHABLE(StringViewIterCur, view, &result);
CALL_INTERFACE_IF_OK_AND_REACHABLE(StringViewIterNext, view, &result);
Drop(view);
Push(result);
return opcode_length;

4
src/wasm/graph-builder-interface.cc
View File

@ -1533,8 +1533,8 @@ class WasmGraphBuildingInterface {
UNIMPLEMENTED();
}
void StringViewIterCur(FullDecoder* decoder, const Value& view,
Value* result) {
void StringViewIterNext(FullDecoder* decoder, const Value& view,
Value* result) {
UNIMPLEMENTED();
}

2
src/wasm/wasm-opcodes.h
View File

@ -757,7 +757,7 @@ bool V8_EXPORT_PRIVATE IsJSCompatibleSignature(const FunctionSig* sig,
V(StringViewWtf16Encode, 0xfb9b, _, "stringview_wtf16.encode") \
V(StringViewWtf16Slice, 0xfb9c, _, "stringview_wtf16.slice") \
V(StringAsIter, 0xfba0, _, "string.as_iter") \
V(StringViewIterCur, 0xfba1, _, "stringview_iter.cur") \
V(StringViewIterNext, 0xfba1, _, "stringview_iter.next") \
V(StringViewIterAdvance, 0xfba2, _, "stringview_iter.advance") \
V(StringViewIterRewind, 0xfba3, _, "stringview_iter.rewind") \
V(StringViewIterSlice, 0xfba4, _, "stringview_iter.slice") \

4
test/mjsunit/wasm/stringrefs-valid.js
View File

@ -233,10 +233,10 @@ let kSig_w_zi = makeSig([kWasmStringViewIter, kWasmI32],
kGCPrefix, kExprStringAsIter
]);
builder.addFunction("stringview_iter.cur", kSig_i_z)
builder.addFunction("stringview_iter.next", kSig_i_z)
.addBody([
kExprLocalGet, 0,
kGCPrefix, kExprStringViewIterCur
kGCPrefix, kExprStringViewIterNext
]);
builder.addFunction("stringview_iter.advance", kSig_i_zi)

2
test/mjsunit/wasm/wasm-module-builder.js
View File

@ -553,7 +553,7 @@ let kExprStringViewWtf16GetCodeunit = 0x9a;
let kExprStringViewWtf16Encode = 0x9b;
let kExprStringViewWtf16Slice = 0x9c;
let kExprStringAsIter = 0xa0;
let kExprStringViewIterCur = 0xa1
let kExprStringViewIterNext = 0xa1
let kExprStringViewIterAdvance = 0xa2;
let kExprStringViewIterRewind = 0xa3
let kExprStringViewIterSlice = 0xa4;