From cdb12d8703ed4ac4c1529add54cd2443bc1b3637 Mon Sep 17 00:00:00 2001
From: Leszek Swirski <leszeks@chromium.org>
Date: Tue, 7 Feb 2023 08:37:48 +0000
Subject: [PATCH] Revert "Create a MicrotasksScope for async GC"

This reverts commit 46a5dd02568cec0866fb29aebec6333cd84345ea.

Reason for revert: Closed the waterfall, seems to be causing timeouts: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64/49979/overview

Original change's description:
> Create a MicrotasksScope for async GC
>
> When running the async version of window.gc()
> (e.g. window.gc({type: 'major', execution: 'async'})),
> the promise is resolved without a MicrotasksScope, causing us to hit a
> DCHECK.
>
> Change-Id: I10f72c96605263afacc01afbfcc56d1134d84b43
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4220146
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Kevin McNee <mcnee@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#85698}

Change-Id: I34edd72d28a126d93e6ba68ed64b3a9f965f62e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4224395
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#85699}
---
 src/extensions/gc-extension.cc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/extensions/gc-extension.cc b/src/extensions/gc-extension.cc
index 16fdeb457b..98cfe7f14f 100644
--- a/src/extensions/gc-extension.cc
+++ b/src/extensions/gc-extension.cc
@@ -5,7 +5,6 @@
 #include "src/extensions/gc-extension.h"
 
 #include "include/v8-isolate.h"
-#include "include/v8-microtask-queue.h"
 #include "include/v8-object.h"
 #include "include/v8-persistent-handle.h"
 #include "include/v8-primitive.h"
@@ -122,8 +121,6 @@ class AsyncGC final : public CancelableTask {
     InvokeGC(isolate_, ExecutionType::kAsync, type_);
     auto resolver = v8::Local<v8::Promise::Resolver>::New(isolate_, resolver_);
     auto ctx = Local<v8::Context>::New(isolate_, ctx_);
-    v8::MicrotasksScope microtasks_scope(
-        ctx, v8::MicrotasksScope::kDoNotRunMicrotasks);
     resolver->Resolve(ctx, v8::Undefined(isolate_)).ToChecked();
   }