From ce1386697f20e49daa424594dc905f2a4f1ddc0d Mon Sep 17 00:00:00 2001 From: "zhengxing.li" Date: Wed, 24 Aug 2016 04:06:17 -0700 Subject: [PATCH] [TurboFan] Avoid Gcc compilation fail by Initializing rest_index variable. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The CL #38858 (https://codereview.chromium.org/2269293004) removed the parameter assignment code in rest_parameter(int* index) function in Class DeclarationScope. This caused the Gcc compilation fail at the following code in src/compiler/ast-graph-builder.cc, line 576. int rest_index; Variable* rest_parameter = scope->rest_parameter(&rest_index); BuildRestArgumentsArray(rest_parameter, rest_index); The error message was: ../src/compiler/ast-graph-builder.cc: In member function ‘void v8::internal::compiler::AstGraphBuilder::CreateGraphBody(bool)’: ../src/compiler/ast-graph-builder.cc:578:54: error: ‘rest_index’ may be used uninitialized in this function [-Werror=maybe-uninitialized] BuildRestArgumentsArray(rest_parameter, rest_index); ^ This CL fixed this issue by intializing rest_index to 0. BUG= Review-Url: https://codereview.chromium.org/2270363003 Cr-Commit-Position: refs/heads/master@{#38863} --- src/compiler/ast-graph-builder.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc index 0f1fb291eb..188a5134c8 100644 --- a/src/compiler/ast-graph-builder.cc +++ b/src/compiler/ast-graph-builder.cc @@ -573,7 +573,7 @@ void AstGraphBuilder::CreateGraphBody(bool stack_check) { BuildArgumentsObject(scope->arguments()); // Build rest arguments array if it is used. - int rest_index; + int rest_index = 0; Variable* rest_parameter = scope->rest_parameter(&rest_index); BuildRestArgumentsArray(rest_parameter, rest_index);