AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove redundant PeekArgs implementation

Browse Source 
We have a PeekArgs version that operates on a signature, and another
version that operates on a vector of value types. We can easily get the
latter from the former and remove one of the two identical
implementations.

R=jkummerow@chromium.org

Bug: v8:13636
Change-Id: Ib60d323c810305e4604eff1d1c95079b7b176676
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4188394
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85453}
This commit is contained in:
Clemens Backes 2023-01-24 13:48:31 +01:00 committed by V8 LUCI CQ
parent 0863bcdf71
commit ce371f6bb8
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/wasm/function-body-decoder-impl.h
View File

@ -4065,15 +4065,11 @@ class WasmFullDecoder : public WasmDecoder<ValidationTag, decoding_mode> {
// Peeks arguments as required by signature.
V8_INLINE ArgVector PeekArgs(const FunctionSig* sig, int depth = 0) {
int count = static_cast<int>(sig->parameter_count());
if (count == 0) return {};
EnsureStackArguments(depth + count);
ArgVector args(stack_value(depth + count), count);
for (int i = 0; i < count; i++) {
ValidateArgType(args, i, sig->GetParam(i));
}
return args;
return PeekArgs(
base::VectorOf(sig->parameters().begin(), sig->parameter_count()),
depth);
}
// Drops a number of stack elements equal to the {sig}'s parameter count (0 if
// {sig} is null), or all of them if less are present.
V8_INLINE void DropArgs(const FunctionSig* sig) {
@ -4097,10 +4093,12 @@ class WasmFullDecoder : public WasmDecoder<ValidationTag, decoding_mode> {
Drop(static_cast<int>(type->field_count()));
}
V8_INLINE ArgVector PeekArgs(base::Vector<ValueType> arg_types) {
V8_INLINE ArgVector PeekArgs(base::Vector<const ValueType> arg_types,
int depth = 0) {
int size = static_cast<int>(arg_types.size());
EnsureStackArguments(size);
ArgVector args(stack_value(size), arg_types.size());
if (size == 0) return {};
EnsureStackArguments(size + depth);
ArgVector args(stack_value(size + depth), arg_types.size());
for (int i = 0; i < size; i++) {
ValidateArgType(args, i, arg_types[i]);
}