AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

make ToLocalCheck crash in release mode

Browse Source 
R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1043363005

Cr-Commit-Position: refs/heads/master@{#27585}
This commit is contained in:
dcarney 2015-04-02 03:59:45 -07:00 committed by Commit bot
parent 64b3dc9082
commit ce7cc5119c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/v8.h
View File

@ -439,7 +439,7 @@ class MaybeLocal {
return !IsEmpty(); return !IsEmpty();
} }
// Will crash when checks are enabled if the MaybeLocal<> is empty. // Will crash if the MaybeLocal<> is empty.
V8_INLINE Local<T> ToLocalChecked(); V8_INLINE Local<T> ToLocalChecked();
template <class S> template <class S>
@ -6909,9 +6909,7 @@ Local<T> Eternal<T>::Get(Isolate* isolate) {
template <class T> template <class T>
Local<T> MaybeLocal<T>::ToLocalChecked() { Local<T> MaybeLocal<T>::ToLocalChecked() {
#ifdef V8_ENABLE_CHECKS if (V8_UNLIKELY(val_ == nullptr)) V8::ToLocalEmpty();
if (val_ == nullptr) V8::ToLocalEmpty();
#endif
return Local<T>(val_); return Local<T>(val_);
} }