AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

MIPS64: Fix allocation folding test failures.

Browse Source 
Allocation folding tests are failing in debug mode, since the change
https://codereview.chromium.org/1972553002 (6e15433db4) introduced a debug check in
lithium-codegen-mips64.cc, line 5287.

Reason for failure is to be found in https://codereview.chromium.org/1899813003 (61f5fbbb19),
which is missing changes calling LFastAllocate in lithium-mips64.cc.

BUG=

Review-Url: https://codereview.chromium.org/1977833002
Cr-Commit-Position: refs/heads/master@{#36246}
This commit is contained in:
marija.antic 2016-05-13 07:51:12 -07:00 committed by Commit bot
parent 48a1c5667a
commit ced0f49763
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/crankshaft/mips64/lithium-mips64.cc
View File

@ -2303,13 +2303,18 @@ LInstruction* LChunkBuilder::DoStringCharFromCode(HStringCharFromCode* instr) {
LInstruction* LChunkBuilder::DoAllocate(HAllocate* instr) {
info()->MarkAsDeferredCalling();
LOperand* context = UseAny(instr->context());
LOperand* size = UseRegisterOrConstant(instr->size());
LOperand* temp1 = TempRegister();
LOperand* temp2 = TempRegister();
LAllocate* result = new(zone()) LAllocate(context, size, temp1, temp2);
return AssignPointerMap(DefineAsRegister(result));
if (instr->IsAllocationFolded()) {
LFastAllocate* result = new (zone()) LFastAllocate(size, temp1, temp2);
return DefineAsRegister(result);
} else {
info()->MarkAsDeferredCalling();
LOperand* context = UseAny(instr->context());
LAllocate* result = new (zone()) LAllocate(context, size, temp1, temp2);
return AssignPointerMap(DefineAsRegister(result));
}
}