AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[maglev] Prepare BranchIfCompare

Browse Source 
Define dummy BranchIfCompare, a conditional control node
that accepts more than one input node.

Bug: v8:7700
Change-Id: If29b6e9531e8a75a4e94fb2057d8e8d36cf0d9ee
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3506376
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79399}
This commit is contained in:
Victor Gomes 2022-03-08 10:02:05 +01:00 committed by V8 LUCI CQ
parent cc828bb4e8
commit cef57b958a
2 changed files with 41 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/maglev/maglev-ir.cc
View File

@ -876,6 +876,14 @@ void BranchIfTrue::GenerateCode(MaglevCodeGenState* code_gen_state,
}
}
void BranchIfCompare::AllocateVreg(MaglevVregAllocationState* vreg_state,
const ProcessingState& state) {}
void BranchIfCompare::GenerateCode(MaglevCodeGenState* code_gen_state,
const ProcessingState& state) {
USE(operation_);
UNREACHABLE();
}
void BranchIfToBooleanTrue::AllocateVreg(MaglevVregAllocationState* vreg_state,
const ProcessingState& state) {
UseFixed(condition_input(),

41
src/maglev/maglev-ir.h
View File

@ -1324,8 +1324,6 @@ class ConditionalControlNode : public ControlNode {
if_true_(if_true_refs),
if_false_(if_false_refs) {}
Input& condition_input() { return input(0); }
BasicBlock* if_true() const { return if_true_.block_ptr(); }
BasicBlock* if_false() const { return if_false_.block_ptr(); }
@ -1334,10 +1332,10 @@ class ConditionalControlNode : public ControlNode {
BasicBlockRef if_false_;
};
template <class Derived>
template <size_t InputCount, class Derived>
class ConditionalControlNodeT : public ConditionalControlNode {
STATIC_ASSERT(IsConditionalControlNode(opcode_of<Derived>));
static constexpr size_t kInputCount = 1;
static constexpr size_t kInputCount = InputCount;
public:
// Shadowing for static knowledge.
@ -1398,22 +1396,24 @@ class Return : public ControlNode {
void PrintParams(std::ostream&, MaglevGraphLabeller*) const {}
};
class BranchIfTrue : public ConditionalControlNodeT<BranchIfTrue> {
using Base = ConditionalControlNodeT<BranchIfTrue>;
class BranchIfTrue : public ConditionalControlNodeT<1, BranchIfTrue> {
using Base = ConditionalControlNodeT<1, BranchIfTrue>;
public:
explicit BranchIfTrue(size_t input_count, BasicBlockRef* if_true_refs,
BasicBlockRef* if_false_refs)
: Base(input_count, if_true_refs, if_false_refs) {}
Input& condition_input() { return input(0); }
void AllocateVreg(MaglevVregAllocationState*, const ProcessingState&);
void GenerateCode(MaglevCodeGenState*, const ProcessingState&);
void PrintParams(std::ostream&, MaglevGraphLabeller*) const {}
};
class BranchIfToBooleanTrue
: public ConditionalControlNodeT<BranchIfToBooleanTrue> {
using Base = ConditionalControlNodeT<BranchIfToBooleanTrue>;
: public ConditionalControlNodeT<1, BranchIfToBooleanTrue> {
using Base = ConditionalControlNodeT<1, BranchIfToBooleanTrue>;
public:
explicit BranchIfToBooleanTrue(size_t input_count,
@ -1423,11 +1423,36 @@ class BranchIfToBooleanTrue
static constexpr OpProperties kProperties = OpProperties::Call();
Input& condition_input() { return input(0); }
void AllocateVreg(MaglevVregAllocationState*, const ProcessingState&);
void GenerateCode(MaglevCodeGenState*, const ProcessingState&);
void PrintParams(std::ostream&, MaglevGraphLabeller*) const {}
};
class BranchIfCompare
: public ConditionalControlNodeT<2, BranchIfToBooleanTrue> {
using Base = ConditionalControlNodeT<2, BranchIfToBooleanTrue>;
public:
static constexpr int kLeftIndex = 0;
static constexpr int kRightIndex = 1;
Input& left_input() { return NodeBase::input(kLeftIndex); }
Input& right_input() { return NodeBase::input(kRightIndex); }
explicit BranchIfCompare(size_t input_count, Operation operation,
BasicBlockRef* if_true_refs,
BasicBlockRef* if_false_refs)
: Base(input_count, if_true_refs, if_false_refs), operation_(operation) {}
void AllocateVreg(MaglevVregAllocationState*, const ProcessingState&);
void GenerateCode(MaglevCodeGenState*, const ProcessingState&);
void PrintParams(std::ostream&, MaglevGraphLabeller*) const {}
private:
Operation operation_;
};
const OpProperties& NodeBase::properties() const {
switch (opcode()) {
#define V(Name) \