AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[proxies] Fix JSObject::AllCanRead for Proxies on the prototype chain

Browse Source 
Review URL: https://codereview.chromium.org/1517753003

Cr-Commit-Position: refs/heads/master@{#32805}
This commit is contained in:
jkummerow 2015-12-11 07:51:35 -08:00 committed by Commit bot
parent c77c1ca80b
commit cf46317483
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/objects.cc
View File

@ -1188,6 +1188,9 @@ bool JSObject::AllCanRead(LookupIterator* it) {
} }
} else if (it->state() == LookupIterator::INTERCEPTOR) { } else if (it->state() == LookupIterator::INTERCEPTOR) {
if (it->GetInterceptor()->all_can_read()) return true; if (it->GetInterceptor()->all_can_read()) return true;
} else if (it->state() == LookupIterator::JSPROXY) {
// Stop lookupiterating. And no, AllCanNotRead.
return false;
} }
} }
return false; return false;

15
test/mjsunit/harmony/proxies-accesschecks.js Normal file
View File

@ -0,0 +1,15 @@
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-proxies
var realm = Realm.create();
this.__proto__ = new Proxy({}, {
getPrototypeOf() { assertUnreachable() },
get() { assertUnreachable() }
});
var other_type_error = Realm.eval(realm, "TypeError");
assertThrows(() => Realm.eval(realm, "Realm.global(0).foo"), other_type_error);