From cf568ea0ede265fbc81844fc0bb94850b8ae5c1c Mon Sep 17 00:00:00 2001 From: "ulan@chromium.org" Date: Wed, 19 Feb 2014 09:24:44 +0000 Subject: [PATCH] Do not emit receiver map in CheckPrototypes. BUG= R=verwaest@chromium.org Review URL: https://codereview.chromium.org/170613002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/a64/stub-cache-a64.cc | 3 --- src/arm/stub-cache-arm.cc | 3 --- src/ia32/stub-cache-ia32.cc | 3 --- src/mips/stub-cache-mips.cc | 3 --- src/x64/stub-cache-x64.cc | 3 --- 5 files changed, 15 deletions(-) diff --git a/src/a64/stub-cache-a64.cc b/src/a64/stub-cache-a64.cc index 57c03e8b96..31132867da 100644 --- a/src/a64/stub-cache-a64.cc +++ b/src/a64/stub-cache-a64.cc @@ -840,9 +840,6 @@ Register StubCompiler::CheckPrototypes(Handle type, Label* miss, PrototypeCheckType check) { Handle receiver_map(IC::TypeToMap(*type, isolate())); - // Make sure that the type feedback oracle harvests the receiver map. - // TODO(svenpanne) Remove this hack when all ICs are reworked. - __ Mov(scratch1, Operand(receiver_map)); // object_reg and holder_reg registers can alias. ASSERT(!AreAliased(object_reg, scratch1, scratch2)); diff --git a/src/arm/stub-cache-arm.cc b/src/arm/stub-cache-arm.cc index 3bc9554594..1bb772e0a1 100644 --- a/src/arm/stub-cache-arm.cc +++ b/src/arm/stub-cache-arm.cc @@ -879,9 +879,6 @@ Register StubCompiler::CheckPrototypes(Handle type, Label* miss, PrototypeCheckType check) { Handle receiver_map(IC::TypeToMap(*type, isolate())); - // Make sure that the type feedback oracle harvests the receiver map. - // TODO(svenpanne) Remove this hack when all ICs are reworked. - __ mov(scratch1, Operand(receiver_map)); // Make sure there's no overlap between holder and object registers. ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg)); diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc index 4bc428849c..c790a14e87 100644 --- a/src/ia32/stub-cache-ia32.cc +++ b/src/ia32/stub-cache-ia32.cc @@ -861,9 +861,6 @@ Register StubCompiler::CheckPrototypes(Handle type, Label* miss, PrototypeCheckType check) { Handle receiver_map(IC::TypeToMap(*type, isolate())); - // Make sure that the type feedback oracle harvests the receiver map. - // TODO(svenpanne) Remove this hack when all ICs are reworked. - __ mov(scratch1, receiver_map); // Make sure there's no overlap between holder and object registers. ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg)); diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc index 7e3c801399..a6f050dfd2 100644 --- a/src/mips/stub-cache-mips.cc +++ b/src/mips/stub-cache-mips.cc @@ -868,9 +868,6 @@ Register StubCompiler::CheckPrototypes(Handle type, Label* miss, PrototypeCheckType check) { Handle receiver_map(IC::TypeToMap(*type, isolate())); - // Make sure that the type feedback oracle harvests the receiver map. - // TODO(svenpanne) Remove this hack when all ICs are reworked. - __ li(scratch1, Operand(receiver_map)); // Make sure there's no overlap between holder and object registers. ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg)); diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc index 346d5e805d..1e6dc9a5b9 100644 --- a/src/x64/stub-cache-x64.cc +++ b/src/x64/stub-cache-x64.cc @@ -774,9 +774,6 @@ Register StubCompiler::CheckPrototypes(Handle type, Label* miss, PrototypeCheckType check) { Handle receiver_map(IC::TypeToMap(*type, isolate())); - // Make sure that the type feedback oracle harvests the receiver map. - // TODO(svenpanne) Remove this hack when all ICs are reworked. - __ Move(scratch1, receiver_map); // Make sure there's no overlap between holder and object registers. ASSERT(!scratch1.is(object_reg) && !scratch1.is(holder_reg));