AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix rerun barrier for flaky tests.

Browse Source 
- The rerun flag doesn't include the first run.
- Timeout is an int. The division makes it 0 for small
numbers.

BUG=374134
LOG=n
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/364793007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
machenbach@chromium.org 2014-07-02 15:33:21 +00:00
parent 2350d46146
commit cf88d3c953
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/testrunner/local/execution.py
View File

@ -104,9 +104,9 @@ class Runner(object):
return Job(command, dep_command, test.id, timeout, self.context.verbose)
def _MaybeRerun(self, pool, test):
if test.run <= self.context.rerun_failures_count:
if test.run <= self.context.rerun_failures_count + 1:
# Possibly rerun this test if its run count is below the maximum per
# test.
# test. +1 as the flag controls reruns not including the first run.
if test.run == 1:
# Count the overall number of reran tests on the first rerun.
if self.reran_tests < self.context.rerun_failures_max:
@ -115,7 +115,7 @@ class Runner(object):
# Don't rerun this if the overall number of rerun tests has been
# reached.
return
if test.run >= 2 and test.duration > self.context.timeout / 20:
if test.run >= 2 and test.duration > self.context.timeout / 20.0:
# Rerun slow tests at most once.
return