From d0eb929632c01615df182cc8fc6f8e9b5009eb3b Mon Sep 17 00:00:00 2001 From: Victor Gomes Date: Tue, 1 Feb 2022 16:50:20 +0100 Subject: [PATCH] [runtime] Update kScopeInfoMaxInlinedLocalNamesSize Threshold analysis: https://docs.google.com/document/d/19xRt6UeRQ-ml0rwDRdY3LED0G2fpi1p4Rh-FH6_YzmU Bug: v8:12315, chromium:1292983 Change-Id: I00478e16e7c971e0963d750417e7ff06547fada3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3429210 Commit-Queue: Victor Gomes Auto-Submit: Victor Gomes Reviewed-by: Manos Koukoutos Commit-Queue: Manos Koukoutos Cr-Commit-Position: refs/heads/main@{#78891} --- src/common/globals.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/common/globals.h b/src/common/globals.h index 29495a3702..ea1ce693c6 100644 --- a/src/common/globals.h +++ b/src/common/globals.h @@ -1153,7 +1153,9 @@ inline std::ostream& operator<<(std::ostream& os, CreateArgumentsType type) { UNREACHABLE(); } -constexpr int kScopeInfoMaxInlinedLocalNamesSize = 32; +// Threshold calculated using a microbenckmark. +// https://chromium-review.googlesource.com/c/v8/v8/+/3429210 +constexpr int kScopeInfoMaxInlinedLocalNamesSize = 75; enum ScopeType : uint8_t { CLASS_SCOPE, // The scope introduced by a class.